From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 60358388C006 for ; Tue, 2 Mar 2021 23:16:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 60358388C006 Received: by mail-il1-x129.google.com with SMTP id i18so19601791ilq.13 for ; Tue, 02 Mar 2021 15:16:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=uQ0Ffj6CPs0kJ1awSRBO9AnBwPT1jq39k55djtlA5DY=; b=XQin75dWTdYfWL7z10H6HRDWs3hUEWyfLT6kyu8ZO2PVXplxMJhDfC1UvHW7fagK2a fUDXD/P0/8nOp2DKovOs1xDL06xrLizSKcSgT6njFhRGFamOhhzZC897Oh0A97zM8MVJ xVTjpXjd2Y9Q6UGL3yoHKBixSRcXdQJ0tTeuhQ93QuoFBEH7H0LBBgMBMrswx6Z0IUMk JTCD4mxB53NjWI7V6lPdJrG4ToTXLetA6qfNkXsX6Ws3Mei+nRO4KrU7Qyl1f5WD+aoK gXZDJ1Vi9GH16Byf/jzt37y4YH9dCrcAsmQeiTP6uQl25DwUihm35Y1YJCUQYlkxYhsv Ip+Q== X-Gm-Message-State: AOAM531YPlsJsYx9P8b94ygGMx6bNt0GpRZyHX7cZocq3AOKwXOM/ygT CCorN80rTB2tnEvT/6QwDhU= X-Google-Smtp-Source: ABdhPJw7z2Bev7h80mEXrrCk/SZP1rx8j3cAiNheFvEtjV0Lg5X1jxtV2i6qunruZCDsIOiE6UIvug== X-Received: by 2002:a92:444b:: with SMTP id a11mr4418299ilm.291.1614727003829; Tue, 02 Mar 2021 15:16:43 -0800 (PST) Received: from localhost.localdomain (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id l14sm10861863ilh.58.2021.03.02.15.16.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Mar 2021 15:16:43 -0800 (PST) Subject: Re: [PATCH] MIPS: Fix PR target/98491 (ChangeLog) To: Xi Ruoyao via Gcc-patches , Jeff Law , Jakub Jelinek , Xi Ruoyao , richard.sandiford@arm.com References: <4df733093ede4a3cc5dcb2688dcc9a2e5be4b721.camel@mengyan1223.wang> <184fa89ee34af9c3b13e99513a10aed1bd7c88af.camel@mengyan1223.wang> <20210104210018.GD725145@tucnak> <7825bdca-1a9a-90dc-671f-1dda98e1f5f4@redhat.com> <4e71a5bbf8736f6ab86c49fca750c5d84e295a33.camel@mengyan1223.wang> <86c3b13cbe7c3add9e47ba13f50bff90cf25f0d8.camel@mengyan1223.wang> From: Jeff Law Message-ID: <4d0fde15-68e1-70f3-ff30-e05354fc70f3@gmail.com> Date: Tue, 2 Mar 2021 16:16:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Mar 2021 23:16:45 -0000 On 2/17/21 5:02 AM, Richard Sandiford wrote: > Xi Ruoyao via Gcc-patches writes: >>>>>> I can't understand the comment either.  To me it looks like it's >>>>>> possible to >>>>>> remove this "if (MSA_SUPPORTED_P (mode)) return 0;" > I think the point is that the MSA loads and stores only have a 10-bit > offset field instead of the usual 16-bit offset field and so the usual > approaches to handling symbolic addresses won't work. Ah. > >>>>>> CC Robert to get some help. >>>>> Happy new lunar year folks. >>>>> >>>>> I found a newer email address of Robert.  Hope it is still being used. >>>>> >>>>> Could someone update MAINTAINERS file by the way? >>>> If you have an updated email address, I can reach out to Robert and see >>>> if he wants his entry updated or removed. >>>  His latest reply in gcc mail lists used Robert.Suchanek@mips.com.  But when I >>> sent mail to it, the mail was just rejected with "access denied".  Google told >>> me Office 365 mail service (used by mips.com) rejects mail to deleted accounts >>> with "access denied". So I'm not sure if this email address is invalid again, >>> or >>> Office 365 just dislikes me... >> Hi Jeff, >> >> I think it's better to just fix the out-of-bound array access now by special >> casing MAX_MACHINE_MODE, if we can't figure out if this entry should be removed. >> Either in MSA_SUPPORTED_P or in mips_symbol_insns. >> >> It's really "irrational" to leave such a obvious programming error in new GCC 11 >> release... And I've built a Linux system (in Linux From Scratch way, X11 was >> built and it runs correctly now) on the Loongson 3A4000 with patched GCC-10.2.0, >> and "-O3 -mmsa" in CFLAGS for most packages so the change should be OK. > Yeah, agreed. I think the mips_symbol_insns patch is the right one, > so I've pushed to it trunk. I think it's also worth backporting > to release branches, but let me know how far back you've tested it. Seems reasonable to me.  THanks for lending a hand on this Richard. jeff