From: Jan Beulich <jbeulich@suse.com>
To: gcc-patches@gcc.gnu.org
Cc: "bonzini@gnu.org" <bonzini@gnu.org>,
neroden@gcc.gnu.org, aoliva@gcc.gnu.org, Ralf.Wildenhues@gmx.de
Subject: Ping: [PATCH] libatomic: drop redundant all-multi command
Date: Tue, 28 Jun 2022 08:52:16 +0200 [thread overview]
Message-ID: <4d101a46-dadf-4771-e5a8-c5d9d85d2e20@suse.com> (raw)
In-Reply-To: <ec8ebf7a-793d-6aa1-f550-0f1cc0b15ce0@suse.com>
On 27.05.2022 10:01, Jan Beulich wrote:
> ./multilib.am already specifies this same command, and make warns about
> the earlier one being ignored when seeing the later one. All that needs
> retaining to still satisfy the preceding comment is the extra
> dependency.
>
> libatomic/
>
> * Makefile.am (all-multi): Drop commands.
> * Makefile.in: Update accordingly.
Ping?
Thanks, Jan
> --- a/libatomic/Makefile.am
> +++ b/libatomic/Makefile.am
> @@ -147,12 +147,11 @@
> libatomic_convenience_la_SOURCES = $(libatomic_la_SOURCES)
> libatomic_convenience_la_LIBADD = $(libatomic_la_LIBADD)
>
> -# Override the automake generated all-multi rule to guarantee that all-multi
> +# Amend the automake generated all-multi rule to guarantee that all-multi
> # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
> # makefile fragments to avoid broken *.Ppo getting included into the Makefile
> # when it is reloaded during the build of all-multi.
> all-multi: $(libatomic_la_LIBADD)
> - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
>
> # target overrides
> -include $(tmake_file)
> --- a/libatomic/Makefile.in
> +++ b/libatomic/Makefile.in
> @@ -858,12 +858,11 @@
> %_.lo: Makefile
> $(LTCOMPILE) $(M_DEPS) $(M_SIZE) $(M_IFUNC) -c -o $@ $(M_SRC)
>
> -# Override the automake generated all-multi rule to guarantee that all-multi
> +# Amend the automake generated all-multi rule to guarantee that all-multi
> # is not run in parallel with the %_.lo rules which generate $(DEPDIR)/*.Ppo
> # makefile fragments to avoid broken *.Ppo getting included into the Makefile
> # when it is reloaded during the build of all-multi.
> all-multi: $(libatomic_la_LIBADD)
> - $(MULTIDO) $(AM_MAKEFLAGS) DO=all multi-do # $(MAKE)
>
> # target overrides
> -include $(tmake_file)
next prev parent reply other threads:[~2022-06-28 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 8:01 Jan Beulich
2022-05-28 18:25 ` Jeff Law
2022-06-28 6:52 ` Jan Beulich [this message]
2022-06-28 16:06 ` Ping: [PATCH] " Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d101a46-dadf-4771-e5a8-c5d9d85d2e20@suse.com \
--to=jbeulich@suse.com \
--cc=Ralf.Wildenhues@gmx.de \
--cc=aoliva@gcc.gnu.org \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=neroden@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).