From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 99B2C3858C74; Tue, 9 Jan 2024 19:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99B2C3858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99B2C3858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704829500; cv=none; b=YTj2mDbyysYsILhkUvoqnSz1u843C9hr9Z8DWWGu0rW6JvQDHpPlu8j5AYrUcF+vC106PKwmp2NF+8DyX7ygxLrpe3z4l7VGyCFuQ3rb+rt3szZA1SBX7uQh8GiNJZ4N2/4X+EqDt4Ps3e1sGsWS7EtmloP8rDSCPFLHz1JiAvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704829500; c=relaxed/simple; bh=4JFluw4z4dX3u+5wNT1gRHpVOLrTP246/V5C0EeHUaE=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=I1PAoGdWyL4CGDjnPYzNs4DcHm9XKvtqohm0iIpJgzTbec8nsyFHWoWUeLQHzj2JVj4g1EGSbopwoTOHoDG9PCzw6wGQrivmYQnNCY4J9gGwuc/OHYR5yBHjTjNwysZYM5cayO4X0MhqBnd7xM8OatRAjDeDSp1mX87IhzXkS6E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353726.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 409Inqg1009261; Tue, 9 Jan 2024 19:44:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : content-transfer-encoding : mime-version; s=pp1; bh=Cifc4GwDoyLwpP59AfRndvy28JmrrV5C3XA36Q+tOjQ=; b=e9dEGDCXg08Q2Ayt5MC8KdhyMvEUH5qPTEm6ve9QqGODrFXlI61ppl1oMPDYMQ+Vg9ij meE2dTQAeTSXh2gRM0njPW6tcGM+x/F9kXnzE4HiZ4sowgUe7lx7VFG4Ew6heXEyeNiu 9r2eHvjvITksFLRzI9Vg7+Q66wbSJrVd7jmQnCTXHbmfPxCsx3LD72N1rQcETR5OxlYn Qd0UC8XccIbKWnikXLPuQigiBIvnSbpNvM5WjmPBTLbPwZtTA3wAONEaSpIXhnOdB1/c 336a8NEPhNEIWPPcgEv1l/5cf0Cvc+cdsOP3frR62pwgYG/e0SCfnl0sD5ooauYdAuRv 3Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vhab53rc0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 19:44:54 +0000 Received: from m0353726.ppops.net (m0353726.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 409J0DqQ021023; Tue, 9 Jan 2024 19:44:53 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3vhab53rbm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 19:44:53 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 409Invw9022793; Tue, 9 Jan 2024 19:44:52 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3vfhjygy0q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 09 Jan 2024 19:44:52 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 409Jio9449021188 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Jan 2024 19:44:50 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 49FFC20040; Tue, 9 Jan 2024 19:44:50 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C889520049; Tue, 9 Jan 2024 19:44:49 +0000 (GMT) Received: from [9.171.60.193] (unknown [9.171.60.193]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 9 Jan 2024 19:44:49 +0000 (GMT) Message-ID: <4d69403e2dec75bb1ba5e14b97b6536db97a5798.camel@linux.ibm.com> Subject: Re: [PATCH v2 2/2] asan: Align .LASANPC on function boundary From: Ilya Leoshkevich To: Jeff Law , Jakub Jelinek , Jeff Law , Richard Sandiford Cc: Andreas Krebbel , gcc-patches@gcc.gnu.org, Segher Boessenkool , Stefan Schulze Frielinghaus Date: Tue, 09 Jan 2024 20:44:49 +0100 In-Reply-To: <31208620-16ed-4453-af96-cfdc463d0adc@gmail.com> References: <20240102194511.3171559-1-iii@linux.ibm.com> <20240102194511.3171559-3-iii@linux.ibm.com> <31208620-16ed-4453-af96-cfdc463d0adc@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: SbOPGnE-6ar6WZST-U-zsDLoArd3bxdN X-Proofpoint-GUID: REtq0MZvG7dYEV0s_hgeVy9_Zs8phKwz Content-Transfer-Encoding: quoted-printable X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-09_09,2024-01-09_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=943 impostorscore=0 mlxscore=0 malwarescore=0 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401090159 X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2024-01-09 at 11:55 -0700, Jeff Law wrote: >=20 >=20 > On 1/2/24 12:41, Ilya Leoshkevich wrote: > > GCC can emit code between the function label and the .LASANPC > > label, > > making the latter unaligned.=C2=A0 Some architectures cannot load > > unaligned > > labels directly and require literal pool entries, which is > > inefficient. > >=20 > > Move the invocation of asan_function_start to > > ASM_OUTPUT_FUNCTION_LABEL, which guarantees that no additional code > > is > > emitted.=C2=A0 This allows setting the .LASANPC label alignment to the > > respective function alignment. > > --- > > =C2=A0 gcc/asan.cc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 |=C2=A0 6 ++---- > > =C2=A0 gcc/config/i386/i386.cc |=C2=A0 2 +- > > =C2=A0 gcc/config/s390/s390.cc |=C2=A0 2 +- > > =C2=A0 gcc/defaults.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 2 +- > > =C2=A0 gcc/final.cc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0 3 --- > > =C2=A0 gcc/output.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0 4 ++++ > > =C2=A0 gcc/varasm.cc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 | 14 ++++++++++++++ > > =C2=A0 7 files changed, 23 insertions(+), 10 deletions(-) > So this needs a ChangeLog obviously.=C2=A0 I assume you've tested on > s390[x].=20 > =C2=A0 It should also be tested on x86 since it's the only other platform= =20 > that redefined ASM_OUTPUT_FUNCTION_LABEL. >=20 > Assuming those tests pass without regression, then this is fine for > the=20 > trunk. >=20 > Thanks, > Jeff Hi Jeff, Since Jakub already approved this 2/2, you approved 1/2, and x86_64/ppc64le/s390x regtests were successful, I've already pushed this series (with ChangeLogs). Unfortunately people discovered two regressions on i686 [1] and ppc64be [2]. The first one is already sorted out, I'm currently regtesting the fix for the second one and will push it as soon as it's done. Best regards, Ilya [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113251 [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D113284