From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) by sourceware.org (Postfix) with ESMTPS id 167543858CDA for ; Sat, 11 Mar 2023 19:22:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 167543858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=pfeifer.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=pfeifer.com Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 6FC7B33E73; Sat, 11 Mar 2023 14:22:19 -0500 (EST) Received: from naga.localdomain (188-23-63-229.adsl.highway.telekom.at [188.23.63.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id A9A6A33E65; Sat, 11 Mar 2023 14:22:18 -0500 (EST) Date: Sat, 11 Mar 2023 20:22:17 +0100 (CET) From: Gerald Pfeifer To: =?ISO-8859-2?Q?Arsen_Arsenovi=E6?= cc: Sandra Loosemore , gcc-patches@gcc.gnu.org, Joseph Myers Subject: Re: [PATCH v2 1/5] docs: Create Indices appendix In-Reply-To: <86356b1nnh.fsf@aarsen.me> Message-ID: <4d6acae7-f275-74a8-a960-67c8a1deb482@pfeifer.com> References: <20230223102714.3606058-1-arsen@aarsen.me> <20230223102714.3606058-2-arsen@aarsen.me> <9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com> <86sfed63l6.fsf@aarsen.me> <1db33a21-4645-1c63-faf2-4048be07c323@siemens.com> <86356b1nnh.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323328-1980145826-1678561964=:6336" X-Scanned-By: mailmunge 3.11 on 209.68.5.143 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1980145826-1678561964=:6336 Content-Type: text/plain; CHARSET=ISO-8859-2 Content-Transfer-Encoding: 8BIT On Sat, 11 Mar 2023, Arsen Arsenoviæ wrote: > OK, changed up a bit, what do you think of this: > maintainer-scripts/ChangeLog: > > * update_web_docs_git: Set CONTENTS_OUTPUT_LOCATION=inline in > order to put @shortcontents above contents. See > 9dd976a4-4e09-d901-b949-6d5037567b9b@codesourcery.com on > gcc-patches. In the ChangeLog we only describe *what* has change, so the first half of the first sentence. The rest then goes in between the first line of the Git commit message (= the subject of your mail) and the ChangeLog entries. > --- a/gcc/configure > +++ b/gcc/configure We usually don't post diffs for generated files. Not a biggie, I figured I mention it since it makes reviewing easier and patches shorter, and thus tends to increase the chance reviewers short on time jump in. :-) > --- a/maintainer-scripts/update_web_docs_git > +++ b/maintainer-scripts/update_web_docs_git > @@ -169,7 +169,7 @@ for file in $MANUALS; do > if [ "$file" = "gnat_ugn" ]; then > includes="$includes -I gcc/gcc/ada -I gcc/gcc/ada/doc/gnat_ugn" > fi > - makeinfo --html --css-ref $CSS $includes -o ${file} ${filename} > + makeinfo --html -c CONTENTS_OUTPUT_LOCATION=inline --css-ref $CSS $includes -o ${file} ${filename} Sandra deferred to me on this one, so explicitly: Ack, thank you. :-) Note, update_web_docs_git runs once a day, at 0:50 GMT, see gcc/maintainer-scripts/crontab, and needs to be updated on the gcc.gnu.org system. I am happy to do that for you, just drop me a note when the commit is in. Gerald --8323328-1980145826-1678561964=:6336--