public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kewen Lin <linkw@linux.ibm.com>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH 04/15] s390: Fix non-robust split condition in define_insn_and_split
Date: Thu, 11 Nov 2021 05:24:48 -0600	[thread overview]
Message-ID: <4d76a4e4bf40d393aabf0206ea5cd7d84860bb81.1636621345.git.linkw@linux.ibm.com> (raw)
In-Reply-To: <cover.1636621345.git.linkw@linux.ibm.com>

This patch is to fix some non-robust split conditions in some
define_insn_and_splits, to make each of them applied on top of
the corresponding condition for define_insn part, otherwise the
splitting could perform unexpectedly.

gcc/ChangeLog:

	* config/s390/s390.md (*cstorecc<mode>_z13): Fix split condition.
	* config/s390/vector.md (fprx2_to_tf, tf_to_fprx2): Likewise.
---
 gcc/config/s390/s390.md   | 2 +-
 gcc/config/s390/vector.md | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/config/s390/s390.md b/gcc/config/s390/s390.md
index 4debdcd1247..1d66c30b9d5 100644
--- a/gcc/config/s390/s390.md
+++ b/gcc/config/s390/s390.md
@@ -6941,7 +6941,7 @@ (define_insn_and_split "*cstorecc<mode>_z13"
 			     (match_operand 3 "const_int_operand"  "")]))]
   "TARGET_Z13"
   "#"
-  "reload_completed"
+  "&& reload_completed"
   [(set (match_dup 0) (const_int 0))
    (set (match_dup 0)
 	(if_then_else:GPR
diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md
index 1ed1d0665d4..8aa4e82c28d 100644
--- a/gcc/config/s390/vector.md
+++ b/gcc/config/s390/vector.md
@@ -641,7 +641,7 @@ (define_insn_and_split "fprx2_to_tf"
   "@
    vmrhg\t%v0,%1,%N1
    #"
-  "!(MEM_P (operands[0]) && MEM_VOLATILE_P (operands[0]))"
+  "&& !(MEM_P (operands[0]) && MEM_VOLATILE_P (operands[0]))"
   [(set (match_dup 2) (match_dup 3))
    (set (match_dup 4) (match_dup 5))]
 {
@@ -916,7 +916,7 @@ (define_insn_and_split "tf_to_fprx2"
 	(subreg:FPRX2 (match_operand:TF 1 "general_operand"       "v,AR") 0))]
   "TARGET_VXE"
   "#"
-  "!(MEM_P (operands[1]) && MEM_VOLATILE_P (operands[1]))"
+  "&& !(MEM_P (operands[1]) && MEM_VOLATILE_P (operands[1]))"
   [(set (match_dup 2) (match_dup 3))
    (set (match_dup 4) (match_dup 5))]
 {
-- 
2.27.0


  parent reply	other threads:[~2021-11-11 11:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 11:24 [PATCH 00/15] " Kewen Lin
2021-11-11 11:24 ` [PATCH 01/15] frv: " Kewen Lin
2021-11-11 11:24 ` [PATCH 02/15] m32c: " Kewen Lin
2021-11-11 11:24 ` [PATCH 03/15] rx: " Kewen Lin
2021-11-11 11:24 ` Kewen Lin [this message]
2021-11-11 11:24 ` [PATCH 05/15] v850: " Kewen Lin
2021-11-11 11:24 ` [PATCH 06/15] visium: " Kewen Lin
2021-11-16 16:57   ` Eric Botcazou
2021-11-17  6:06     ` Kewen.Lin
2021-11-11 11:24 ` [PATCH 07/15] xtensa: " Kewen Lin
2021-11-19 22:26   ` augustine.sterling
2021-11-22  2:21     ` Kewen.Lin
2021-11-11 11:24 ` [PATCH 08/15] alpha: " Kewen Lin
2021-11-11 11:24 ` [PATCH 09/15] arm: " Kewen Lin
2021-11-11 11:24 ` [PATCH 10/15] bfin: " Kewen Lin
2021-11-11 11:24 ` [PATCH 11/15] csky: " Kewen Lin
2021-11-11 11:24 ` [PATCH 12/15] i386: " Kewen Lin
2021-11-17  7:13   ` Uros Bizjak
2021-11-17 10:06     ` Kewen.Lin
2021-11-11 11:24 ` [PATCH 13/15] ia64: " Kewen Lin
2021-11-11 11:24 ` [PATCH 14/15] mips: " Kewen Lin
2021-11-11 11:24 ` [PATCH 15/15] sh: " Kewen Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d76a4e4bf40d393aabf0206ea5cd7d84860bb81.1636621345.git.linkw@linux.ibm.com \
    --to=linkw@linux.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).