From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by sourceware.org (Postfix) with ESMTPS id 31571385382B for ; Wed, 17 May 2023 21:33:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 31571385382B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=catmur.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=catmur.uk Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 40A7F5C00E1 for ; Wed, 17 May 2023 17:33:08 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute5.internal (MEProxy); Wed, 17 May 2023 17:33:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catmur.uk; h=cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1684359188; x=1684445588; bh=cp fo40MwP7tMiUbC1JB9u0GzAQnqzOHfXtDogB+Af+w=; b=upZ9W7K3wVPqGlwHsR m97Tt7pdLdwt/pKHtfrld/+eVk30ZQPtKoaoMca+qrD6CX5zCcDM8LYsQ6lh5ZCp QKzf7q7RyATJIJqhzwWlXaQKJl8l6vGS25mgFD2+bezethbYeHHRcA6LhrlVrGaI 6LwXXqArC6NdXQ0iypLI2Q3HNfcb0TmYAK9U6h7N350lq/i5+npb+x0u9RztRbSw zEtqCIltxincIMZoQlJHa/j2KJ+9cd9SJbvB3yb59ItHCeeUwypo/yKVXyFEz0xH aE2yHqLQxOcUZC/8yrIz0z2eM4hWxxfTRmmbMWqmWzCYyo5wEBMoQiW7wBJU6R24 TlHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1684359188; x=1684445588; bh=cpfo40MwP7tMi UbC1JB9u0GzAQnqzOHfXtDogB+Af+w=; b=M8iBgp78XTMRvzGD/cojvUza7QaOc Qoet+bUW1/9JmsplUrMrkT6JM+deH1W74hGxEPiz/ubpzEGjChyp+JtDmscyps2A fa56GDO0EvlIQHmyrB7bsPx+fE3/MCPJ13l8Xims1ZhES2EGy6UILiSOpIol28GQ bDfo5qERdpypYNTiP6nB6I4A6KJP9KCkoeWpz7LOHDf8kK1ZETHX2DTqlAoiIrnA M3mgoa4YKt0tz0lKXYF4SvbjN30UaH9/IQRzs/CQHufTFG9qlei/e4bh9D3fdLC3 CGWljRNqJBA9kC3sc+XEqaFf4RoXo0P3dxH1lqRXb/aNBdp14GluwpOYg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeiuddgudeivdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgesth dtredtreertdenucfhrhhomhepfdfgugcuvegrthhmuhhrfdcuoegvugestggrthhmuhhr rdhukheqnecuggftrfgrthhtvghrnhepvdfgueefjeevtedthfehveejtdeuvdekheevue ejffffvedulefhffekleegfeegnecuffhomhgrihhnpegufigrrhhfshhtugdrohhrghdp ghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegvugestggrthhmuhhrrdhukh X-ME-Proxy: Feedback-ID: i5729427b:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id D69DA31A0064; Wed, 17 May 2023 17:33:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-431-g1d6a3ebb56-fm-20230511.001-g1d6a3ebb Mime-Version: 1.0 Message-Id: <4d962686-1fc9-4903-bea0-971493077bfb@app.fastmail.com> In-Reply-To: <20230204165033.4026-1-ed@catmur.uk> References: <20230204165033.4026-1-ed@catmur.uk> Date: Wed, 17 May 2023 16:32:47 -0500 From: "Ed Catmur" To: "Srinath Parvathaneni" Subject: Re: [PATCH v3] emit DW_AT_name for DW_TAG_GNU_formal_parameter_pack [PR70536] Content-Type: text/plain X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. On Sat, 4 Feb 2023, at 10:50, Ed Catmur wrote: > Per > http://wiki.dwarfstd.org/index.php?title=C%2B%2B0x:_Variadic_templates > DW_TAG_GNU_formal_parameter_pack should have a DW_AT_name: > > 17$: DW_TAG_formal_parameter_pack > DW_AT_name("args") > 18$: DW_TAG_formal_parameter > ! no DW_AT_name attribute > DW_AT_type(reference to 13$) > (...) > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70536 > --- > gcc/dwarf2out.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc > index 1f39df3b1e2..462328acd9f 100644 > --- a/gcc/dwarf2out.cc > +++ b/gcc/dwarf2out.cc > @@ -23041,7 +23041,7 @@ gen_formal_parameter_pack_die (tree parm_pack, > && subr_die); > > parm_pack_die = new_die (DW_TAG_GNU_formal_parameter_pack, subr_die, > parm_pack); > - add_src_coords_attributes (parm_pack_die, parm_pack); > + add_name_and_src_coords_attributes (parm_pack_die, parm_pack); > > for (arg = pack_arg; arg; arg = DECL_CHAIN (arg)) > { > -- > 2.34.1