From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 1FF2B3858296 for ; Thu, 1 Feb 2024 01:41:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FF2B3858296 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1FF2B3858296 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706751705; cv=none; b=iqMixRL2/0ffrbjdlo4OJgnxdJOSBJ7pj9nBzRJSbAHxr+tNypzINWOXTWOWEOnyo0cLhEZ2GvlelcHsQbyOtHAvv7ocZV1lVND6zxVcn4lCnblY6WP6++CDfA1hwsH/d9vpChvWg4pEiP4qSaFZzkkIMK64/blpF9rxd+678J8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706751705; c=relaxed/simple; bh=PV66CgArhCh1cwrVB8W7+S4/vuE1eC6loN2vhqU+FTA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=f/D2h6X7jzuon3AJoZQJ90oRiKrNAVBRsDX8mDCWv+jaMRib/t0/hZpHJoo/PbwgzxmhKn2iwwNN4K85ITVBb/qakxIevieznQgpXyOIF0ezKrJJNDUfV+aLcYxZThh++93jvo+fdDWFHYPFDbJp8en6SLa4xSHCoWkcDVA3+j0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6ddc2a78829so262830b3a.3 for ; Wed, 31 Jan 2024 17:41:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706751703; x=1707356503; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J60K/MDnxqrz31iRUJg86p17S06f2SI8YMZIJuF6/Ao=; b=DinDH4xajw8N8lfZbKY39tUa2K4PwhCoNy3okdZZqkOeI5wJebywOaOjGi8GWlWhWE MjsIInERW0MgrkOxUfJIba6eaSjc5Xq4vr04HNEGfw9jWE2vLu85RNeXo38j13wdUczY JQ2izuSQIGZq4nbtw/dob2FNFkYdcn+K7XbhqTnKU5SfVSN+zyS+PkaV0YCeJKWXDiG1 USyv5AT/Fpjn2gi0HtQDhXfZ0/2wT6psdqSw9TZCb2GJTSBKvGCOGRhPyBIkSBUrmhd8 SEjqXiuKShAmjt/rXcGGrV/XqNhQCUwyBC0EIpmANgzNyz96XXGDR5tYsDUncR8v0Dww yGEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706751703; x=1707356503; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J60K/MDnxqrz31iRUJg86p17S06f2SI8YMZIJuF6/Ao=; b=Mwx0dDYX/VJwWnqz8GCyk7FUWMSmRm/uwPPcvANNHneHr4ybjfcmHO19HYSNJ3gRl0 K86YraVCA1+SF/ICA0NujQcSg5xg1HZlH+yOIwer/LMJkG5UjbRz3Z4MltxNKKt8YVec 4Ga7N8kmVdrfPgyclhkFlpf5sLyS881Sv2VMeheoP+yRCJEk2EcfiGboBr/kdZCjjGnC FxOO/fGADcR//bQOFJ2llDcY8GziBmCoVvBt6KWleBCA7otQpTcTaHCjl397zG5alfBC nQJ/UkCkz6oxWM3C1uHR4X/SLifeogJbGfCPkECreC1rB/Ez7m2/fUnnQp0UBFofrPi3 oepg== X-Gm-Message-State: AOJu0YxY/1fCsBj9SDXH0mOpw5+pxuHpO84lZEGVQRfA9v6cown5RmCK TqRgiPzyirG/UiipDCF70VwTU1f/mJ6tTe4Jzq6H8rQFQtKIupt09gh0Cpg7yCSvgVEX8cY3Nox x X-Google-Smtp-Source: AGHT+IGeo/tfXrz2Tyf109apPQ5qxk7lYJQnT5tSaGeMNlEAXzK6XLYi9vqubS9Rgq7LFbYxT7m/vA== X-Received: by 2002:a05:6a00:2e98:b0:6de:1d4a:c22c with SMTP id fd24-20020a056a002e9800b006de1d4ac22cmr4236760pfb.0.1706751703079; Wed, 31 Jan 2024 17:41:43 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUvGTtUYciZC3JAXYXPbrNJPOWOCIT53lvEFFMVy4L3F7O+nQLU+KqZD2T8Htx5i3puJLVxvTO+ZMM4rleqHcq5gmhoorLBOQ== Received: from [10.0.17.83] ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id p23-20020a056a000a1700b006da1d9f4adcsm10550470pfh.127.2024.01.31.17.41.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jan 2024 17:41:42 -0800 (PST) Message-ID: <4df01fb3-6b59-4eed-aae9-e21d1dc64389@rivosinc.com> Date: Wed, 31 Jan 2024 17:41:43 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [COMMITTED V3 3/4] RISC-V: Use default cost model for insn scheduling Content-Language: en-US To: Robin Dapp , gcc-patches@gcc.gnu.org Newsgroups: gmane.comp.gcc.patches References: <20240112180844.2005246-1-ewlu@rivosinc.com> <20240112180844.2005246-4-ewlu@rivosinc.com> <12d205cd-3177-48ea-a54e-c2052fddec2e@gmail.com> From: Edwin Lu In-Reply-To: <12d205cd-3177-48ea-a54e-c2052fddec2e@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/25/2024 9:06 AM, Robin Dapp wrote: >> Use default cost model scheduling on these test cases. All these tests >> introduce scan dump failures with -mtune generic-ooo. Since the vector >> cost models are the same across all three tunes, some of the tests >> in PR113249 will be fixed with this patch series. > > This is OK, thanks. > >> 39 additional unique testsuite failures (scan dumps) will still be present. >> I don't know how optimal the new output is compared to the old. Should I update >> the testcase expected output to match the new scan dumps? > > Currently, without vector op latency, the output should come close > to what's normally considered "good" (i.e. minimal number of vsetvls > and so on). Therefore I'd suggest not to change the scan dumps to > much except when there is a real problem. If you have a specific > example that you're unsure about we can discuss this on or off list. > > Regards > Robin > > Committed! Edwin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ciao.gmane.io (ciao.gmane.io [116.202.254.214]) by sourceware.org (Postfix) with ESMTPS id D578A3858D37 for ; Thu, 1 Feb 2024 01:50:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D578A3858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=m.gmane-mx.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D578A3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=116.202.254.214 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706752206; cv=none; b=V9lBxHPKsru80RTeSVQyjNhrAgA7A1ndXOkwM3YMH4V7wbXMhBYQEGPV3bA/LKmAqzWS1TuPz+myzHytSUtqqV5TRbxRFC/V4ANlU2v5GcyWqTC8812RPGg32fF4oRHHDqzQyekeQJ42AsILux2DrZI5Tkf+eVQaiSZ0f/xirI0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706752206; c=relaxed/simple; bh=PV66CgArhCh1cwrVB8W7+S4/vuE1eC6loN2vhqU+FTA=; h=To:From:Subject:Date:Message-ID:Mime-Version; b=sDz35IoBASaMA2+KJ2FYmgom9W0ZjwCco9HMLEzTFm8IWMUCY70a/7Y2mD1uqHdybcCBh93r+eSVy/EiTNxnKeNPbfAZy4PVmqLMcEsKwpcSdmJq5B2fsAunLR/Wo7CZ4U1qDaiY4v6PInnUOyXoBTHuGfSsSs3B9fRLdZWfy+U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rVMDK-0009K5-FB for gcc-patches@gcc.gnu.org; Thu, 01 Feb 2024 02:50:02 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: gcc-patches@gcc.gnu.org From: Edwin Lu Subject: Re: [COMMITTED V3 3/4] RISC-V: Use default cost model for insn scheduling Date: Wed, 31 Jan 2024 17:41:43 -0800 Message-ID: <4df01fb3-6b59-4eed-aae9-e21d1dc64389@rivosinc.com> References: <20240112180844.2005246-1-ewlu@rivosinc.com> <20240112180844.2005246-4-ewlu@rivosinc.com> <12d205cd-3177-48ea-a54e-c2052fddec2e@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit User-Agent: Mozilla Thunderbird Content-Language: en-US In-Reply-To: <12d205cd-3177-48ea-a54e-c2052fddec2e@gmail.com> X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20240201014143.MKs3hq6LtOhOspzLIRuY44ksZ0ljV9A07lcnZLYqzAg@z> On 1/25/2024 9:06 AM, Robin Dapp wrote: >> Use default cost model scheduling on these test cases. All these tests >> introduce scan dump failures with -mtune generic-ooo. Since the vector >> cost models are the same across all three tunes, some of the tests >> in PR113249 will be fixed with this patch series. > > This is OK, thanks. > >> 39 additional unique testsuite failures (scan dumps) will still be present. >> I don't know how optimal the new output is compared to the old. Should I update >> the testcase expected output to match the new scan dumps? > > Currently, without vector op latency, the output should come close > to what's normally considered "good" (i.e. minimal number of vsetvls > and so on). Therefore I'd suggest not to change the scan dumps to > much except when there is a real problem. If you have a specific > example that you're unsure about we can discuss this on or off list. > > Regards > Robin > > Committed! Edwin