From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 215C83858419 for ; Tue, 16 Aug 2022 08:55:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 215C83858419 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A68091FA75 for ; Tue, 16 Aug 2022 08:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1660640141; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WRL1vV1+Eug/woe2Y92h7TYx2blCla60cZlSC3CVWUk=; b=uBwuvFq24kzhnc74aQC6pczo5ltoqRt1x91SMqANvt/wy0wBgwgA4wVJoAPg0HbKA23Imv 25M9pwRagSfHZyLBnQlowrwOymECVIg4+c/fxIG83bFwzhd5Fa8vmyzM4MbhwN/xorScvx ShTOdOFFVT5ZyrFPuYh2rIdeCqqF9a8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1660640141; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WRL1vV1+Eug/woe2Y92h7TYx2blCla60cZlSC3CVWUk=; b=HfPqeUaI71UFrP3RmbPizKsMrEKjgFpFPwEMJZX4oq572FG7E55psGmtDfZqIdGmLtOeLp u1t0N7O4KgQFQxDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 97CA7139B7 for ; Tue, 16 Aug 2022 08:55:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TEQJJI1b+2I5agAAMHmgww (envelope-from ) for ; Tue, 16 Aug 2022 08:55:41 +0000 Message-ID: <4df5e9cd-a876-7500-426f-72d9c9b79f1c@suse.cz> Date: Tue, 16 Aug 2022 10:55:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Subject: [PATCH][pushed] i386: add 'final' and 'override' to scalar_chain To: gcc-patches@gcc.gnu.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2022 08:55:45 -0000 In c3ed9e0d6e96d8697e4bab994f8acbc5506240ee, David added some "final override" and since that there are 2 new warnings that need the same treatment: gcc/config/i386/i386-features.h:186:8: warning: 'convert_op' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/config/i386/i386-features.h:186:8: warning: 'convert_op' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/config/i386/i386-features.h:199:8: warning: 'convert_op' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/config/i386/i386-features.h:199:8: warning: 'convert_op' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/ChangeLog: * config/i386/i386-features.h (class general_scalar_chain): Add final override for a method. (class timode_scalar_chain): Likewise. --- gcc/config/i386/i386-features.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/i386/i386-features.h b/gcc/config/i386/i386-features.h index 3d88a88e014..f898e67a108 100644 --- a/gcc/config/i386/i386-features.h +++ b/gcc/config/i386/i386-features.h @@ -183,7 +183,7 @@ class general_scalar_chain : public scalar_chain private: void convert_insn (rtx_insn *insn) final override; - void convert_op (rtx *op, rtx_insn *insn); + void convert_op (rtx *op, rtx_insn *insn) final override; int vector_const_cost (rtx exp); }; @@ -196,7 +196,7 @@ class timode_scalar_chain : public scalar_chain private: void fix_debug_reg_uses (rtx reg); void convert_insn (rtx_insn *insn) final override; - void convert_op (rtx *op, rtx_insn *insn); + void convert_op (rtx *op, rtx_insn *insn) final override; }; } // anon namespace -- 2.37.1