public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Xi Ruoyao <xry111@mengyan1223.wang>
To: gcc-patches@gcc.gnu.org
Cc: Xi Ruoyao <xry111@mengyan1223.wang>
Subject: [PATCH] MIPS: Fix PR target/98491
Date: Fri, 01 Jan 2021 07:29:05 +0800	[thread overview]
Message-ID: <4df733093ede4a3cc5dcb2688dcc9a2e5be4b721.camel@mengyan1223.wang> (raw)

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

An invalid use of MSA_SUPPORTED_MODE_P is causing ICE on mips64el with -mmsa.
The detailed analysis is posted on bugzilla:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98491

The attached patch fixes this issue by handling the special case of
MSA_SUPPORTED_MODE_P explicitly.

Please keep me in CC since I'm not a subscriber.

And, I don't have GIT write access.
-- 
Xi Ruoyao <xry111@mengyan1223.wang>
School of Aerospace Science and Technology, Xidian University

[-- Attachment #2: 0001-MIPS-Fix-PR-target-98491.patch --]
[-- Type: text/x-patch, Size: 526 bytes --]

diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
index 58e474e063d..8f80dcfada8 100644
--- a/gcc/config/mips/mips.c
+++ b/gcc/config/mips/mips.c
@@ -2381,7 +2381,7 @@ mips_symbol_insns (enum mips_symbol_type type, machine_mode mode)
 {
   /* MSA LD.* and ST.* cannot support loading symbols via an immediate
      operand.  */
-  if (MSA_SUPPORTED_MODE_P (mode))
+  if (mode != MAX_MACHINE_MODE && MSA_SUPPORTED_MODE_P (mode))
     return 0;
 
   return mips_symbol_insns_1 (type, mode) * (TARGET_MIPS16 ? 2 : 1);

             reply	other threads:[~2020-12-31 23:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-31 23:29 Xi Ruoyao [this message]
2020-12-31 23:34 ` [PATCH] MIPS: Fix PR target/98491 (ChangeLog) Xi Ruoyao
2021-01-04 20:51   ` Jeff Law
2021-01-04 21:00     ` Jakub Jelinek
2021-01-04 21:19       ` Jeff Law
2021-01-10 17:01         ` Xi Ruoyao
2021-01-10 17:04           ` Xi Ruoyao
2021-02-12 14:17           ` Xi Ruoyao
2021-02-12 14:54             ` Xi Ruoyao
2021-02-12 14:57               ` Xi Ruoyao
2021-02-12 15:15                 ` Xi Ruoyao
2021-02-15 23:16             ` Jeff Law
2021-02-16  3:59               ` Xi Ruoyao
2021-02-17 11:13                 ` Xi Ruoyao
2021-02-17 12:02                   ` Richard Sandiford
2021-03-02 23:16                     ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4df733093ede4a3cc5dcb2688dcc9a2e5be4b721.camel@mengyan1223.wang \
    --to=xry111@mengyan1223.wang \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).