From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-519101-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 129337 invoked by alias); 7 Feb 2020 01:34:19 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 129327 invoked by uid 89); 7 Feb 2020 01:34:18 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=
X-HELO: esa4.mentor.iphmx.com
Received: from esa4.mentor.iphmx.com (HELO esa4.mentor.iphmx.com) (68.232.137.252) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Feb 2020 01:34:17 +0000
IronPort-SDR: GQAvUSrfSvJwBvkU4KTn5pFHSxRBaBWxRHT1pq0VQzuAnvjp4lssvN/5pnNN0Wi+GPhmeZqVh+ ouXWY52gWgLn0uv8EDcocxXnL0E2pJsWxjrPq2jr5yCDkm9q6PqMJz8/jQzhpJBZjgjPS2jS+e MD5cmL3L+DwEnQq1zNV/Cj88uCll5hoti0wMv5GxMeTDLHYz4lN/FKIjPYf/Oh1HcpFDc1yT4Q Dd7rFSSejRvrc/3A4EGWVRTNMSWN4MCFi98s1juqdRkenr8y3MrGkKJ+pKR7j7XYfOmAVGfiiF K3c=
Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167])  by esa4.mentor.iphmx.com with ESMTP; 06 Feb 2020 17:34:15 -0800
IronPort-SDR: jWA/UK55qCjGvksZdu5AoxC69QFEiLMYpuKT18zL1xTnaPybHru/b30JZxnZH00J1wlt1SlJ8Y RXieRWHYy5yfPHNk434f3tQ9PrTTUjTBPpRhiNCiDFk+DtRt9GEwVu8Vz4mBg9/Itm7qLyX3t8 XJScAlSS93U3H9SlBnRa5KeqYRDqh7ql84e6P7wQbYgGWq0pn2lH7m3voMIxBO5y8LHFF1Rt5w W3MMYLoYfMlJZcZyHqJpQYWaK2oo7qmyH3fxX3IR3byowb0Spzmlhi9564WsWD+Jxbc9Qjaymn P+U=
Subject: Re: [wwwdocs] Mention common attribute in gcc-10/porting_to.html
To: Gerald Pfeifer <gerald@pfeifer.com>, Jakub Jelinek <jakub@redhat.com>
CC: Wilco Dijkstra <Wilco.Dijkstra@arm.com>, Jonathan Wakely	<jwakely@redhat.com>, <gcc-patches@gcc.gnu.org>, Joseph Myers	<joseph@codesourcery.com>
References: <VI1PR0801MB2127C945195E03DBD309D8DB835C0@VI1PR0801MB2127.eurprd08.prod.outlook.com> <20200106141002.GA586949@redhat.com> <3d0548fd-b5ab-d04a-4efc-cb221b6a4b1d@codesourcery.com> <AM5PR0801MB2035090868D382FB72A2B028833F0@AM5PR0801MB2035.eurprd08.prod.outlook.com> <20200206200724.GP17695@tucnak> <alpine.LSU.2.21.2002062315060.4936@anthias.pfeifer.com>
From: Sandra Loosemore <sandra@codesourcery.com>
Message-ID: <4e27f671-1848-56ab-9f5e-807f37169632@codesourcery.com>
Date: Fri, 07 Feb 2020 01:34:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <alpine.LSU.2.21.2002062315060.4936@anthias.pfeifer.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Return-Path: sandra@codesourcery.com
X-SW-Source: 2020-02/txt/msg00411.txt.bz2

On 2/6/20 3:18 PM, Gerald Pfeifer wrote:
> On Thu, 6 Feb 2020, Jakub Jelinek wrote:
>> +  If tentative definitions of particular variable or variables need to be
> 
> I believe that would be "a particular variable", but best to simplify
> to "of particular variables".
> 
>> +  placed in a common block, <code>__attribute__((__common__))</code> can be
>> +  used to force that behavior for those even in code compiled without
>> +  <code>-fcommon</code>.
> 
> Here I'd omit "for those".
> 
> This makes sense to me and reads well; okay from my side. :)

Looks good to me with those changes.

-Sandra