From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 100472 invoked by alias); 23 May 2018 22:50:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 100460 invoked by uid 89); 23 May 2018 22:50:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:sk:71-v6mr X-HELO: mail-yb0-f196.google.com Received: from mail-yb0-f196.google.com (HELO mail-yb0-f196.google.com) (209.85.213.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 May 2018 22:50:55 +0000 Received: by mail-yb0-f196.google.com with SMTP id s8-v6so6997514ybp.11 for ; Wed, 23 May 2018 15:50:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A9VnsfjfHFSVBvy5RPm/JPaarwjQanr8DlFb3SJdYYY=; b=Oud+1BlFjcfcH/2ClF0kp3IbKRP15CdNPKQcxHRxLYApWUsoh+xQGtvEzjPKe1i0BU LQN52PROt51pmNwN1/ZKVOuUY4lm75yik3LZmlNueA989LqTEkG/MBCGc6khHNL7Rviu XlbcGV5qDp1MFUOw+A7kNSAjdH4ytFkWZ5k8JZ2XY/FqJ4YQHKQGbVpi0/5E6p7zM0vX NQRC+JA/49bNV0J1/QEj62YY2QjuQMD02UIAOWz+iYR1eLIAYkhmziZyk1IC/Nd5OnHl hD5aa4zYkUaVkRLCugwRywsUBxIdUeQUGfXvtIUkSR0bXaa558+4V8OpH7oe6dxYGhEh RP0w== X-Gm-Message-State: ALKqPwest6BSqujrFhOaR1pdES/Xvf3cvIYmE5TL6IJCaW9XUfFrScNc ngYC+HtuiTA1JEzqUEdMHzXdyA== X-Google-Smtp-Source: AB8JxZobXGpioJFJGabsRT6QJAAgafmXNw9hNmMasq63udMOZR8x0ux/zHpBJA39aJ68kdgpWNmdrA== X-Received: by 2002:a25:44a:: with SMTP id 71-v6mr2867432ybe.463.1527115853250; Wed, 23 May 2018 15:50:53 -0700 (PDT) Received: from [192.168.1.15] (c-69-243-238-236.hsd1.al.comcast.net. [69.243.238.236]) by smtp.gmail.com with ESMTPSA id n197-v6sm287154ywd.73.2018.05.23.15.50.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 May 2018 15:50:52 -0700 (PDT) Subject: Re: [PATCH 1/2] Introduce prefetch-minimum stride option To: "H.J. Lu" Cc: Kyrill Tkachov , GCC Patches , James Greenhalgh , Richard Earnshaw , Jeff Law References: <1516628770-25036-1-git-send-email-luis.machado@linaro.org> <1516628770-25036-2-git-send-email-luis.machado@linaro.org> <468c1099-3a87-6e95-53c4-3ba62fe3472f@linaro.org> <5AFAAA57.2080501@foss.arm.com> <3b4ec84e-5902-f7de-f047-282c3b3fff08@linaro.org> <5AFBF522.5040805@foss.arm.com> <41528915-fb50-7c59-f476-f5c085621bc8@linaro.org> <12caffd9-81c4-1a29-429a-6fd712db08d8@linaro.org> <7ea9a127-1ae6-9fa6-6cd4-06818a3d7b8b@linaro.org> From: Luis Machado Message-ID: <4e2b74ae-2c37-1bff-94ed-3a78486f2131@linaro.org> Date: Wed, 23 May 2018 23:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg01313.txt.bz2 On 05/23/2018 07:42 PM, H.J. Lu wrote: > On Wed, May 23, 2018 at 3:41 PM, H.J. Lu wrote: >> On Wed, May 23, 2018 at 3:35 PM, H.J. Lu wrote: >> >>>> >>>> Sorry. Does the following fix it for i686? >>>> >>> >>> Index: gcc/tree-ssa-loop-prefetch.c >>> =================================================================== >>> --- gcc/tree-ssa-loop-prefetch.c (revision 260625) >>> +++ gcc/tree-ssa-loop-prefetch.c (working copy) >>> @@ -1014,7 +1014,8 @@ >>> fprintf (dump_file, >>> "Step for reference %u:%u (%ld) is less than the mininum " >>> ^^^ Please use >>> HOST_WIDE_INT_PRINT_DEC >>> "required stride of %d\n", >>> - ref->group->uid, ref->uid, int_cst_value (ref->group->step), >>> + ref->group->uid, ref->uid, >>> + (HOST_WIDE_INT) int_cst_value (ref->group->step), >>> PREFETCH_MINIMUM_STRIDE); >>> >>> >> >> Something like this. >> >> -- >> H.J. >> --- >> diff --git a/gcc/tree-ssa-loop-prefetch.c b/gcc/tree-ssa-loop-prefetch.c >> index c3e7fd1e529..949a67f360e 100644 >> --- a/gcc/tree-ssa-loop-prefetch.c >> +++ b/gcc/tree-ssa-loop-prefetch.c >> @@ -1012,8 +1012,8 @@ should_issue_prefetch_p (struct mem_ref *ref) >> { >> if (dump_file && (dump_flags & TDF_DETAILS)) >> fprintf (dump_file, >> - "Step for reference %u:%u (%ld) is less than the mininum " >> - "required stride of %d\n", >> + "Step for reference %u:%u (" HOST_WIDE_INT_PRINT_C >> + ") is less than the mininum required stride of %d\n", >> ref->group->uid, ref->uid, int_cst_value (ref->group->step), >> PREFETCH_MINIMUM_STRIDE); >> return false; > > I meant: > > diff --git a/gcc/tree-ssa-loop-prefetch.c b/gcc/tree-ssa-loop-prefetch.c > index c3e7fd1e529..e34b78dc186 100644 > --- a/gcc/tree-ssa-loop-prefetch.c > +++ b/gcc/tree-ssa-loop-prefetch.c > @@ -1012,8 +1012,8 @@ should_issue_prefetch_p (struct mem_ref *ref) > { > if (dump_file && (dump_flags & TDF_DETAILS)) > fprintf (dump_file, > - "Step for reference %u:%u (%ld) is less than the mininum " > - "required stride of %d\n", > + "Step for reference %u:%u (" HOST_WIDE_INT_PRINT_DEC > + ") is less than the mininum required stride of %d\n", > ref->group->uid, ref->uid, int_cst_value (ref->group->step), > PREFETCH_MINIMUM_STRIDE); > return false; > > Pushed now. Sorry for the breakage. For future reference, is there an i686 system on the gcc farm that i can use to validate this? Thanks, Luis