* [PATCH][expmed.c] PR middle-end/77426 Delete duplicate condition in synth_mult
@ 2016-09-07 13:07 Kyrill Tkachov
2016-09-08 15:56 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: Kyrill Tkachov @ 2016-09-07 13:07 UTC (permalink / raw)
To: GCC Patches
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
Hi all,
The duplicate mode check in synth can just be deleted IMO. It was introduced as part of r139821 that was
a much larger change introducing size/speed differentiation to the RTL midend. So I think it's just a typo/copy-pasto.
Tested on aarch64-none-elf.
Ok?
Thanks,
Kyrill
2016-09-07 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
PR middle-end/77426
* expmed.c (synth_mult): Delete duplicate mode check.
[-- Attachment #2: expmed-mode.patch --]
[-- Type: text/x-patch, Size: 487 bytes --]
diff --git a/gcc/expmed.c b/gcc/expmed.c
index 1cedf023c8e8916d887bd3a9d9a723e3cc2354f7..a5da8836f21debcda3b834cb869348ea6cb33414 100644
--- a/gcc/expmed.c
+++ b/gcc/expmed.c
@@ -2572,7 +2572,6 @@ synth_mult (struct algorithm *alg_out, unsigned HOST_WIDE_INT t,
entry_ptr = alg_hash_entry_ptr (hash_index);
if (entry_ptr->t == t
&& entry_ptr->mode == mode
- && entry_ptr->mode == mode
&& entry_ptr->speed == speed
&& entry_ptr->alg != alg_unknown)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][expmed.c] PR middle-end/77426 Delete duplicate condition in synth_mult
2016-09-07 13:07 [PATCH][expmed.c] PR middle-end/77426 Delete duplicate condition in synth_mult Kyrill Tkachov
@ 2016-09-08 15:56 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2016-09-08 15:56 UTC (permalink / raw)
To: Kyrill Tkachov, GCC Patches
On 09/07/2016 06:59 AM, Kyrill Tkachov wrote:
> Hi all,
>
> The duplicate mode check in synth can just be deleted IMO. It was
> introduced as part of r139821 that was
> a much larger change introducing size/speed differentiation to the RTL
> midend. So I think it's just a typo/copy-pasto.
>
> Tested on aarch64-none-elf.
> Ok?
>
> Thanks,
> Kyrill
>
> 2016-09-07 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> PR middle-end/77426
> * expmed.c (synth_mult): Delete duplicate mode check.
OK.
jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-08 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-07 13:07 [PATCH][expmed.c] PR middle-end/77426 Delete duplicate condition in synth_mult Kyrill Tkachov
2016-09-08 15:56 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).