* [PATCH] RISC-V: output Autovec params explicitly in --help ...
@ 2023-08-22 17:40 Vineet Gupta
2023-08-22 17:59 ` Jeff Law
0 siblings, 1 reply; 5+ messages in thread
From: Vineet Gupta @ 2023-08-22 17:40 UTC (permalink / raw)
To: gcc-patches, Robin Dapp, juzhe . zhong @ rivai . ai
Cc: kito.cheng, Jeff Law, Palmer Dabbelt, gnu-toolchain, Vineet Gupta
... otherwise user has no clue what -param to actually change
gcc/ChangeLog:
* config/riscv/riscv.opt: Add --param names
riscv-autovec-preference and riscv-autovec-lmul
Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
---
gcc/config/riscv/riscv.opt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/riscv.opt b/gcc/config/riscv/riscv.opt
index 6304efebfd50..a962ea8f9d41 100644
--- a/gcc/config/riscv/riscv.opt
+++ b/gcc/config/riscv/riscv.opt
@@ -277,7 +277,7 @@ Always inline subword atomic operations.
Enum
Name(riscv_autovec_preference) Type(enum riscv_autovec_preference_enum)
-The RISC-V auto-vectorization preference:
+Valid arguments to -param=riscv-autovec-preference=:
EnumValue
Enum(riscv_autovec_preference) String(none) Value(NO_AUTOVEC)
@@ -294,7 +294,7 @@ Target RejectNegative Joined Enum(riscv_autovec_preference) Var(riscv_autovec_pr
Enum
Name(riscv_autovec_lmul) Type(enum riscv_autovec_lmul_enum)
-The RVV possible LMUL:
+The RVV possible LMUL (-param=riscv-autovec-lmul=):
EnumValue
Enum(riscv_autovec_lmul) String(m1) Value(RVV_M1)
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] RISC-V: output Autovec params explicitly in --help ...
2023-08-22 17:40 [PATCH] RISC-V: output Autovec params explicitly in --help Vineet Gupta
@ 2023-08-22 17:59 ` Jeff Law
2023-08-22 18:07 ` Palmer Dabbelt
2023-08-22 18:09 ` [Committed] " Vineet Gupta
0 siblings, 2 replies; 5+ messages in thread
From: Jeff Law @ 2023-08-22 17:59 UTC (permalink / raw)
To: Vineet Gupta, gcc-patches, Robin Dapp, juzhe . zhong @ rivai . ai
Cc: kito.cheng, Palmer Dabbelt, gnu-toolchain
On 8/22/23 11:40, Vineet Gupta wrote:
> ... otherwise user has no clue what -param to actually change
>
> gcc/ChangeLog:
> * config/riscv/riscv.opt: Add --param names
> riscv-autovec-preference and riscv-autovec-lmul
OK
jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] RISC-V: output Autovec params explicitly in --help ...
2023-08-22 17:59 ` Jeff Law
@ 2023-08-22 18:07 ` Palmer Dabbelt
2023-08-22 18:11 ` Vineet Gupta
2023-08-22 18:09 ` [Committed] " Vineet Gupta
1 sibling, 1 reply; 5+ messages in thread
From: Palmer Dabbelt @ 2023-08-22 18:07 UTC (permalink / raw)
To: gcc-patches
Cc: Vineet Gupta, gcc-patches, rdapp.gcc, juzhe.zhong, Kito Cheng,
gnu-toolchain
On Tue, 22 Aug 2023 10:59:35 PDT (-0700), gcc-patches@gcc.gnu.org wrote:
>
>
> On 8/22/23 11:40, Vineet Gupta wrote:
>> ... otherwise user has no clue what -param to actually change
>>
>> gcc/ChangeLog:
>> * config/riscv/riscv.opt: Add --param names
>> riscv-autovec-preference and riscv-autovec-lmul
> OK
We should probably put them in invoke.texi as well (and anything else
we're missing that's been added recently).
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Committed] RISC-V: output Autovec params explicitly in --help ...
2023-08-22 17:59 ` Jeff Law
2023-08-22 18:07 ` Palmer Dabbelt
@ 2023-08-22 18:09 ` Vineet Gupta
1 sibling, 0 replies; 5+ messages in thread
From: Vineet Gupta @ 2023-08-22 18:09 UTC (permalink / raw)
To: gcc-patches; +Cc: Vineet Gupta
... otherwise user has no clue what -param to actually change
gcc/ChangeLog:
* config/riscv/riscv.opt: Add --param names
riscv-autovec-preference and riscv-autovec-lmul
Signed-off-by: Vineet Gupta <vineetg@rivosinc.com>
---
gcc/config/riscv/riscv.opt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/riscv.opt b/gcc/config/riscv/riscv.opt
index 6304efebfd50..a962ea8f9d41 100644
--- a/gcc/config/riscv/riscv.opt
+++ b/gcc/config/riscv/riscv.opt
@@ -277,7 +277,7 @@ Always inline subword atomic operations.
Enum
Name(riscv_autovec_preference) Type(enum riscv_autovec_preference_enum)
-The RISC-V auto-vectorization preference:
+Valid arguments to -param=riscv-autovec-preference=:
EnumValue
Enum(riscv_autovec_preference) String(none) Value(NO_AUTOVEC)
@@ -294,7 +294,7 @@ Target RejectNegative Joined Enum(riscv_autovec_preference) Var(riscv_autovec_pr
Enum
Name(riscv_autovec_lmul) Type(enum riscv_autovec_lmul_enum)
-The RVV possible LMUL:
+The RVV possible LMUL (-param=riscv-autovec-lmul=):
EnumValue
Enum(riscv_autovec_lmul) String(m1) Value(RVV_M1)
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] RISC-V: output Autovec params explicitly in --help ...
2023-08-22 18:07 ` Palmer Dabbelt
@ 2023-08-22 18:11 ` Vineet Gupta
0 siblings, 0 replies; 5+ messages in thread
From: Vineet Gupta @ 2023-08-22 18:11 UTC (permalink / raw)
To: Palmer Dabbelt, gcc-patches
Cc: rdapp.gcc, juzhe.zhong, Kito Cheng, gnu-toolchain
On 8/22/23 11:07, Palmer Dabbelt wrote:
> We should probably put them in invoke.texi as well (and anything else
> we're missing that's been added recently).
Looks like I'd pushed the patch already.
A whole bunch of them are missing, so guess that can happen seperately.
-Vineet
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-22 18:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-22 17:40 [PATCH] RISC-V: output Autovec params explicitly in --help Vineet Gupta
2023-08-22 17:59 ` Jeff Law
2023-08-22 18:07 ` Palmer Dabbelt
2023-08-22 18:11 ` Vineet Gupta
2023-08-22 18:09 ` [Committed] " Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).