From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 006103858D39 for ; Wed, 31 Aug 2022 14:13:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 006103858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27VEBerh005343; Wed, 31 Aug 2022 14:13:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=LArlQbvow/313sJ2uhYzsTNBP0nKifzckkxKbLuxdtg=; b=o72vQ8fi7qSxKPIeRvfCGPzTF0KUl/KeqUs0HbnckEJtuwjJYom4LSENcl9Z5GECZniD uQu5oeUdbnUoSt2l3Dr1in0UQJJbNxAWAJECgaR8Tdv9w71wbrcedj8IKHBWW3y+Wqeq 2fPAVmc7dm+JT9G0xjgknY4w5t8QqdmkZk8ZOrZ84p0JIRU990qWfS/Cj1/qpShrwpzf XSCUABaij9MDrPhmYoudGiOHR2IKXuZN46OcMtgXsGrYme4GfEeRPTVtgJz1psmPkBZ3 cNwAh7DB1/sX5xTEk3RZAKSlTLltGXmMO4aHCQrtwjZW0jmfNt9Ha3+7TprVCEEc+ui5 6Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ja96mr423-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Aug 2022 14:13:55 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 27VEClUl011846; Wed, 31 Aug 2022 14:13:55 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ja96mr40y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Aug 2022 14:13:55 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27VEBMDF014201; Wed, 31 Aug 2022 14:13:53 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma04wdc.us.ibm.com with ESMTP id 3j7aw9tw3a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Aug 2022 14:13:53 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27VEDqQm62259620 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Aug 2022 14:13:52 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 26907BE053; Wed, 31 Aug 2022 14:19:19 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 84E12BE04F; Wed, 31 Aug 2022 14:19:18 +0000 (GMT) Received: from [9.160.4.32] (unknown [9.160.4.32]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 31 Aug 2022 14:19:18 +0000 (GMT) Message-ID: <4e527a22-2dd6-9fa3-b255-4f71b90b77f7@linux.ibm.com> Date: Wed, 31 Aug 2022 09:13:51 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH] rs6000/test: Fix bswap64-4.c with has_arch_ppc64 [PR106680] Content-Language: en-US To: "Kewen.Lin" , GCC Patches Cc: Segher Boessenkool , David Edelsohn References: <69277846-f587-b79e-f741-a2942d326778@linux.ibm.com> From: Peter Bergner In-Reply-To: <69277846-f587-b79e-f741-a2942d326778@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: deUZ5trvu9ZJ9sy6HrsjmzU5YCo6kQ_V X-Proofpoint-ORIG-GUID: 8GxOf7UjlfXBhyscZ0OaSOFYy3d1rC-r X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-31_09,2022-08-31_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 phishscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208310071 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/31/22 4:33 AM, Kewen.Lin wrote: > @@ -1,7 +1,8 @@ > /* { dg-do compile { target { powerpc*-*-* } } } */ > /* { dg-skip-if "" { powerpc*-*-aix* } } */ > -/* { dg-options "-O2 -mpowerpc64" } */ > /* { dg-require-effective-target ilp32 } */ > +/* { dg-options "-O2 -mpowerpc64" } */ > +/* { dg-require-effective-target has_arch_ppc64 } */ With many of our recent patches moving the dg-options before any dg-requires-effectice-target so it affects the results of the dg-requires-effectice-target test, this looks like it's backwards from that process. I understand why, so I think an explicit comment here in the test case explaining why it's after in this case. Just so in a few years when we come back to this test case, we won't accidentally undo this change. The other option would be to introduce -mdejagnu-32 and -mdejagnu-64 options that operate like our -mdejagnu-cpu= options and override any -m32/-m64 option given on the command line (eg, RUNTESTFLAGS=...). To be honest, I'm not sure how I feel about this suggestion! :-) Maybe we'd only use it on the test cases like this one that we know are sensitive to be overridden??? Peter