From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: improve attribute conflict checking [PR93635]
Date: Mon, 13 May 2024 09:25:14 +0200 [thread overview]
Message-ID: <4e676dc9-c8f9-48f0-8167-039c688f53da@orange.fr> (raw)
In-Reply-To: <ae0f1517-f4b9-4988-a71b-cc0549e41e96@gmx.de>
Le 10/05/2024 à 21:56, Harald Anlauf a écrit :
> Am 10.05.24 um 21:48 schrieb Harald Anlauf:
>> Hi Mikael,
>>
>> Am 10.05.24 um 11:45 schrieb Mikael Morin:
>>> Le 09/05/2024 à 22:30, Harald Anlauf a écrit :
>>>> I'll stop here...
>>>>
>>> Thanks. Go figure, I have no problem reproducing today.
>>> It's PR99798 (and there is even a patch for it).
>>
>> this patch has rotten a bit: the type of gfc_reluease_symbol
>> has changed to bool, this can be fixed.
>>
>> Unfortunately, applying the patch does not remove the ICEs here...
>
> Oops, I take that back! There was an error on my side applying the
> patch; and now it does fix the ICEs after correcting that hickup....
>
Now the PR99798 patch is ready to be pushed, but I won't be available
for a few days. We can finish our discussion on this topic afterwards.
>>
>>>> We currently do not recover well from errors, and the prevention
>>>> of corrupted namespaces is apparently a goal we aim at.
>>>>
>>> Yes, and we are not there yet. But at least there is a sensible error
>>> message before the crash.
>>
>> True. But having a sensible error before ICEing does not improve
>> user experience either.
>>
>> Are you planning to work again on PR99798?
>>
>> Cheers,
>> Harald
>>
>>>> Cheers,
>>>> Harald
>>>>
>>>>>> The patch therefore does not require any testsuite update and
>>>>>> should not give any other surprises, so it should be very safe.
>>>>>> The plan is also to leave the PR open for the time being.
>>>>>>
>>>>>> Regtesting on x86_64-pc-linux-gnu. OK for mainline?
>>>>>>
>>>>>> Thanks,
>>>>>> Harald
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>
>>
>
next prev parent reply other threads:[~2024-05-13 7:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 19:33 Harald Anlauf
2024-05-09 19:51 ` Mikael Morin
2024-05-09 20:30 ` Harald Anlauf
2024-05-09 20:30 ` Harald Anlauf
2024-05-10 9:45 ` Mikael Morin
2024-05-10 19:48 ` Harald Anlauf
2024-05-10 19:48 ` Harald Anlauf
2024-05-10 19:56 ` Harald Anlauf
2024-05-10 19:56 ` Harald Anlauf
2024-05-13 7:25 ` Mikael Morin [this message]
2024-05-23 7:49 ` Mikael Morin
2024-05-23 19:15 ` [PATCH, v2] " Harald Anlauf
2024-05-23 19:15 ` Harald Anlauf
2024-05-24 18:17 ` Mikael Morin
2024-05-24 19:25 ` Harald Anlauf
2024-05-24 19:25 ` Harald Anlauf
2024-05-23 20:32 ` [PATCH] " Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e676dc9-c8f9-48f0-8167-039c688f53da@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).