public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jerry DeLisle <jvdelisle@charter.net>
To: Thomas Koenig <tkoenig@netcologne.de>,
	"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, libgfortran] PR53029 missed optimization in internal read (without implied-do-loop)
Date: Mon, 29 May 2017 19:44:00 -0000	[thread overview]
Message-ID: <4e6bea81-fa89-da95-6be4-56549e06f695@charter.net> (raw)
In-Reply-To: <2c00d8e7-700e-c13e-dbb2-d1928cc3c482@netcologne.de>

On 05/29/2017 09:51 AM, Thomas Koenig wrote:
> Hi Jerry,
> 
>> Regression tested on x86_64. I have added a test case which will check the 
>> execution time of the loop. The previous results of the REAd were correct, 
>> just took a long time on large arrays.
>>
>> OK for trunk?
> 
> OK.
> 
> It might be good if you followed Manfred's suggestion and turned
> down the timeout to something like 0.5 seconds.
> 
> Thanks for the patch!
> 
> I would also consider backporting, the speedup is just so
> large.  What do others think?
> 
> Regards
> 
>      Thomas

Committed.

	A	gcc/testsuite/gfortran.dg/read_5.f90
	M	gcc/testsuite/ChangeLog
	M	libgfortran/ChangeLog
	M	libgfortran/io/list_read.c
Committed r248577

Thanks,

Jerry

      reply	other threads:[~2017-05-29 19:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29  4:27 Jerry DeLisle
2017-05-29 14:13 ` Manfred Schwarb
2017-05-29 16:53 ` Thomas Koenig
2017-05-29 19:44   ` Jerry DeLisle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e6bea81-fa89-da95-6be4-56549e06f695@charter.net \
    --to=jvdelisle@charter.net \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=tkoenig@netcologne.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).