From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9740F385C33E for ; Thu, 23 Jun 2022 19:04:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9740F385C33E Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-502-Gh5XeWiOMQmi-ggr8XNppA-1; Thu, 23 Jun 2022 15:04:11 -0400 X-MC-Unique: Gh5XeWiOMQmi-ggr8XNppA-1 Received: by mail-qk1-f199.google.com with SMTP id bk10-20020a05620a1a0a00b006a6b1d676ebso140731qkb.0 for ; Thu, 23 Jun 2022 12:04:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=tvishTsj/MDYJ+b2vuvOOJusyfIUHFpX3JiHZyjGJoY=; b=2bOZ+hQPU8kRMewLvBpa1w4zOvIibYtxiFQRzYTwFOBIswtuloN6RGwe8/FYK9OKXf ximgj7XeJnyLwNx9VKeQlqA9f1D5mu3di+cV4gDpHuHpSusBXpzvpOhlyQmy1Sll8PCT gQt3my88z5niZh3xK/1fNCjDZY2mIzp75kof+xcn0tRGDsfJPTSuo1D6HdXkOmycWdx9 qEbAP2aTgvUpeuOEf+Ztu3QvpJS58n3zxA/VahC1iQnFF7ps4yVnAbKIEWvZZ2QrSWUx YQQL1V6PJT2EMGLF0yfy9ft9NgHId/s4rxrHvBBcJLQ79dkB3b5DdoWb2Mr+qYqjA6LI ls7Q== X-Gm-Message-State: AJIora/AQuyq/uBihaYS5SUGShYl6LKWTylmXoHajWW5loP5gLQ387LH XlFPOWmRbRgdTFQb0vEGnB7+WN+gDOJu16/q1XJpiz4XlC6ci+kU3mm+WJqL2JuiduAl0tN4TRc FYYO77HHzaFMjTmPSjzskXxdeL6PscwPxMQOwPa9vxVtpB1Jl0WhouIUoM9K6P6753nFfwA== X-Received: by 2002:a05:6214:1cc4:b0:464:683b:3e6c with SMTP id g4-20020a0562141cc400b00464683b3e6cmr33854862qvd.108.1656011050253; Thu, 23 Jun 2022 12:04:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uHNCrS4Q4q25q/gl1WHJbiuJrR6Slkcof35v+FZ+yM2TXLaFrnAhwHP0L5SfsYrMuwONk/Rg== X-Received: by 2002:a05:6214:1cc4:b0:464:683b:3e6c with SMTP id g4-20020a0562141cc400b00464683b3e6cmr33854803qvd.108.1656011049593; Thu, 23 Jun 2022 12:04:09 -0700 (PDT) Received: from t14s.localdomain (c-73-69-212-193.hsd1.nh.comcast.net. [73.69.212.193]) by smtp.gmail.com with ESMTPSA id y17-20020a05620a25d100b006a6a5d1e240sm328352qko.34.2022.06.23.12.04.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jun 2022 12:04:08 -0700 (PDT) Message-ID: <4e7b2b929bc98a5d12299546d86897c59313bdc4.camel@redhat.com> Subject: Re: [PATCH 01/12] diagnostics: add ability to associate diagnostics with rules from coding standards From: David Malcolm To: gcc-patches@gcc.gnu.org Date: Thu, 23 Jun 2022 15:04:08 -0400 In-Reply-To: <20220622223447.2462880-2-dmalcolm@redhat.com> References: <20220622223447.2462880-1-dmalcolm@redhat.com> <20220622223447.2462880-2-dmalcolm@redhat.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 19:04:15 -0000 On Wed, 2022-06-22 at 18:34 -0400, David Malcolm wrote: > gcc/ChangeLog: >         * common.opt (fdiagnostics-show-rules): New option. >         * diagnostic-format-json.cc > (diagnostic_output_format_init_json): >         Fix up context->show_rules. >         * diagnostic-format-sarif.cc >         (diagnostic_output_format_init_sarif): Likewise. >         * diagnostic-metadata.h (diagnostic_metadata::rule): New > class. >         (diagnostic_metadata::precanned_rule): New class. >         (diagnostic_metadata::add_rule): New. >         (diagnostic_metadata::get_num_rules): New. >         (diagnostic_metadata::get_rule): New. >         (diagnostic_metadata::m_rules): New field. >         * diagnostic.cc (diagnostic_initialize): Initialize > show_rules. >         (print_any_rules): New. >         (diagnostic_report_diagnostic): Call it. >         * diagnostic.h (diagnostic_context::show_rules): New field. >         * doc/invoke.texi (-fno-diagnostics-show-rules): New option. >         * opts.cc (common_handle_option): Handle >         OPT_fdiagnostics_show_rules. >         * toplev.cc (general_init): Set up global_dc->show_rules. > > gcc/testsuite/ChangeLog: >         * gcc.dg/plugin/diagnostic-test-metadata.c: Expect " [STR34- > C]" to >         be emitted at the "gets" call. >         * gcc.dg/plugin/diagnostic_plugin_test_metadata.c >         (pass_test_metadata::execute): Associate the "gets" > diagnostic >         with a rule named "STR34-C". > > Signed-off-by: David Malcolm This one seems potentially useful to plugin authors without the rest of the patch kit, so I've pushed it to trunk as: r13-1221-g0b14f590e3e9d9 (after a successful bootstrap & regression test on x86_64-pc-linux-gnu) Dave