public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: 钟居哲 <juzhe.zhong@rivai.ai>, "rdapp.gcc" <rdapp.gcc@gmail.com>,
	gcc-patches <gcc-patches@gcc.gnu.org>,
	palmer <palmer@dabbelt.com>, "kito.cheng" <kito.cheng@gmail.com>
Subject: Re: [PATCH] RISC-V: Add sign-extending variants for vmv.x.s.
Date: Mon, 12 Jun 2023 13:19:22 -0600	[thread overview]
Message-ID: <4e91040d-0c41-0790-64da-86ed3fb8d48b@gmail.com> (raw)
In-Reply-To: <70E81AB10E290491+202306122315528199324@rivai.ai>



On 6/12/23 09:15, 钟居哲 wrote:
> Change
> 
> +(define_insn "@pred_extract_first_sextdi<mode>"
> 
> into
> 
> (define_insn "*pred_extract_first_sextdi<mode>"
> 
> 
> Change
> +(define_insn "@pred_extract_first_sextsi<mode>"
> into
> (define_insn "*pred_extract_first_sextsi<mode>"
> 
> I don't think we will call combine pattern in vector-opt.md in the future.
> Use "*" instead of "@" can save resources during building.
Agreed.

If there aren't any other requests from Juzhe, then this patch is OK for 
the trunk.

jeff

      parent reply	other threads:[~2023-06-12 19:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 15:04 Robin Dapp
2023-06-12 15:15 ` 钟居哲
2023-06-12 15:18   ` Robin Dapp
2023-06-12 19:19   ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e91040d-0c41-0790-64da-86ed3fb8d48b@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=juzhe.zhong@rivai.ai \
    --cc=kito.cheng@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=rdapp.gcc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).