From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115498 invoked by alias); 8 Mar 2017 13:22:49 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 115486 invoked by uid 89); 8 Mar 2017 13:22:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=H*r:200 X-HELO: mail-ua0-f173.google.com Received: from mail-ua0-f173.google.com (HELO mail-ua0-f173.google.com) (209.85.217.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Mar 2017 13:22:47 +0000 Received: by mail-ua0-f173.google.com with SMTP id 72so37616621uaf.3 for ; Wed, 08 Mar 2017 05:22:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-transfer-encoding; bh=Q7Fiox51MmeNsU1RY8VzkAKf4rTQbCf9UP/chd9Xjjw=; b=kESxJLfXImskfa8wJeQTjG5pIC/HRXdCE9yi3Ee1FQJkVn/QjMYqRkh9RNt3l1aCA4 R0kMXgZEO+GjObe7fTEI3K9/66ZFBgaVQYJ0MBMACiQV3z2IoxmnG/Dp4NbFDFxlv8sq exMnJncTWlpvU5eFCn3+pZODacjW2LfnNRuSLe0zbWnsl7nw1vuer5kC98+/RG2dWPi7 PWX7ZDMvq0Q64XCGn953Bja9sc5t7GXgRm4SyzelbhkkRksqhWVkUUQvo6edVXzp8XIS EZprBUAtxnrJh+SpOALk8+4k4YFPLuFlr9ofbxEukI/Wv53gIeFqjGGTPCkx8OWiiIYv EjHg== X-Gm-Message-State: AMke39m5XEq3wic8qWedYEBSeoPsE5Im+IpfJqykccndR22nh7HyeAwBeWiH1VkCVWSNXA== X-Received: by 10.129.74.11 with SMTP id x11mr1656302ywa.297.1488979366037; Wed, 08 Mar 2017 05:22:46 -0800 (PST) Received: from ?IPv6:2620:10d:c0a3:20fb:f6d0:5ac5:64cd:f102? ([2620:10d:c091:200::a:15fc]) by smtp.googlemail.com with ESMTPSA id a184sm1225794ywf.11.2017.03.08.05.22.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Mar 2017 05:22:45 -0800 (PST) To: GCC Patches , mjw@redhat.com From: Nathan Sidwell Subject: [RFC PATCH libiberty] Fix infinite recursion in demangler Message-ID: <4ec9df26-f437-9a81-7a4f-2584577220bf@acm.org> Date: Wed, 08 Mar 2017 13:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00367.txt.bz2 https://gcc.gnu.org/ml/gcc-patches/2017-03/msg00089.html? Patch looks good to me (not a libiberty maintainer) One question: + if (dc == NULL || dc->d_printing > 1) Can dc ever be null here, or is this just extra defensiveness? nathan -- Nathan Sidwell