From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id E387D38418AA for ; Tue, 21 Jun 2022 03:44:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E387D38418AA Received: by mail-pf1-x433.google.com with SMTP id 128so4906167pfv.12 for ; Mon, 20 Jun 2022 20:44:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:references:from:in-reply-to:content-transfer-encoding; bh=3gr/V3FtQDuu5boSChqh4nlSB4cG57EjTXdZoD4jKQQ=; b=OusiSQEHPnI/LJLOG0A/aR4qB3YCcqKbxWcAtxzhkgGBFNMwNfwlLbwSpck7SAGCmo u8ta3Dw9GCzTYRtwrcfNvkv8rTT1WjGNoorxN6VIZE6DtIQSEFsNEtSdskHyxVSr//0S Qm6x+YR0bx3dTUMe3a67RvpY2uWz2O/Jgt3M7R3Lu+rwGaHWWXTd/UWyoNdUOyMgcWv5 t4Z92SGmbPPWsS7dgwyqFjiRtAmYMGWszYB3rjG0syxgrB8O78zF3wq8I8cOAZvg2slD uXd+nwGBjI4fDASS8I08Ot6cN6yqjvsFp+ESWzN94ef4VzFN+WLKMb4RM2jBZ6vV+C7O zCFQ== X-Gm-Message-State: AJIora8F8gqZFJfk5qZsO0Bl3kZennlMKcUMDGgA8aaXTvU3aHa4FCVJ w4XKA+MaXRBCGLC6aHpJgiU= X-Google-Smtp-Source: AGRyM1tPLScoLwieLT3Hr7j5i8RjnGZ+hh1Fvbp2YYbXUOI+Ph/754u/weKmxDLq6hBfarW4GdtZ7w== X-Received: by 2002:a63:3344:0:b0:408:cd45:3e6b with SMTP id z65-20020a633344000000b00408cd453e6bmr24531846pgz.146.1655783048721; Mon, 20 Jun 2022 20:44:08 -0700 (PDT) Received: from [192.168.255.10] ([203.205.141.87]) by smtp.gmail.com with ESMTPSA id y10-20020a170902d64a00b0015e8d4eb2c5sm9406579plh.271.2022.06.20.20.44.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 20:44:07 -0700 (PDT) Message-ID: <4f1bae53-c9c6-3fd2-126d-d607f3198683@gmail.com> Date: Tue, 21 Jun 2022 11:44:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] if-to-switch: Don't skip the first condition bb when find_conditions in if-to-switch [PR105740] To: =?UTF-8?B?eGlvbmdodWx1byjnvZfpm4TomY4p?= , gcc-patches References: From: Xionghu Luo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 03:44:11 -0000 Correct the format...  test2: .LFB0:         .cfi_startproc         xorl    %edx, %edx         cmpl    $3, (%rdi)         jle     .L1         movl    16(%rdi), %eax         cmpl    $1, %eax         je      .L4         subl    $2, %eax         cmpl    $4, %eax         ja      .L1         movl    CSWTCH.1(,%rax,4), %edx .L1:         movl    %edx, %eax         ret         .p2align 4,,10         .p2align 3 .L4:         movl    $12, %edx         jmp     .L1         .cfi_endproc .LFE0:         .size   test2, .-test2         .section        .rodata         .align 16         .type   CSWTCH.1, @object         .size   CSWTCH.1, 20 CSWTCH.1:         .long   27         .long   38         .long   18         .long   58         .long   68 With the patch attatched:  test2: .LFB0:         .cfi_startproc         xorl    %edx, %edx         cmpl    $3, (%rdi)         jle     .L1         movl    16(%rdi), %eax         subl    $1, %eax         cmpl    $5, %eax         jbe     .L6 .L1:         movl    %edx, %eax         ret         .p2align 4,,10         .p2align 3 .L6:         movl    CSWTCH.1(,%rax,4), %edx         movl    %edx, %eax         ret         .cfi_endproc .LFE0:         .size   test2, .-test2         .section        .rodata         .align 16         .type   CSWTCH.1, @object         .size   CSWTCH.1, 24 CSWTCH.1:         .long   12         .long   27         .long   38         .long   18         .long   58         .long   68 On 2022/6/21 11:05, xionghuluo(罗雄虎) via Gcc-patches wrote: > Current GCC generates: > > >  test2: > .LFB0: >         .cfi_startproc >         xorl    %edx, %edx >         cmpl    $3, (%rdi) >         jle     .L1 >         movl    16(%rdi), %eax >         cmpl    $1, %eax >         je      .L4 >         subl    $2, %eax >         cmpl    $4, %eax >         ja      .L1 >         movl    CSWTCH.1(,%rax,4), %edx > .L1: >         movl    %edx, %eax >         ret >         .p2align 4,,10 >         .p2align 3 > .L4: >         movl    $12, %edx >         jmp     .L1 >         .cfi_endproc > .LFE0: >         .size   test2, .-test2 >         .section        .rodata >         .align 16 >         .type   CSWTCH.1, @object >         .size   CSWTCH.1, 20 > CSWTCH.1: >         .long   27 >         .long   38 >         .long   18 >         .long   58 >         .long   68 > > > > > With the patch attatched: > > >  test2: > .LFB0: >         .cfi_startproc >         xorl    %edx, %edx >         cmpl    $3, (%rdi) >         jle     .L1 >         movl    16(%rdi), %eax >         subl    $1, %eax >         cmpl    $5, %eax >         jbe     .L6 > .L1: >         movl    %edx, %eax >         ret >         .p2align 4,,10 >         .p2align 3 > .L6: >         movl    CSWTCH.1(,%rax,4), %edx >         movl    %edx, %eax >         ret >         .cfi_endproc > .LFE0: >         .size   test2, .-test2 >         .section        .rodata >         .align 16 >         .type   CSWTCH.1, @object >         .size   CSWTCH.1, 24 > CSWTCH.1: >         .long   12 >         .long   27 >         .long   38 >         .long   18 >         .long   58 >         .long   68 > > > Bootstrap and regression tested pass on x86_64-linux-gnu, OK for master?