From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id C726A3858D28 for ; Wed, 28 Sep 2022 01:12:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C726A3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x534.google.com with SMTP id s26so10886238pgv.7 for ; Tue, 27 Sep 2022 18:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=dxM0Aw3QL5LMa31UVy/0s9I71m77gDRKz48s845Ozps=; b=iZZwBsiNglUrw8wAHcMMPqny4hl7a7j9FpN4Uwmb2zzPSKwin9HCPgCnAqx+WKbSHQ n9F3isuWQaF+DVRX5CIGbylOGEamh3u/TsKcVO2N6Lf2luL7ryBI3E74CbIZ7EYQggyZ GaA/Da7bSokdrFDrV4nEz4CvsH3FPgenet/IpraZeyKlqu19YEWBgPWct4dS4UNsIo8z JGYiPpWHE5pafIF9qsq636P+h2oRK+2p3VyiF5Eu202LeDqlvT1TPiVzdVGKSB8GwPO6 u+BCEqVAucBoAT8MxtuZ2ScDIHXf6tWF1vjKvSAG5fHMiSLLZFqwG4Wl38AloVWvCXTo cTqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=dxM0Aw3QL5LMa31UVy/0s9I71m77gDRKz48s845Ozps=; b=ZZPRNIDDJO5TugYYJ6L7jMH4bD5mA+lNyzRhDp9xZbq0gvrUCFbUwjNZsCexQhezpz E0e7b/S6J8mAhBPvBgduwiwYHfHoeOoBpOcvaiDlz08yZIk1HahhLOzrp71gHiOlXc5I IN5QdsvXKl3EqylaRdphqr94agEVIuyNLRi415/gSM+AFaZYiUq9fW8h44QBxJtvjrKb 9lCObjD+/KduQhw+L3zsN5H3of3sgHYHlyxMVOxG/FFyILXL0VNfU0YS22i9P/45PJ+w jfidkFV5PmFNfrNVYDco0Aia3/X5TyKM8DENVyA1SfAie8T4MMeKwVNZTFTIMOLyzmiO PFvw== X-Gm-Message-State: ACrzQf2f1j37x1yV0dgE6lkE+i7PIqKP3i9RUKE03SunWEPnremNVVdH DFgB8U/hG84ZbDdbkBa3Tk8S6zqEamU5Ag== X-Google-Smtp-Source: AMsMyM5vxNbTQpl0H7ahzV8MR+pYcBl2czObW02Ys2L+aRqbg7WP70robAlcA2pR6q7zdUnO46T55Q== X-Received: by 2002:a05:6a00:10c2:b0:547:4991:c985 with SMTP id d2-20020a056a0010c200b005474991c985mr32552065pfu.67.1664327562199; Tue, 27 Sep 2022 18:12:42 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id j5-20020a170903024500b0017689960d10sm2210668plh.156.2022.09.27.18.12.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Sep 2022 18:12:41 -0700 (PDT) Message-ID: <4f1f2040-6bad-d48b-d7d4-3df2dcd3a9a1@gmail.com> Date: Tue, 27 Sep 2022 19:12:40 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2] stack-protector: Check stack canary before throwing exception Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20220817221855.35043-1-hjl.tools@gmail.com> From: Jeff Law In-Reply-To: <20220817221855.35043-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/17/22 16:18, H.J. Lu via Gcc-patches wrote: > Check stack canary before throwing exception to avoid stack corruption. > > gcc/ > > PR middle-end/58245 > * calls.cc: Include "tree-eh.h". > (expand_call): Check stack canary before throwing exception. > > gcc/testsuite/ > > PR middle-end/58245 > * g++.dg/fstack-protector-strong.C: Adjusted. > * g++.dg/pr58245-1.C: New test. OK. Jeff