From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] Fix two grokdeclarator locations
Date: Wed, 14 Nov 2018 00:30:00 -0000 [thread overview]
Message-ID: <4f2224b4-e469-8497-f59e-495383f5f957@redhat.com> (raw)
In-Reply-To: <ecdfe7c0-ad95-457a-be56-7ea4016dd3ce@oracle.com>
On 11/12/18 6:39 AM, Paolo Carlini wrote:
> Hi again,
>
> On 08/11/18 10:26, Paolo Carlini wrote:
>> Hi,
>>
>> two additional grokdeclarator locations that we can easily fix by
>> using declarator->id_loc. Slightly more interesting, testing revealed
>> a latent issue in the make_id_declarator uses:
>> cp_parser_member_declaration wasn't setting declarator->id_loc, thus I
>> decided to add a location_t parameter to make_id_declarator itself and
>> adjust all the callers. Tested x86_64-linux.
>
> PS: In my local tree I have the cp_parser_objc_class_ivars change using
> token->location instead of UNKNOWN_LOCATION, thus all the
> make_id_declarator calls should be completely fine location-wise.
Great, I was going to ask about that. Can I see that patch, then?
Jason
next prev parent reply other threads:[~2018-11-14 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 9:33 Paolo Carlini
2018-11-12 11:39 ` Paolo Carlini
2018-11-14 0:30 ` Jason Merrill [this message]
2018-11-14 9:26 ` Paolo Carlini
2018-11-14 15:33 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f2224b4-e469-8497-f59e-495383f5f957@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).