From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 9FD803858C2F for ; Thu, 27 Jul 2023 08:41:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FD803858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-99357737980so89329666b.2 for ; Thu, 27 Jul 2023 01:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690447296; x=1691052096; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fIYQXZhTwRKikIKmIxAx4QhQ7ptxvDpKeTSepGQ683U=; b=Ihpv2ODCI7RpG4tDQRbVwJ574yJpTkMNNviWt/sdSnfMKShVHbfOIJA+3dO41lulYA FlR8oHK8n4rGLTIWAYvSrLT12Z0GtkjZ5kbNoAElLqr/7f1/OwgXk8MjJ9+qkFqcopun YTqioUDFqOQHH6pHP6x6oFAjN4qk+58F6rNv8UWrLUSl9SfyBJ6LfPUe6a6e6bTsEvAh N+3/nroZ1G/tQAbr0E1Ogt9RNayTAE4fB7NvMNM44CKPkEefBpqKtabFsP1Bu3UcUe59 Qfm3xx8BNfZItYCsrRUx2UkIzaWgAMjVFEy3YzbUKr5svDnaCQdQbvEN5YY0r66yTwwo A28w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690447296; x=1691052096; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fIYQXZhTwRKikIKmIxAx4QhQ7ptxvDpKeTSepGQ683U=; b=F651e12IpDd2ueTx1h8kbRlWX4tTeOqXNjNAtKMB+OYC2hOF4Kw+IUXToZbAAWJu7k amVGkIoWwdW9b5Oh4yunJO1fPzI+0bkd0ZQixdgwRWrIpTyqLX1NrbMz9MDtEYSJnUkX u+jJEgXwAHHck8+NC290ZHiWyVXrWVT9DKUM5F5/nEyHB8M94qOC00l4pEDUHWYfSAoU kcjiem+Nex0O/AdCpbBU3e0dLxdomz4ycgAy0I8V1nbtD+Kh1Ats+frU85Mw7nuub/XW vietm16tD+oAsLPiCEodIHtrvFdaIq1lSAoUKDr/LNEgzCrcU85JmzvjbZLRriQHEWgY RAqA== X-Gm-Message-State: ABy/qLYtT9ELkz3P3IW1+zVmKMyp6QCx66CHdsHsOS8dpivEXKu5KrI/ cGZ1HD5jVDMsgTwyRyjdj70= X-Google-Smtp-Source: APBJJlEDHMT/0We6a3GD5pEckdx1Mj1IMjDVfjML8uXzz6YBULrCBOLl4F7S9x/1vIQE8LzdpTyp2g== X-Received: by 2002:a17:906:5a5e:b0:99b:d1d8:d747 with SMTP id my30-20020a1709065a5e00b0099bd1d8d747mr1411694ejc.27.1690447295737; Thu, 27 Jul 2023 01:41:35 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id t7-20020a1709063e4700b0098d15d170a0sm489244eji.202.2023.07.27.01.41.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 01:41:34 -0700 (PDT) Message-ID: <4fa1f366-95cb-d846-7afc-bedcf84ffcad@gmail.com> Date: Thu, 27 Jul 2023 10:41:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: rdapp.gcc@gmail.com, "gcc-patches@gcc.gnu.org" , "juzhe.zhong@rivai.ai" , "Wang, Yanzhang" Subject: Re: [PATCH v7] RISC-V: Support CALL for RVV floating-point dynamic rounding Content-Language: en-US To: "Li, Pan2" , Kito Cheng References: <20230719032822.85817-1-pan2.li@intel.com> <20230725055156.595718-1-pan2.li@intel.com> <2a9db9ea-ba9e-264c-fe2f-c44bb8f9d580@gmail.com> <911144fa-47f1-4607-0795-fac42de680fe@gmail.com> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I see, you mean at the beginning of frm_after, we can just return the incoming mode as is? > > If (CALL_P (insn)) > return mode; // Given we aware the mode is DYN_CALL already. Yes, potentially similar for all the other ifs but I didn't check all of them. > Thank and will cleanup this in v8. AFAIK, the optimize_mode_switching > only check ptr->mode != no_mode before emit, not sure if I missed > something. if (mode != no_mode && mode != last_mode) { Shouldn't this cover us? I didn't run the testsuite or so but it looks like it. Regards Robin