From: Sudakshina Das <sudi.das@arm.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
Christophe Lyon <christophe.lyon@linaro.org>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: [PATCH][ARM] Fix test fail with conflicting -mfloat-abi
Date: Mon, 22 Jan 2018 11:36:00 -0000 [thread overview]
Message-ID: <4fd74e5c-b59d-452f-ca1e-0793123cd461@arm.com> (raw)
In-Reply-To: <5A623229.3060702@foss.arm.com>
Hi Kyrill
On 19/01/18 18:00, Kyrill Tkachov wrote:
>
> On 16/01/18 10:31, Sudakshina Das wrote:
>> Hi Christophe
>>
>> On 12/01/18 18:32, Christophe Lyon wrote:
>>> Le 12 janv. 2018 15:26, "Sudakshina Das" <sudi.das@arm.com> a écrit :
>>>
>>> Hi
>>>
>>> This patch fixes my earlier test case that fails for arm-none-eabi
>>> with explicit user option for -mfloat-abi which conflict with
>>> the test case options. I have added a guard to skip the test
>>> on those cases.
>>>
>>> @Christophe:
>>> Sorry about this. I think this should fix the test case.
>>> Can you please confirm if this works for you?
>>>
>>>
>>> Yes it does thanks
>>
>> Thanks for checking that. I have added one more directive for armv5t
>> as well to avoid any conflicts for mcpu options.
>>
>
> I agree with what Sudi said in
> https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01422.html
> I'd rather keep the test in the generic torture suite as long as we get
> the directives right.
>
> So this is ok for trunk (as the changes are arm-specific directives)
> with one change below:
>
> Thanks,
> Kyrill
>
>> Sudi
>>
>>>
>>>
>>> Thanks
>>> Sudi
>>>
>>> gcc/testsuite/ChangeLog
>>>
>>> 2018-01-12 Sudakshina Das <sudi.das@arm.com>
>>>
>>> Â Â Â Â Â Â Â Â * gcc.c-torture/compile/pr82096.c: Add dg-skip-if
>>> Â Â Â Â Â Â Â Â directive.
>>>
>>
>
>
> diff --git a/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> index 9fed28c..35551f5 100644
> --- a/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> +++ b/gcc/testsuite/gcc.c-torture/compile/pr82096.c
> @@ -1,3 +1,5 @@
> +/* { dg-require-effective-target arm_arch_v5t_ok } */
>
> Please also guard this on { target arm*-*-* }
> That way this test will be run on other targets as well so that they can
> benefit from it.
>
> +/* { dg-skip-if "Do not combine float-abi values" { arm*-*-* } {
> "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */
> Â /* { dg-additional-options "-march=armv5t -mthumb -mfloat-abi=soft" {
> target arm*-*-* } } */
>
Thanks committed with the change as r256941
Sudi
>
prev parent reply other threads:[~2018-01-22 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 14:46 Sudakshina Das
2018-01-12 18:34 ` Christophe Lyon
2018-01-16 10:37 ` Sudakshina Das
2018-01-19 18:06 ` Kyrill Tkachov
2018-01-22 11:36 ` Sudakshina Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fd74e5c-b59d-452f-ca1e-0793123cd461@arm.com \
--to=sudi.das@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).