From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107647 invoked by alias); 22 Jan 2018 10:57:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 107630 invoked by uid 89); 22 Jan 2018 10:57:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.8 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:EUR02-A, Hx-languages-length:2127, H*r:40.107.0 X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00072.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.72) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jan 2018 10:57:39 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Sudi.Das@arm.com; Received: from [10.2.206.246] (217.140.96.140) by AM4PR08MB1044.eurprd08.prod.outlook.com (2603:10a6:200:28::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Mon, 22 Jan 2018 10:57:33 +0000 Subject: Re: [PATCH][ARM] Fix test fail with conflicting -mfloat-abi To: Kyrill Tkachov , Christophe Lyon Cc: gcc Patches , nd , Ramana Radhakrishnan , Richard Earnshaw References: <28cf665e-68a0-0494-af80-af20b4b96a1e@arm.com> <5A623229.3060702@foss.arm.com> From: Sudakshina Das Message-ID: <4fd74e5c-b59d-452f-ca1e-0793123cd461@arm.com> Date: Mon, 22 Jan 2018 11:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5A623229.3060702@foss.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: HE1PR0202CA0047.eurprd02.prod.outlook.com (2603:10a6:3:e4::33) To AM4PR08MB1044.eurprd08.prod.outlook.com (2603:10a6:200:28::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30b03689-6828-414a-cab7-08d56186f107 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(48565401081)(2017052603307)(7153060)(7193020);SRVR:AM4PR08MB1044; X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB1044;3:e4EH75oedEDcbYPZI8csHt3NwLMoozsmMvsx+90o8BN+VBdExZS5ppphX82Z+5rJNs0ty2OhrQVYEZCs1zd9hpcAvwnYXDt0p5YWRCrElKKmWwh2c8tsgyhgG9/t2I/fQKSncTGhrMOtEdaEAM18GfST+eL/gIn2FRAZ2HxunEMbmzdCQfpepjwHfxnrVQ45b3TeYvl5G+oV5ogRb51s8aGk76nRkTt+8DdW961nQHtFbX7YUYf+oItWo6NQTQRv;25:b8REpn0Rk3vDFKKmFbIyaxWtlDfIkAwTuuiO+Uxb5LfKc56CmflKSsTQ7vTx+WbSEzRRdfejcWbI4tyH6kY8vAQiy8uxMfsHEKwxor/DItOpuKx6u/udrDPkaIC8Wgkr1NLEbOxiztAvsgcdl1xQ1/2NGx8T19EeFtzKVkt5W9mCPsnlk0p8mM/R2NZRq1gKjVyrThyPVGfZ87klcw2HEKsqewfLKsgfQd6GM551dQhwhKmsDSGScN+QbIoLqzYup+QFfW/9eeF2BiENYbdI+dePSE1gALuqj2gMrn8IZ+u0PxYnHzh1SiPdLBpc0RZAJ9ETXcpFnEImWr0VkrR5bQ==;31:VVCpcjXgGOcAx3pPzi7dS/Qq7+iNn1dIEWiaL0tcHRvUBavrloFP603KpdE414GtJwi1fPFU5FqRnJtDVW3fpWg4IrkkbxccqcP2tJPF/7nTho61LXseRz8b0XNfP1gDG0HUzlL94sXCpCyQe9rUqzaZvnDowZg5Sv7DyaIJDfd5SS9/pUKOcjxrKT6zQuIbRtehHEkFV4vRWTm+o1nNHGVGQWlFOIvpifEr5W3iGJw= X-MS-TrafficTypeDiagnostic: AM4PR08MB1044: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB1044;20:JL2y7+Nm0yZ/dEgAeT+/35Xl0xypWxyVFbEx2cm/O9tvBPck1OxQ4oSecBxT/Ib5yrtQzuYnjcxG/OQCOGLfKa0Ej4TADZzvzFHSb8GfzK1Bt5govxoEN7XpJx3hRYOFeF1R5y6iLX9mhthNmTq9hxxlEHqzQwuGepTBZIno8fg=;4:VnG7UTsUA76DhhdbDre3CnbR3x1QUKel/33w1d38wQDkHFV3B6B2OzKe6uTUtSV7K6P1yXWz5jizonPSynvDmTYplDDYsZ3oU7IWgAAFx9bt5WxSorYHV3U2un0FOAoOL5/lHcpnZ6wJR/3aR+r/jfx6bNjDsvX8bGXI+ZKlnKPAKwbh9FuU/yKzV3AlrC9n49F3m1+LqXEFJq8YGWky/rXUy0rJBrNLVJjJpV0KCbtm2Lmdjx5uAkJVQTAlg4UhkmXDdJigCUdXtjuJvrgdLPHMPGiCdH6IfCHHO91zpBEd5Isw+a0oiJLJO6ymTVmCqxG7c6dpOrxnoj1Sz4eSK5yOB3JUVm/X2PufyY+ZLG7JtEISURCJ6zx/zo+RIB3d X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(22074186197030)(183786458502308); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041288)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:AM4PR08MB1044;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM4PR08MB1044; X-Forefront-PRVS: 0560A2214D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(376002)(39380400002)(366004)(346002)(396003)(39860400002)(377424004)(199004)(189003)(54534003)(478600001)(6306002)(53936002)(386003)(53546011)(966005)(77096007)(229853002)(26005)(72206003)(59450400001)(6486002)(76176011)(6246003)(31696002)(64126003)(2870700001)(105586002)(2906002)(7736002)(8936002)(93886005)(31686004)(5660300001)(67846002)(68736007)(305945005)(65826007)(106356001)(25786009)(8676002)(81156014)(66066001)(81166006)(16526018)(65956001)(86362001)(47776003)(65806001)(4326008)(83506002)(16576012)(97736004)(6116002)(316002)(36756003)(54906003)(58126008)(50466002)(2950100002)(3846002)(110136005)(23676004)(2486003)(52146003)(52116002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR08MB1044;H:[10.2.206.246];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQUjA4TUIxMDQ0OzIzOm9JWW9CTGhNWm5USzZGTTVjMEtiTS9FaWFF?= =?utf-8?B?RFh0aEptT2djWExkVFovdC9qT282S0NBUjVZYkcvajcyUVZpZTBIcjJnbjZV?= =?utf-8?B?QlU5YlJkcU1sT1dIY2NEczZoYUFnZXliaXFaVElkSFdLNS9hUmlLYy9ZV2tG?= =?utf-8?B?SlUzR2lHUjJQRXE0c1cwQzU2MFVQc2NEek4wSjIxZnNQOEhacm9BOVd6dHdR?= =?utf-8?B?czF0OUJWbkJ6YWQrZlBPSWZJVTN6b3g2eUVBcWthSXVaenkzZTdwSllQRjY2?= =?utf-8?B?M1owMVRwZHcxVHIwYk0wQzRsZGsvanIrZGY2WUU2OVRsQm44dDlnN1JkL1dO?= =?utf-8?B?VHdIS0dCcFZjYnF3Nis1b0VKUU1qcm9KSUlrSUhhanZPWG9vem9CMDRLQzVV?= =?utf-8?B?YVE3TFRVUmdhRUZaMUFKVHhsajR0T2h4T1VUQnVzVWFnQ0tQWTUxVGk4cHhK?= =?utf-8?B?QnNZUEZrRU1EQ2o5amJ1MzczMjc3ZElnRE9kNlRIZTVJanpxWlQ4ZDI0QWx2?= =?utf-8?B?bkREbS9jR2xOd3lRZlVtUjk3Ly9NenVRcFNKOWZxUG9XWFNYaDBScFVrVjFp?= =?utf-8?B?b2hjdjVxZjgwcWVvRERRZmNyamF2djZuVjM2VjVxNkdVQmtyKzczTWs4QmRp?= =?utf-8?B?cUJQVXNlZEorMlpZZXVuTDN3V1djZHRzWlh3bFpWblRDL1N6OUEwWEE3WXM5?= =?utf-8?B?YUxZNVJCQ0ZvUFgzTEtQRFJ2cDZ3aHBRV0xkWVpaVm93b2VRUzcxYytYWTB2?= =?utf-8?B?d0I5Vitwc294eU1iQURLNXFSU0ZpU21VSGtJdkk3akRCazREWFZhQlJiSFZK?= =?utf-8?B?OE9IbHVMZWpSdkJMN2tkaTUzcGlUYkEzeDUrQklXMnhhQ1VGQXJ5bGhGTTJa?= =?utf-8?B?TlV4NlFvSlhaUjllSk1CdVA0VTMxTitSRmZHdDkyUjQvNVYydEFSZGlhVHc5?= =?utf-8?B?dmZ4N1N2bFhKaFk3VkJoZDdpMS96RGpzRG9aNDVYdVRhOUZHM1NUOTVuaVBw?= =?utf-8?B?UlNrWnRkcnhlSG1aSGN3akdZSXJnVVhicVFQeDJBQzVrRi9ham9XWkxEMzgz?= =?utf-8?B?RjZjMUx6ZjJ5UmFaRHQ1Sk5WT2VtZCthajE3UU5NV21KbWJ6bS8wNGZPTlFv?= =?utf-8?B?bnBDWTNrUVlKZk15eGtKTDJsM3JvWDFuT2ZoMmRoQTNLRlEvWGZ4aWJTaktj?= =?utf-8?B?NmNZL0xSeFdQV0p2Qm1xbFdYQlMyRzhtamRNMXQ4bTV4QVdMU1RFeVJsQTV6?= =?utf-8?B?aW54QWdIM05zMko3a3pjT0ljUkpDcmJoaW5XOFNRR21WRlV4ZlhnZWplam1Y?= =?utf-8?B?Y3pUMnB0OWMza3pzZTRTaUtLa3lNclVZeUFLSXJVNlJta29RTzF5M1gwdmNM?= =?utf-8?B?V3lVcm8xUVFkQ28xWmxoZlVVU3hYYWZOa3pJR0pEUkZoVkZ0SnA4ZmpPdlRH?= =?utf-8?B?N2NQbWtSTnZCRW03aFdhSDNSRkdpVm1xSUtKNHd6OC93NHB1UVZBVERCRW1C?= =?utf-8?B?MFNWejQ0V1lZZ3V2ZVJONFllTmtDcU1SazJMYmpERHh5TTFxa1hVM2pzOVZO?= =?utf-8?B?N2VIZHZDeDJmRmkySXB0U1JEeUxKSmtIZXpRd0NkYThEcmxiVDZCTU52MVQ1?= =?utf-8?B?UXZrNEd5MEVDbzFrOFhKZHd5V1lMMnc2b0tkOGxldXZrdTZiS2pGVGMwNFht?= =?utf-8?B?UFlnL1ZmUVNlb3oreklJall4dnJBaDhxcE53cEwzZGFOY29JUS9KRlBqaytF?= =?utf-8?B?aytJTUZXZ0lyRDZUUzdHbWVIRDZXUW1vekdpMkVqdy9ObzF0SHpKSitXa2Ri?= =?utf-8?B?ZEUwK1VYanZhYzVaaEJReTR4dGRPaGZYMWJTZk9rMUJVTDNyNVBQZ2M1dlVp?= =?utf-8?B?SmtMZVk1alU4bE1xMWp5NVdsOU1jMGxzVms2cUE2S0tOdUphcHZ5WVZMQTZL?= =?utf-8?B?MmRGMlFUNmJCMU96bVVqZEdRQlZFT3VQOHcxZWU3YmErS1AwYnR0UFEzVnVQ?= =?utf-8?B?OE9reURldFBLR0RiYW5HWHVtNmJYbXY3aWczUitCODY5bDBBcUxrajB4OWRt?= =?utf-8?Q?CeJNGr2XcnRxp3gI4MLcRbe7c?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR08MB1044;6:ebh3R8RhrzNJKBkaOL6K25X5ORm6rcrMelbzyySjCeHa76FmIjGllBQ3u8jkv2yQT0irksLlLPU1uR18c6m/r6fpsH3sOd0OTjL5SEvnf9tOf1kq8Aj1usxdAQQVK6bvy86jLGnXbXcO8INHCwrJesUVV4bwAPr6gJjcj9vUlevmHK5N9/1QKeWpAQGt+V24wEFmrvq3jGrjfPKpXED+ZWRtMFVQTdcaSBl97UsK1gfbI+HS6iBBfTVdONjQa8onzVkcwpW9x5s7nIEtxl/c4dZqfit7O39smgobSPCPCO2kV0eRCAMoGYlwdHuJeYsLZVx9eD5i6AS+8ddPwx9ZPN3KwLv7b9gWle4w4PYy6pw=;5:VV2qSDamqLLX/7zO4rVrOGxt0VftqqLCLwT/2zDiVnTyyhfwqawwozkISpDqsM/4LwC9UXjqdBGKAf2754Lnd2bbA+2dsfXyGZZy7DtcDIdhLVxB9x3cPHzpclAjKuLWuyfN1Jby8PS9XPiWiKPn571rjLYEc13oPk7b2QFj5C0=;24:Hi7wnPwvqnjtn6lEdier2pN9fJFbjcN4RmWVcsljlfLKeLqJPSPkoOvCN4cE34WKY0kt9EtvUu5CDRCm5V/FylNZjX1g1peZBaf35K47JHo=;7:zMMYkTxFv6b8iJnGuFMs9mLocexi5dWgqd5VUgwlhqpCrHiCLkuTIMaGqzOiwXK9AYYSg48KBD8Ao/jmoTSyiCCqKIXs4PtLhXR3oxVTgtdH3s9PVXChIboejpnK2Mu/PIq2qLzSxsDeH9LJByrKeXsdK1ET7Y+OjnLb1IA9ap+Y4lzr64Qq2JGkDC7K6edxfW8jRVF4f2UETaStitadVpo9jgZ9As29wkqocaMACswapVea559qy72oSQ5S/Fo9 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2018 10:57:33.2937 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30b03689-6828-414a-cab7-08d56186f107 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB1044 X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg01853.txt.bz2 Hi Kyrill On 19/01/18 18:00, Kyrill Tkachov wrote: > > On 16/01/18 10:31, Sudakshina Das wrote: >> Hi Christophe >> >> On 12/01/18 18:32, Christophe Lyon wrote: >>> Le 12 janv. 2018 15:26, "Sudakshina Das" a écrit : >>> >>> Hi >>> >>> This patch fixes my earlier test case that fails for arm-none-eabi >>> with explicit user option for -mfloat-abi which conflict with >>> the test case options. I have added a guard to skip the test >>> on those cases. >>> >>> @Christophe: >>> Sorry about this. I think this should fix the test case. >>> Can you please confirm if this works for you? >>> >>> >>> Yes it does thanks >> >> Thanks for checking that. I have added one more directive for armv5t >> as well to avoid any conflicts for mcpu options. >> > > I agree with what Sudi said in > https://gcc.gnu.org/ml/gcc-patches/2018-01/msg01422.html > I'd rather keep the test in the generic torture suite as long as we get > the directives right. > > So this is ok for trunk (as the changes are arm-specific directives) > with one change below: > > Thanks, > Kyrill > >> Sudi >> >>> >>> >>> Thanks >>> Sudi >>> >>> gcc/testsuite/ChangeLog >>> >>> 2018-01-12  Sudakshina Das  >>> >>>          * gcc.c-torture/compile/pr82096.c: Add dg-skip-if >>>          directive. >>> >> > > > diff --git a/gcc/testsuite/gcc.c-torture/compile/pr82096.c > b/gcc/testsuite/gcc.c-torture/compile/pr82096.c > index 9fed28c..35551f5 100644 > --- a/gcc/testsuite/gcc.c-torture/compile/pr82096.c > +++ b/gcc/testsuite/gcc.c-torture/compile/pr82096.c > @@ -1,3 +1,5 @@ > +/* { dg-require-effective-target arm_arch_v5t_ok } */ > > Please also guard this on { target arm*-*-* } > That way this test will be run on other targets as well so that they can > benefit from it. > > +/* { dg-skip-if "Do not combine float-abi values" { arm*-*-* } { > "-mfloat-abi=*" } { "-mfloat-abi=soft" } } */ >  /* { dg-additional-options "-march=armv5t -mthumb -mfloat-abi=soft" { > target arm*-*-* } } */ > Thanks committed with the change as r256941 Sudi >