From: Robin Dapp <rdapp.gcc@gmail.com>
To: Juzhe-Zhong <juzhe.zhong@rivai.ai>, gcc-patches@gcc.gnu.org
Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com,
jeffreyalaw@gmail.com
Subject: Re: [PATCH V2] RISC-V: Fix incorrect index(offset) of gather/scatter
Date: Wed, 11 Oct 2023 11:50:49 +0200 [thread overview]
Message-ID: <4fee0881-10c5-4f27-8c24-b0405c1481f6@gmail.com> (raw)
In-Reply-To: <20231011093631.2993626-1-juzhe.zhong@rivai.ai>
Hi Juzhe,
good that you noticed it now, I should have caught that
in the review back then...
One thing, though:
> + if (inner_offsize < GET_MODE_BITSIZE (GET_MODE (ptr)).to_constant ())
Shouldn't ptr always be Pmode i.e. the bitsize == XLEN?
Rest LGTM.
Regards
Robin
next prev parent reply other threads:[~2023-10-11 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 9:36 Juzhe-Zhong
2023-10-11 9:50 ` Robin Dapp [this message]
2023-10-11 9:55 ` juzhe.zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fee0881-10c5-4f27-8c24-b0405c1481f6@gmail.com \
--to=rdapp.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=juzhe.zhong@rivai.ai \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).