From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 009FD3857713 for ; Wed, 11 Oct 2023 09:50:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 009FD3857713 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9ae2cc4d17eso1184259966b.1 for ; Wed, 11 Oct 2023 02:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697017850; x=1697622650; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0mVUc2QYg0Efw6pJNeVz/zFnZzuYD+chiGBHwX1I3EU=; b=YXa4NtBW/+/hmXEcv+/m11zw+eTrBdYe4w0heFOqiUaTZoH/VKgmOPLM9b7O0Wd2uC glgFqBhKCN3pbIDnlkN9+YPbIMyAf87F49ysxWmLh947HDMlsp9G4FSpe9AptBz8++R9 nmuhKNGiFJRYtahUb2RNx8Ms+nMSkv/0NXB1J0eHI1/kUw7HAqyJx6EtUCE94q3gYSXE bcsDu/GZpkri6ck0K7wBgBUr6lnzv7D4H++cJlBQj7xkBWOmX6ulMhNNA0LgG6pFqI9K DWtJU2bA8ts9oe8dV116d9bftKQ/L3rvHlma8SWX3eiGdHpPgrhvssJ5LkWGdk/lCNJT o+pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697017850; x=1697622650; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0mVUc2QYg0Efw6pJNeVz/zFnZzuYD+chiGBHwX1I3EU=; b=QZO+hvlDW7wbM5JHHJ/o+aCtcEk5vb0mYYoNZgaRMJ1UJptm9YMZ8VT9pvs8QwgxrJ zffj8Kpk1qViRvUnIZY/uW+558i8mfVfNsH8m725ww0ltpr/9wOofvtSZPWesdiKbdhT L7XHk8JmiJEpf2U4PcjJVwSf9vMm2WoOJF8KBK0j/WgM5B4aou4Dti5f+3lzeY9nfdZa 0eVV0c/6GvT/1vnpMAuFVHxcDk4OANuRQN/hNbBIYKohy9rVzTzLVBOJCU/k8kh4RyzY jN1jcLt3AMEEI5GEE2g/FxKRjLALRDeHS9mkPmF4s+pbZH0Y8kbWZo3SPb2GrUGOiucg ag2w== X-Gm-Message-State: AOJu0Yx1QrpFc5PMQXjLM4aSWYb9g6F+5w/aZ50Xt54TaR2315L7HCu8 F5cjmByRgAuf8bGAi5aLb3c= X-Google-Smtp-Source: AGHT+IFNQz0jowiTfFKoy4ktg3LWr4m7dz5CZd38yeUNejBMPW+0rRIOapvxpcW4/SO9tEUO6NNmcA== X-Received: by 2002:a17:906:53d2:b0:9ad:e2c8:1741 with SMTP id p18-20020a17090653d200b009ade2c81741mr18143083ejo.58.1697017850247; Wed, 11 Oct 2023 02:50:50 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id gt26-20020a170906f21a00b0099bcf9c2ec6sm9567321ejb.75.2023.10.11.02.50.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Oct 2023 02:50:50 -0700 (PDT) Message-ID: <4fee0881-10c5-4f27-8c24-b0405c1481f6@gmail.com> Date: Wed, 11 Oct 2023 11:50:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: rdapp.gcc@gmail.com, kito.cheng@gmail.com, kito.cheng@sifive.com, jeffreyalaw@gmail.com Subject: Re: [PATCH V2] RISC-V: Fix incorrect index(offset) of gather/scatter Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org References: <20231011093631.2993626-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: <20231011093631.2993626-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Juzhe, good that you noticed it now, I should have caught that in the review back then... One thing, though: > + if (inner_offsize < GET_MODE_BITSIZE (GET_MODE (ptr)).to_constant ()) Shouldn't ptr always be Pmode i.e. the bitsize == XLEN? Rest LGTM. Regards Robin