From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 9FD3C3858C36 for ; Mon, 11 Dec 2023 09:00:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FD3C3858C36 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FD3C3858C36 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702285214; cv=none; b=LBHk2VdSN/PrO181Fs37wuFV5UvGAZbeJaWAU1eFPX2fesmUgkxTVJlgoGWpah7FiUYXLXU1tj2zI/dadRyI6HWvtFr4u7KvIc3yu4/sYRCyv6otTfJl2cMqYkbLxtVu4Ls9VNOGKJZUMgXn+PCP/7m1QftBEHZ8aHkaNl9K8Q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702285214; c=relaxed/simple; bh=plTZMYlyJEwZDsCAfANtXaJ53gnVXl6ClbQt6K9KPBI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=HvDZ0eI88Qsmbyo4czVg32ERvmWJ/99gkF2v1gbkkNECDKQ+xu39SavIuPIvJK839mDPWYUA9ABA4KITUAX0dyeHAAZQt0QNSqiJQtJ4MQvqFpsbXbsvf1+AiNfBC0nDkKgqA2LKnIu3wshcefX4e8VjJt+PpXmdlkN5zGdj0uI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 55A4D22301; Mon, 11 Dec 2023 09:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702285211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wsdjuH1pEhsi3juXWkjDSANop/v4wwwp11T0mLCEvhI=; b=MROZRrYa5Cay1j8YBlba8SWz2IfcKlXXjQfOp8XLqFvrruJbp17KE7wCnfgTrfyHiwvBEd xaET+DuWdfhhMiHvSXluRjTMZlpv6u+VSDd3ou/OzwoVelHQkemQ+rE9UIhuYkO/GbpN01 U/e0rZhMjP8NVr7oKDRbZPxBMvwzkKc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702285211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wsdjuH1pEhsi3juXWkjDSANop/v4wwwp11T0mLCEvhI=; b=Sug4QfrZXR3p6fuVObUeR6gXgawwbPmx07Cpg+vK5G3ganL36gqMX0s7r3ehIVO63H9jo0 h+YfSaGKW/dKUvDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702285211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wsdjuH1pEhsi3juXWkjDSANop/v4wwwp11T0mLCEvhI=; b=MROZRrYa5Cay1j8YBlba8SWz2IfcKlXXjQfOp8XLqFvrruJbp17KE7wCnfgTrfyHiwvBEd xaET+DuWdfhhMiHvSXluRjTMZlpv6u+VSDd3ou/OzwoVelHQkemQ+rE9UIhuYkO/GbpN01 U/e0rZhMjP8NVr7oKDRbZPxBMvwzkKc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702285211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wsdjuH1pEhsi3juXWkjDSANop/v4wwwp11T0mLCEvhI=; b=Sug4QfrZXR3p6fuVObUeR6gXgawwbPmx07Cpg+vK5G3ganL36gqMX0s7r3ehIVO63H9jo0 h+YfSaGKW/dKUvDw== Date: Mon, 11 Dec 2023 09:59:10 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: Alexandre Oliva , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] testsuite: Disable -fstack-protector* for some strub tests In-Reply-To: Message-ID: <4r725or1-8ps4-70r0-ns1p-46pnsnssrrpn@fhfr.qr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Level: X-Spam-Score: -4.30 Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -4.30 X-Spamd-Result: default: False [-4.30 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Flag: NO X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 11 Dec 2023, Jakub Jelinek wrote: > Hi! > > In our distro builds, we test with > RUNTESTFLAGS='--target_board=unix\{,-fstack-protector-strong\}' > because SSP is something we use widely in the distribution. > 4 new strub test FAIL with that option though, as can be > seen with a simple > make check-gcc check-g++ RUNTESTFLAGS='--target_board=unix\{,-fstack-protector-strong\} dg.exp=strub-O*' > - in particular, the expand dump > \[(\]call\[^\n\]*strub_leave.*\n\[(\]code_label > regexps see code_labels in there introduced for stack protector. > > The following patch fixes it by using -fno-stack-protector for these > explicitly. > > Tested on x86_64-linux, ok for trunk? OK. > 2023-12-11 Jakub Jelinek > > * c-c++-common/strub-O2fni.c: Add -fno-stack-protector to dg-options. > * c-c++-common/strub-O3fni.c: Likewise. > * c-c++-common/strub-Os.c: Likewise. > * c-c++-common/strub-Og.c: Likewise. > > --- gcc/testsuite/c-c++-common/strub-O2fni.c.jj 2023-12-08 08:28:23.689170380 +0100 > +++ gcc/testsuite/c-c++-common/strub-O2fni.c 2023-12-11 09:25:49.100792709 +0100 > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O2 -fstrub=strict -fdump-rtl-expand -fno-inline" } */ > +/* { dg-options "-O2 -fstrub=strict -fdump-rtl-expand -fno-inline -fno-stack-protector" } */ > /* { dg-require-effective-target strub } */ > > /* With -fno-inline, none of the strub builtins are inlined. */ > --- gcc/testsuite/c-c++-common/strub-O3fni.c.jj 2023-12-08 08:28:23.707170125 +0100 > +++ gcc/testsuite/c-c++-common/strub-O3fni.c 2023-12-11 09:25:56.388695362 +0100 > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-O3 -fstrub=strict -fdump-rtl-expand -fno-inline" } */ > +/* { dg-options "-O3 -fstrub=strict -fdump-rtl-expand -fno-inline -fno-stack-protector" } */ > /* { dg-require-effective-target strub } */ > > /* With -fno-inline, none of the strub builtins are inlined. */ > --- gcc/testsuite/c-c++-common/strub-Os.c.jj 2023-12-08 08:28:23.707170125 +0100 > +++ gcc/testsuite/c-c++-common/strub-Os.c 2023-12-11 09:26:24.994313267 +0100 > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-Os -fstrub=strict -fdump-rtl-expand" } */ > +/* { dg-options "-Os -fstrub=strict -fdump-rtl-expand -fno-stack-protector" } */ > /* { dg-require-effective-target strub } */ > > /* At -Os, without -fno-inline, we fully expand enter, and also update. The > --- gcc/testsuite/c-c++-common/strub-Og.c.jj 2023-12-08 08:28:23.707170125 +0100 > +++ gcc/testsuite/c-c++-common/strub-Og.c 2023-12-11 09:26:07.077552587 +0100 > @@ -1,5 +1,5 @@ > /* { dg-do compile } */ > -/* { dg-options "-Og -fstrub=strict -fdump-rtl-expand" } */ > +/* { dg-options "-Og -fstrub=strict -fdump-rtl-expand -fno-stack-protector" } */ > /* { dg-require-effective-target strub } */ > > /* At -Og, without -fno-inline, we fully expand enter, but neither update nor > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)