From: Tobias Burnus <burnus@net-b.de>
To: Janus Weil <janus@gcc.gnu.org>
Cc: gfortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, Fortran, F03] PROCEDURE w/ interface: Bogus "EXTERNAL attribute conflicts with FUNCTION attribute"
Date: Mon, 16 Jul 2012 09:23:00 -0000 [thread overview]
Message-ID: <5003DD56.2040100@net-b.de> (raw)
In-Reply-To: <CAKwh3qjcNBnVvoCC1R8nGtqaYEvKZ-srX61L8PE-Yw6b2=FBrg@mail.gmail.com>
On 07/16/2012 11:09 AM, Janus Weil wrote:
> the attached patch is the solution that I came up with for this PR
> (after two simpler but wrong attempts, see PR). The issue addressed
> here is the setting of the if_source attribute for dummy procedures.
> When declaring a procedure (pointer) with the PROCEDURE statement, the
> attributes of the dummies (including if_source) should be copied from
> the source interface (cf. gfc_copy_formal_args).
>
> The patch was successfully regtested on x86_64-unknown-linux-gnu. Ok for trunk?
The patch looks fine. Thanks!
Tobias
> 2012-07-16 Janus Weil <janus@gcc.gnu.org>
>
> PR fortran/53956
> * gfortran.h (gfc_copy_formal_args,gfc_copy_formal_args_ppc): Modified
> prototypes.
> * symbol.c (gfc_copy_formal_args): New argument 'if_src'. Copy if_source
> of dummy procedures.
> (gfc_copy_formal_args_ppc): Ditto.
> * resolve.c (resolve_procedure_interface): Pass IFSRC_DECL to
> gfc_copy_formal_args.
> (resolve_fl_derived0): Pass IFSRC_DECL to gfc_copy_formal_args_ppc.
>
>
> 2012-07-16 Janus Weil <janus@gcc.gnu.org>
>
> PR fortran/53956
> * gfortran.dg/proc_decl_28.f90: New.
next prev parent reply other threads:[~2012-07-16 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 9:09 Janus Weil
2012-07-16 9:23 ` Tobias Burnus [this message]
2012-07-16 10:15 ` Janus Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5003DD56.2040100@net-b.de \
--to=burnus@net-b.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=janus@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).