public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@redhat.com>
To: Arnaud Charlet <charlet@adacore.com>
Cc: gcc-patches@gcc.gnu.org, Vincent Pucci <pucci@adacore.com>
Subject: Re: [Ada] Fix to 64-bit atomic operation failures on ppc-linux
Date: Tue, 17 Jul 2012 15:55:00 -0000	[thread overview]
Message-ID: <50058AE8.8000706@redhat.com> (raw)
In-Reply-To: <20120717101511.GA25996@adacore.com>

On 07/17/2012 03:15 AM, Arnaud Charlet wrote:
> +   function Sync_Compare_And_Swap_32
>       (Ptr      : Address;
>        Expected : uint32;
>        Desired  : uint32) return uint32;
>     pragma Import (Intrinsic,
> +                  Sync_Compare_And_Swap_32,
>                    "__sync_val_compare_and_swap_4");
>  
> +   function Sync_Compare_And_Swap_64
>       (Ptr      : Address;
>        Expected : uint64;
> -      Desired  : uint64) return uint64;
> +      Desired  : uint64) return Boolean;
>     pragma Import (Intrinsic,
> +                  Sync_Compare_And_Swap_64,
> -                  "__sync_val_compare_and_swap_8");
> +                  "__sync_bool_compare_and_swap_8");

Ignoring the name change, why return bool only for the 64-bit function?
This is surely papering over some sort of bug elsewhere...


r~

      parent reply	other threads:[~2012-07-17 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 10:15 Arnaud Charlet
2012-07-17 11:57 ` Andrew MacLeod
2012-07-17 15:57   ` Richard Henderson
2012-07-17 15:59     ` Andrew MacLeod
2012-07-17 15:55 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50058AE8.8000706@redhat.com \
    --to=rth@redhat.com \
    --cc=charlet@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pucci@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).