From: Richard Henderson <rth@redhat.com>
To: DJ Delorie <dj@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: TPF: disable discriminators
Date: Tue, 31 Jul 2012 23:21:00 -0000 [thread overview]
Message-ID: <50186763.70101@redhat.com> (raw)
In-Reply-To: <201207312251.q6VMpU9b021892@greed.delorie.com>
On 2012-07-31 15:51, DJ Delorie wrote:
>> I don't see that 4.6 requires a different patch.
>
> 4.6 is missing this:
>
> 2011-04-01 Richard Henderson <rth@redhat.com>
>
> PR 48400
> * dwarf2out.c (dwarf2out_source_line): Disable discriminators
> in strict mode before dwarf4. Re-order tests to early out
> before switching sections.
>
> So either *that* patch needs to be back-ported, or the tpf-specific
> workaround does.
>
In 4.6 we do not emit discriminators except with DWARF2_ASM_LINE_DEBUG_INFO,
and in that section we have
if (SUPPORTS_DISCRIMINATOR && discriminator != 0
&& (dwarf_version >= 4 || !dwarf_strict))
fprintf (asm_out_file, " discriminator %d", discriminator);
and sure enough dwarf_strict is honored.
That patch is only required if you have the other patches that introduce
discriminators to the non-dwarf2_asm_line path.
r~
prev parent reply other threads:[~2012-07-31 23:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 4:12 DJ Delorie
2012-07-31 16:55 ` Richard Henderson
2012-07-31 21:25 ` DJ Delorie
2012-07-31 22:22 ` Richard Henderson
2012-07-31 22:26 ` DJ Delorie
2012-07-31 22:47 ` Richard Henderson
2012-07-31 23:22 ` DJ Delorie
2012-07-31 23:21 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50186763.70101@redhat.com \
--to=rth@redhat.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).