From: Eric Botcazou <ebotcazou@adacore.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Uros Bizjak <ubizjak@gmail.com>,
Paolo Bonzini <bonzini@gnu.org>,
Richard Henderson <rth@redhat.com>,
Vladimir Yakovlev <vbyakovl23@gmail.com>,
"Kumar, Venkataramanan" <Venkataramanan.Kumar@amd.com>
Subject: Re: [PATCH, dataflow]: Fix PR55845, 454.calculix miscompares on x86 AVX due to movement of vzeroupper
Date: Sun, 06 Jan 2013 16:44:00 -0000 [thread overview]
Message-ID: <50281741.4qfAGM0b1s@polaris> (raw)
In-Reply-To: <20130106162251.GX7269@tucnak.redhat.com>
> BTW, can't UNSPEC_VOLATILE be embedded deeply in the pattern?
> So volatile_insn_p (insn) && asm_noperands (PATTERN (insn)) == -1?
> But perhaps you want to treat that way only UNSPEC_VOLATILE directly in the
> pattern and all other UNSPEC_VOLATILE insns must describe in detail what
> exactly they are changing? This really needs to be better documented.
Yes, I think that we should document that UNSPEC_Vs are full optimization
barriers so the existing blockage insn of all ports are really blockage.
That's already what is implemented and seems non-controversial (unlike the
volatile asms). Something like:
Index: rtl.def
===================================================================
--- rtl.def (revision 194946)
+++ rtl.def (working copy)
@@ -213,7 +213,9 @@ DEF_RTL_EXPR(ASM_OPERANDS, "asm_operands
*/
DEF_RTL_EXPR(UNSPEC, "unspec", "Ei", RTX_EXTRA)
-/* Similar, but a volatile operation and one which may trap. */
+/* Similar, but a volatile operation and one which may trap. Moreover, it's
a
+ full optimization barrier, i.e. no instructions may be moved and no
register
+ (hard or pseudo) or memory equivalences may be used across it. */
DEF_RTL_EXPR(UNSPEC_VOLATILE, "unspec_volatile", "Ei", RTX_EXTRA)
/* Vector of addresses, stored as full words. */
I'd also propose that blockage insns always be UNSPEC_Vs (that's already the
case in practice, but the manual also lists volatile asms).
And I'm somewhat dubious about the distinction between toplevel and embedded
UNSPEC_Vs in a pattern; IMO, that shouldn't make any difference.
--
Eric Botcazou
next prev parent reply other threads:[~2013-01-06 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 15:48 Uros Bizjak
2013-01-06 16:23 ` Jakub Jelinek
2013-01-06 16:44 ` Eric Botcazou [this message]
2013-01-07 16:52 ` Uros Bizjak
2013-01-07 23:26 ` Jakub Jelinek
2013-01-08 7:10 ` Uros Bizjak
2013-01-08 17:55 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50281741.4qfAGM0b1s@polaris \
--to=ebotcazou@adacore.com \
--cc=Venkataramanan.Kumar@amd.com \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rth@redhat.com \
--cc=ubizjak@gmail.com \
--cc=vbyakovl23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).