public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Georg-Johann Lay <avr@gjlay.de>
To: Denis Chertykov <chertykov@gmail.com>
Cc: "Weddington, Eric" <Eric.Weddington@atmel.com>,
	 "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch,AVR] PR54222: Add fixed point support
Date: Mon, 13 Aug 2012 09:28:00 -0000	[thread overview]
Message-ID: <5028C89B.2080407@gjlay.de> (raw)
In-Reply-To: <CADOs=za9iEB59DY5WFHSgSu-PNZ=7rv3zLq1MmQ9RhcGeQu0JA@mail.gmail.com>

Denis Chertykov wrote:
> 2012/8/11 Georg-Johann Lay <avr@gjlay.de>:
>> Weddington, Eric schrieb:
>>>> From: Georg-Johann Lay
>>>>
>>>>
>>>> The first step would be to bisect and find the patch that lead to
>>>> PR53923.  It was not a change in the avr BE, so the question goes
>>>> to the authors of the respective patch.
>>>>
>>>> Up to now I didn't even try to bisect; that would take years on the
>>>> host that I have available...
>>>>
>>>>> My only real concern is that this is a major feature addition and
>>>>> the AVR port is currently broken.
>>>>
>>>> I don't know if it's the avr port or some parts of the middle end that
>>>> don't cooperate with avr.
>>>
>>> I would really, really love to see fixed point support added in,
>>> especially since I know that Sean has worked on it for quite a while,
>>> and you've also done a lot of work in getting the patches in shape to
>>> get them committed.
>>>
>>> But, if the AVR port is currently broken (by whomever, and whatever
>>> patch) and a major feature like this can't be tested to make sure it
>>> doesn't break anything else in the AVR backend, then I'm hesitant to
>>> approve (even though I really want to approve).
>>
>> I don't understand enough of DF to fix PR53923.  The insn that leads
>> to the ICE is (in df-problems.c:dead_debug_insert_temp):
>>
> 
> Today I have updated GCC svn tree and successfully compiled avr-gcc.
> The libgcc2-mulsc3.c from PR53923 also compiled without bugs.
> 
> Denis.
> 
> PS: May be I'm doing something wrong ? (I had too long vacations)

I am configuring with --target=avr --disable-nls --with-dwarf2
--enable-languages=c,c++ --enable-target-optspace=yes --enable-checking=yes,rtl

Build GCC is "gcc version 4.3.2".
Build and host are i686-pc-linux-gnu.

Maybe it's different on a 64-bit computer, but I only have 32-bit host.

Johann

  reply	other threads:[~2012-08-13  9:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10 15:53 Georg-Johann Lay
2012-08-10 16:09 ` Weddington, Eric
2012-08-10 17:06   ` Georg-Johann Lay
2012-08-10 17:56     ` Weddington, Eric
2012-08-10 21:34       ` Georg-Johann Lay
2012-08-12  9:13         ` Denis Chertykov
2012-08-13  9:28           ` Georg-Johann Lay [this message]
2012-08-21 16:10             ` Denis Chertykov
2012-08-23 14:50               ` Georg-Johann Lay
2012-08-23 16:42                 ` Weddington, Eric
2012-08-23 17:25                   ` Georg-Johann Lay
2012-08-24 11:58                 ` Denis Chertykov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5028C89B.2080407@gjlay.de \
    --to=avr@gjlay.de \
    --cc=Eric.Weddington@atmel.com \
    --cc=chertykov@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).