From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21483 invoked by alias); 20 Aug 2012 14:14:22 -0000 Received: (qmail 21408 invoked by uid 22791); 20 Aug 2012 14:14:17 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,TW_TM X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Aug 2012 14:13:58 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 20 Aug 2012 15:13:56 +0100 Received: from [10.1.69.67] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 20 Aug 2012 15:15:44 +0100 Message-ID: <50324622.3020900@arm.com> Date: Mon, 20 Aug 2012 14:14:00 -0000 From: Richard Earnshaw User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Tobias Burnus CC: Andrew Stubbs , "gcc-patches@gcc.gnu.org" , Richard Sandiford Subject: Re: [patch, tree-ssa] PR54295 Incorrect value extension in widening multiply-accumulate References: <502E4F54.9040309@arm.com> <502E53A7.406@codesourcery.com> <502E55CE.6020304@arm.com> <502E57A9.8050502@codesourcery.com> <502E598F.9010105@arm.com> <502E5DE6.8090806@codesourcery.com> <502E612E.60706@arm.com> <502E79BC.3080108@arm.com> <50324345.2070700@net-b.de> In-Reply-To: <50324345.2070700@net-b.de> X-MC-Unique: 112082015135611001 Content-Type: multipart/mixed; boundary="------------000904090601070202030702" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-08/txt/msg01347.txt.bz2 This is a multi-part message in MIME format. --------------000904090601070202030702 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 1283 On 20/08/12 15:01, Tobias Burnus wrote: > Hi Richard, >=20 > your patch fails here; I get the build failure: >=20 > /projects/tob/gcc-git/gcc/gcc/tree-ssa-math-opts.c: In function =E2=80=98= bool=20 > is_widening_mult_rhs_p(tree, tree, tree_node**, tree_node**)=E2=80=99: > /projects/tob/gcc-git/gcc/gcc/tree-ssa-math-opts.c:2014:18: error:=20 > variable =E2=80=98rhs_code=E2=80=99 set but not used [-Werror=3Dunused-bu= t-set-variable] > enum tree_code rhs_code; > ^ >=20 > Tobias >=20 > On 08/17/2012 07:05 PM, Richard Earnshaw wrote: >> --- tree-ssa-math-opts.c (revision 190502) >> +++ tree-ssa-math-opts.c (local) >=20 >> @@ -1982,9 +2019,7 @@ is_widening_mult_rhs_p (tree type, tree >> if (is_gimple_assign (stmt)) >> { >> rhs_code =3D gimple_assign_rhs_code (stmt); >> - if (TREE_CODE (type) =3D=3D INTEGER_TYPE >> - ? !CONVERT_EXPR_CODE_P (rhs_code) >> - : rhs_code !=3D FIXED_CONVERT_EXPR) >> + if (! widening_mult_conversion_strippable_p (type, stmt)) >> rhs1 =3D rhs; >> else >> { >> >=20 >=20 Whoops! Sorry about that. Fixed thusly. Committed as obvious. PR tree-ssa/54295 * tree-ssa-math-opts.c (is_widening_mult_rhs_p): Delete rhs_code declaration and setter. R. --------------000904090601070202030702 Content-Type: text/plain; charset=WINDOWS-1252; name=wmult-warn.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="wmult-warn.patch" Content-length: 777 SW5kZXg6IHRyZWUtc3NhLW1hdGgtb3B0cy5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIHRyZWUtc3NhLW1hdGgtb3B0cy5jCShyZXZpc2lvbiAxOTA1 MzMpCisrKyB0cmVlLXNzYS1tYXRoLW9wdHMuYwkod29ya2luZyBjb3B5KQpA QCAtMjAxMSwxNCArMjAxMSwxMiBAQCBpc193aWRlbmluZ19tdWx0X3Joc19w ICh0cmVlIHR5cGUsIHRyZWUgCiB7CiAgIGdpbXBsZSBzdG10OwogICB0cmVl IHR5cGUxLCByaHMxOwotICBlbnVtIHRyZWVfY29kZSByaHNfY29kZTsKIAog ICBpZiAoVFJFRV9DT0RFIChyaHMpID09IFNTQV9OQU1FKQogICAgIHsKICAg ICAgIHN0bXQgPSBTU0FfTkFNRV9ERUZfU1RNVCAocmhzKTsKICAgICAgIGlm IChpc19naW1wbGVfYXNzaWduIChzdG10KSkKIAl7Ci0JICByaHNfY29kZSA9 IGdpbXBsZV9hc3NpZ25fcmhzX2NvZGUgKHN0bXQpOwogCSAgaWYgKCEgd2lk ZW5pbmdfbXVsdF9jb252ZXJzaW9uX3N0cmlwcGFibGVfcCAodHlwZSwgc3Rt dCkpCiAJICAgIHJoczEgPSByaHM7CiAJICBlbHNlCg== --------------000904090601070202030702--