From: Richard Earnshaw <rearnsha@arm.com>
To: Terry Guo <terry.guo@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch ARM] Update the test case to differ movs and lsrs for ARM mode and non-ARM mode
Date: Wed, 22 Aug 2012 10:06:00 -0000 [thread overview]
Message-ID: <5034AF05.2090905@arm.com> (raw)
In-Reply-To: <000001cd8004$485ab0e0$d91012a0$@guo@arm.com>
On 22/08/12 02:20, Terry Guo wrote:
> Hi,
>
> Due to the impact of ARM UAL, the Thumb1 and Thumb2 mode use LSRS
> instruction while the ARM mode uses MOVS instruction. So the following case
> is updated accordingly. Is it OK to trunk?
>
> BR,
> Terry
>
> 2012-08-21 Terry Guo <terry.guo@arm.com>
>
> * gcc.target/arm/combine-movs.c: Check movs for ARM mode
> and lsrs for other mode.
>
This can't be right. Thumb1 doesn't use unified syntax.
R.
> diff --git a/gcc/testsuite/gcc.target/arm/combine-movs.c
> b/gcc/testsuite/gcc.target/arm/combine-movs.c
> index 4209a33..fbef9df 100644
> --- a/gcc/testsuite/gcc.target/arm/combine-movs.c
> +++ b/gcc/testsuite/gcc.target/arm/combine-movs.c
> @@ -1,5 +1,4 @@
> /* { dg-do compile } */
> -/* { dg-skip-if "" { arm_thumb1 } } */
> /* { dg-options "-O" } */
>
> void foo (unsigned long r[], unsigned int d)
> @@ -9,4 +8,5 @@ void foo (unsigned long r[], unsigned int d)
> r[i] = 0;
> }
>
> -/* { dg-final { scan-assembler "movs\tr\[0-9\]" } } */
> +/* { dg-final { scan-assembler "movs\tr\[0-9\]" { target arm_nothumb } } }
> */
> +/* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target { ! arm_nothumb }
> } } } */
>
>
>
>
next prev parent reply other threads:[~2012-08-22 10:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 1:18 Terry Guo
2012-08-22 10:06 ` Richard Earnshaw [this message]
2012-08-22 11:15 ` Terry Guo
2012-08-22 14:16 ` Richard Earnshaw
2012-09-04 6:02 ` Terry Guo
2012-09-14 10:14 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5034AF05.2090905@arm.com \
--to=rearnsha@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=terry.guo@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).