From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-325047-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 11230 invoked by alias); 22 Aug 2012 10:06:39 -0000
Received: (qmail 11202 invoked by uid 22791); 22 Aug 2012 10:06:37 -0000
X-SWARE-Spam-Status: No, hits=-0.2 required=5.0	tests=AWL,BAYES_50,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 22 Aug 2012 10:06:05 +0000
Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Wed, 22 Aug 2012 11:05:58 +0100
Received: from [10.1.69.67] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959);	 Wed, 22 Aug 2012 11:07:49 +0100
Message-ID: <5034AF05.2090905@arm.com>
Date: Wed, 22 Aug 2012 10:06:00 -0000
From: Richard Earnshaw <rearnsha@arm.com>
User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: Terry Guo <terry.guo@arm.com>
CC: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch ARM] Update the test case to differ movs and lsrs for ARM mode and non-ARM mode
References: <000001cd8004$485ab0e0$d91012a0$@guo@arm.com>
In-Reply-To: <000001cd8004$485ab0e0$d91012a0$@guo@arm.com>
X-MC-Unique: 112082211055802701
Content-Type: text/plain; charset=WINDOWS-1252
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-08/txt/msg01483.txt.bz2

On 22/08/12 02:20, Terry Guo wrote:
> Hi,
>=20
> Due to the impact of ARM UAL, the Thumb1 and Thumb2 mode use LSRS
> instruction while the ARM mode uses MOVS instruction. So the following ca=
se
> is updated accordingly. Is it OK to trunk?
>=20
> BR,
> Terry
>=20
> 2012-08-21  Terry Guo  <terry.guo@arm.com>
>=20
>         * gcc.target/arm/combine-movs.c: Check movs for ARM mode=20
>         and lsrs for other mode.
>=20

This can't be right.  Thumb1 doesn't use unified syntax.

R.

> diff --git a/gcc/testsuite/gcc.target/arm/combine-movs.c
> b/gcc/testsuite/gcc.target/arm/combine-movs.c
> index 4209a33..fbef9df 100644
> --- a/gcc/testsuite/gcc.target/arm/combine-movs.c
> +++ b/gcc/testsuite/gcc.target/arm/combine-movs.c
> @@ -1,5 +1,4 @@
>  /* { dg-do compile } */
> -/* { dg-skip-if "" { arm_thumb1 } } */
>  /* { dg-options "-O" }  */
>=20
>  void foo (unsigned long r[], unsigned int d)
> @@ -9,4 +8,5 @@ void foo (unsigned long r[], unsigned int d)
>      r[i] =3D 0;
>  }
>=20
> -/* { dg-final { scan-assembler "movs\tr\[0-9\]" } } */
> +/* { dg-final { scan-assembler "movs\tr\[0-9\]" { target arm_nothumb } }=
 }
> */
> +/* { dg-final { scan-assembler "lsrs\tr\[0-9\]" { target { ! arm_nothumb=
 }
> } } } */
>=20
>=20
>=20
>=20