public inbox for
 help / color / mirror / Atom feed
From: Mikael Morin <>
To: Bernhard Reutner-Fischer <>
	Bernhard Reutner-Fischer <>,
	gfortran ML <>
Subject: Re: [PATCH 1/2] Fortran: Cleanup struct ext_attr_t
Date: Tue, 22 Nov 2022 12:52:48 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20221121213410.79ae5601@nbbrfq>

Le 21/11/2022 à 21:34, Bernhard Reutner-Fischer a écrit :
> On Mon, 21 Nov 2022 12:08:20 +0100
> Mikael Morin <> wrote:
>>> 	* gfortran.h (struct ext_attr_t): Remove middle_end_name.
>>> 	* (add_attributes_to_decl): Move building
>>> 	tree_list to ...
>>> 	* (gfc_match_gcc_attributes): ... here. Add the attribute to
>>> 	the tree_list for the middle end.
>> I prefer to not do any middle-end stuff at parsing time, so I would
>> rather not do this change.
>> Not OK.
> Ok, that means we should filter-out those bits that we don't want to
> write to the module (right?). We've plenty of bits left, more than Dave
> Love would want to have added, i hope, so that should not be much of a
> concern.
I didn't think of modules.  Yes, that means we have to store (in memory) 
the attribute we have parsed, and we can filter-out the attributes at 
the time the attributes are written to the module.  I don't think it is 
strictly necessary (for flatten, at least) though.

> What that table really wants to say is whether or not this attribute
> should be passed to the ME. Would it be acceptable to remove these
> duplicate strings and just have a bool/char/int that is true if it
> should be lowered (in trans-decl, as before)? But now i admit it's just
> bikeshedding and we can as well leave it alone for now.. It was just a
> though.
Yes, that would be acceptable.

  reply	other threads:[~2022-11-22 11:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 10:20 [PATCH 0/2] Fortran: Add attribute flatten Bernhard Reutner-Fischer
2022-11-10 10:20 ` [PATCH 1/2] Fortran: Cleanup struct ext_attr_t Bernhard Reutner-Fischer
2022-11-21 11:08   ` Mikael Morin
2022-11-21 20:34     ` Bernhard Reutner-Fischer
2022-11-22 11:52       ` Mikael Morin [this message]
2022-11-10 10:20 ` [PATCH 2/2] Fortran: Add attribute flatten Bernhard Reutner-Fischer
2022-11-21 11:24   ` Mikael Morin
2022-11-21 20:13     ` Bernhard Reutner-Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).