Re: [PATCH 9/9] Remove alias set comparison.

[Martin Sebor <msebor@gmail.com>]

On 8/8/19 2:14 AM, Martin Liška wrote:
> On 8/7/19 5:20 PM, Martin Sebor wrote:
>> On 6/11/19 1:36 AM, Martin Liska wrote:
>>>
>>> gcc/ChangeLog:
>>>
>>> 2019-07-24  Martin Liska  <mliska@suse.cz>
>>>
>>>      * ipa-icf-gimple.c (func_checker::compatible_types_p):
>>>      Do not compare alias sets.  It's handled by operand_equal_p.
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 2019-07-24  Martin Liska  <mliska@suse.cz>
>>>
>>>      * c-c++-common/Wstringop-truncation-4.c: Disable IPA ICF.
>>
>> What fails without the change?
> 
> ICF will newly merge these functions:

I see.  I suppose the other alternatives are to either add
attribute noipa to the functions or make unique the string
each function copies so they can't be merged.

I have a mild preference for the last alternative but it's
your call.  If you decide to keep the option can you please
add a brief comment explaining why it's needed?

Thanks
Martin

> 
> grep hit: Wstringop-truncation-4.c.070i.icf
> Semantic equality hit:void test_arrays(Arrays*, const char*)->void test_const_arrays(ConstArrays*, const char*)
> Semantic equality hit:void test_arrays(Arrays*, const char*)->void test_volatile_arrays(VolatileArrays*, const char*)
> Semantic equality hit:void test_arrays(Arrays*, const char*)->void test_const_volatile_arrays(ConstVolatileArrays*, const char*)
> 
> So we'll get less warnings than expected.
> 
> Martin
> 
>>
>> Thanks
>> Martin
>>
>>>      * gcc.dg/tree-ssa/pr64910-2.c: Likewise.
>>>      * gcc.dg/tree-ssa/pr79352.c: Likewise.
>>>      * gcc.dg/ipa/ipa-icf-40.c: New test.
>>> ---
>>>    gcc/ipa-icf-gimple.c                          | 12 -------
>>>    .../c-c++-common/Wstringop-truncation-4.c     |  2 +-
>>>    gcc/testsuite/gcc.dg/ipa/ipa-icf-40.c         | 32 +++++++++++++++++++
>>>    gcc/testsuite/gcc.dg/tree-ssa/pr64910-2.c     |  2 +-
>>>    gcc/testsuite/gcc.dg/tree-ssa/pr79352.c       |  2 +-
>>>    5 files changed, 35 insertions(+), 15 deletions(-)
>>>    create mode 100644 gcc/testsuite/gcc.dg/ipa/ipa-icf-40.c
>>>
>>
>