* [wwwdocs] Add no_sanitize attribute
@ 2018-04-18 12:22 Martin Liška
2018-04-27 23:26 ` Jeff Law
2018-10-07 12:53 ` Gerald Pfeifer
0 siblings, 2 replies; 6+ messages in thread
From: Martin Liška @ 2018-04-18 12:22 UTC (permalink / raw)
To: GCC Patches; +Cc: Gerald Pfeifer
[-- Attachment #1: Type: text/plain, Size: 64 bytes --]
I would like to mention the attribute in GCC 8 changes.
Martin
[-- Attachment #2: add-no_sanitize-attribute.patch --]
[-- Type: text/x-patch, Size: 696 bytes --]
Index: htdocs/gcc-8/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.67
diff -r1.67 changes.html
255a256,266
> <li>
> New <code>no_sanitize</code> attribute has been added. The attribute
> on functions is used to inform the compiler that it should
> not do sanitization of all options mentioned in sanitize option.
> A list of values acceptable by <code>-fsanitize</code> option can be
> provided.
> <blockquote><pre>
> void __attribute__ ((no_sanitize ("alignment", "object-size")))
> f () { /* Do something. */; }
> </pre></blockquote>
> </li>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [wwwdocs] Add no_sanitize attribute
2018-04-18 12:22 [wwwdocs] Add no_sanitize attribute Martin Liška
@ 2018-04-27 23:26 ` Jeff Law
2018-10-07 12:53 ` Gerald Pfeifer
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Law @ 2018-04-27 23:26 UTC (permalink / raw)
To: Martin Liška, GCC Patches; +Cc: Gerald Pfeifer
On 04/18/2018 06:22 AM, Martin Liška wrote:
> I would like to mention the attribute in GCC 8 changes.
OK.
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [wwwdocs] Add no_sanitize attribute
2018-04-18 12:22 [wwwdocs] Add no_sanitize attribute Martin Liška
2018-04-27 23:26 ` Jeff Law
@ 2018-10-07 12:53 ` Gerald Pfeifer
2018-10-07 19:37 ` Sandra Loosemore
2018-10-08 8:49 ` Martin Liška
1 sibling, 2 replies; 6+ messages in thread
From: Gerald Pfeifer @ 2018-10-07 12:53 UTC (permalink / raw)
To: Martin Liška, Sandra Loosemore; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 2038 bytes --]
On Wed, 18 Apr 2018, Martin Liška wrote:
> I would like to mention the attribute in GCC 8 changes.
Index: htdocs/gcc-8/changes.html
===================================================================
> <li>
> New <code>no_sanitize</code> attribute has been added. The attribute
> on functions is used to inform the compiler that it should
> not do sanitization of all options mentioned in sanitize option.
> A list of values acceptable by <code>-fsanitize</code> option can be
> provided.
> <blockquote><pre>
> void __attribute__ ((no_sanitize ("alignment", "object-size")))
> f () { /* Do something. */; }
> </pre></blockquote>
> </li>
I've been struggling with this from a language perspective and
while not fully happy, believe/hope the below may improve things
a bit.
Sandra, any recommendations from your end?
Martin, is my update technically acurate?
Index: gcc-8/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.97
diff -u -r1.97 changes.html
--- gcc-8/changes.html 30 Sep 2018 14:38:54 -0000 1.97
+++ gcc-8/changes.html 7 Oct 2018 12:13:03 -0000
@@ -251,11 +251,10 @@
tests for pointer wrapping.
</li>
<li>
- New <code>no_sanitize</code> attribute has been added. The attribute
- on functions is used to inform the compiler that it should
- not do sanitization of all options mentioned in sanitize option.
- A list of values acceptable by <code>-fsanitize</code> option can be
- provided.
+ A new attribute <code>no_sanitize</code> can be applied to functions
+ to instruct the compiler not to do sanitization of any of the options
+ specified. Acceptable values for <code>no_sanitize</code> match those
+ acceptable by the <code>-fsanitize</code> command-line option.
<blockquote><pre class="blackbg">
void __attribute__ ((no_sanitize ("alignment", "object-size")))
f () { /* Do something. */; }</pre></blockquote>
Gerald
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [wwwdocs] Add no_sanitize attribute
2018-10-07 12:53 ` Gerald Pfeifer
@ 2018-10-07 19:37 ` Sandra Loosemore
2018-10-08 8:49 ` Martin Liška
1 sibling, 0 replies; 6+ messages in thread
From: Sandra Loosemore @ 2018-10-07 19:37 UTC (permalink / raw)
To: Gerald Pfeifer, Martin Liška; +Cc: gcc-patches
On 10/07/2018 06:15 AM, Gerald Pfeifer wrote:
> On Wed, 18 Apr 2018, Martin Liška wrote:
>> I would like to mention the attribute in GCC 8 changes.
>
> Index: htdocs/gcc-8/changes.html
> ===================================================================
>> <li>
>> New <code>no_sanitize</code> attribute has been added. The attribute
>> on functions is used to inform the compiler that it should
>> not do sanitization of all options mentioned in sanitize option.
>> A list of values acceptable by <code>-fsanitize</code> option can be
>> provided.
>> <blockquote><pre>
>> void __attribute__ ((no_sanitize ("alignment", "object-size")))
>> f () { /* Do something. */; }
>> </pre></blockquote>
>> </li>
>
> I've been struggling with this from a language perspective and
> while not fully happy, believe/hope the below may improve things
> a bit.
>
> Sandra, any recommendations from your end?
>
> Martin, is my update technically acurate?
>
> Index: gcc-8/changes.html
> ===================================================================
> RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
> retrieving revision 1.97
> diff -u -r1.97 changes.html
> --- gcc-8/changes.html 30 Sep 2018 14:38:54 -0000 1.97
> +++ gcc-8/changes.html 7 Oct 2018 12:13:03 -0000
> @@ -251,11 +251,10 @@
> tests for pointer wrapping.
> </li>
> <li>
> - New <code>no_sanitize</code> attribute has been added. The attribute
> - on functions is used to inform the compiler that it should
> - not do sanitization of all options mentioned in sanitize option.
> - A list of values acceptable by <code>-fsanitize</code> option can be
> - provided.
> + A new attribute <code>no_sanitize</code> can be applied to functions
> + to instruct the compiler not to do sanitization of any of the options
> + specified. Acceptable values for <code>no_sanitize</code> match those
> + acceptable by the <code>-fsanitize</code> command-line option.
> <blockquote><pre class="blackbg">
> void __attribute__ ((no_sanitize ("alignment", "object-size")))
> f () { /* Do something. */; }</pre></blockquote>
>
This is definitely an improvement. One more tweak I'd make is
s/any of the options specified/the options provided as arguments to the
attribute/
-Sandra
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [wwwdocs] Add no_sanitize attribute
2018-10-07 12:53 ` Gerald Pfeifer
2018-10-07 19:37 ` Sandra Loosemore
@ 2018-10-08 8:49 ` Martin Liška
2018-12-29 23:41 ` Gerald Pfeifer
1 sibling, 1 reply; 6+ messages in thread
From: Martin Liška @ 2018-10-08 8:49 UTC (permalink / raw)
To: Gerald Pfeifer, Sandra Loosemore; +Cc: gcc-patches
On 10/7/18 2:15 PM, Gerald Pfeifer wrote:
> On Wed, 18 Apr 2018, Martin Liška wrote:
>> I would like to mention the attribute in GCC 8 changes.
>
> Index: htdocs/gcc-8/changes.html
> ===================================================================
>> <li>
>> New <code>no_sanitize</code> attribute has been added. The attribute
>> on functions is used to inform the compiler that it should
>> not do sanitization of all options mentioned in sanitize option.
>> A list of values acceptable by <code>-fsanitize</code> option can be
>> provided.
>> <blockquote><pre>
>> void __attribute__ ((no_sanitize ("alignment", "object-size")))
>> f () { /* Do something. */; }
>> </pre></blockquote>
>> </li>
>
> I've been struggling with this from a language perspective and
> while not fully happy, believe/hope the below may improve things
> a bit.
>
> Sandra, any recommendations from your end?
>
> Martin, is my update technically acurate?
Hi.
Yes, it's equivalent, thanks for the improvement.
Martin
>
> Index: gcc-8/changes.html
> ===================================================================
> RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
> retrieving revision 1.97
> diff -u -r1.97 changes.html
> --- gcc-8/changes.html 30 Sep 2018 14:38:54 -0000 1.97
> +++ gcc-8/changes.html 7 Oct 2018 12:13:03 -0000
> @@ -251,11 +251,10 @@
> tests for pointer wrapping.
> </li>
> <li>
> - New <code>no_sanitize</code> attribute has been added. The attribute
> - on functions is used to inform the compiler that it should
> - not do sanitization of all options mentioned in sanitize option.
> - A list of values acceptable by <code>-fsanitize</code> option can be
> - provided.
> + A new attribute <code>no_sanitize</code> can be applied to functions
> + to instruct the compiler not to do sanitization of any of the options
> + specified. Acceptable values for <code>no_sanitize</code> match those
> + acceptable by the <code>-fsanitize</code> command-line option.
> <blockquote><pre class="blackbg">
> void __attribute__ ((no_sanitize ("alignment", "object-size")))
> f () { /* Do something. */; }</pre></blockquote>
>
> Gerald
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [wwwdocs] Add no_sanitize attribute
2018-10-08 8:49 ` Martin Liška
@ 2018-12-29 23:41 ` Gerald Pfeifer
0 siblings, 0 replies; 6+ messages in thread
From: Gerald Pfeifer @ 2018-12-29 23:41 UTC (permalink / raw)
To: Sandra Loosemore, Martin Liška; +Cc: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 1578 bytes --]
On Sun, 7 Oct 2018, Sandra Loosemore wrote:
> This is definitely an improvement. One more tweak I'd make is
>
> s/any of the options specified/the options provided as arguments to the
> attribute/
Thank you, Sandra. I made that additional change.
On Mon, 8 Oct 2018, Martin Liška wrote:
> Yes, it's equivalent, thanks for the improvement.
Thanks for the reviews. I (finally) applied this per the patch below;
sorry for the delay.
Gerald
Index: changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.97
diff -u -r1.97 changes.html
--- changes.html 30 Sep 2018 14:38:54 -0000 1.97
+++ changes.html 29 Dec 2018 21:08:04 -0000
@@ -251,11 +251,11 @@
tests for pointer wrapping.
</li>
<li>
- New <code>no_sanitize</code> attribute has been added. The attribute
- on functions is used to inform the compiler that it should
- not do sanitization of all options mentioned in sanitize option.
- A list of values acceptable by <code>-fsanitize</code> option can be
- provided.
+ A new attribute <code>no_sanitize</code> can be applied to functions
+ to instruct the compiler not to do sanitization of the options
+ provided as arguments to the attribute. Acceptable values for
+ <code>no_sanitize</code> match those acceptable by the
+ <code>-fsanitize</code> command-line option.
<blockquote><pre class="blackbg">
void __attribute__ ((no_sanitize ("alignment", "object-size")))
f () { /* Do something. */; }</pre></blockquote>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-29 21:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-18 12:22 [wwwdocs] Add no_sanitize attribute Martin Liška
2018-04-27 23:26 ` Jeff Law
2018-10-07 12:53 ` Gerald Pfeifer
2018-10-07 19:37 ` Sandra Loosemore
2018-10-08 8:49 ` Martin Liška
2018-12-29 23:41 ` Gerald Pfeifer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).