From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17949 invoked by alias); 8 Oct 2012 20:05:56 -0000 Received: (qmail 17941 invoked by uid 22791); 8 Oct 2012 20:05:55 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from outpost1.zedat.fu-berlin.de (HELO outpost1.zedat.fu-berlin.de) (130.133.4.66) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 08 Oct 2012 20:05:48 +0000 Received: from relay1.zedat.fu-berlin.de ([130.133.4.67]) by outpost1.zedat.fu-berlin.de (Exim 4.69) with esmtp (envelope-from ) id <1TLJaE-003faD-FK>; Mon, 08 Oct 2012 22:05:46 +0200 Received: from squeeze64.physik.fu-berlin.de ([160.45.66.239] helo=tux.net-b.de) by relay1.zedat.fu-berlin.de (Exim 4.69) with esmtp (envelope-from ) id <1TLJa8-000tkF-9u>; Mon, 08 Oct 2012 22:05:46 +0200 Message-ID: <50733211.5030602@net-b.de> Date: Mon, 08 Oct 2012 20:05:00 -0000 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120825 Thunderbird/15.0 MIME-Version: 1.0 To: gcc-patches Subject: Small cleanup/memory leak plugs for lto Content-Type: multipart/mixed; boundary="------------030809080806040103080902" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-10/txt/msg00810.txt.bz2 This is a multi-part message in MIME format. --------------030809080806040103080902 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Content-length: 548 Some more issues found by Coverity scanner. lto-cgraph.c: The code seems to be unused, besides, it's a zero-trip loop as parm_num is set to 0 and then checked non nonzeroness. lto-opts: The check whether first_p is non NULL is always false: All calls have a variable ref as argument - and first_p is unconditionally dereferenced. lto_obj_file_open: One could check additionally check "lo" is NULL, but that has then to be directly after the XCNEW as already lto_file_init dereferences "lo". Build and regtested on x86-64-gnu-linux Tobias --------------030809080806040103080902 Content-Type: application/unknown; name="patch.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch.diff" Content-length: 7939 Z2NjLwoyMDEyLTEwLTA4ICBUb2JpYXMgQnVybnVzICA8YnVybnVzQG5ldC1i LmRlPgoKCSogbHRvLWNncmFwaC5jIChpbnB1dF9ub2RlX29wdF9zdW1tYXJ5 KTogUmVtb3ZlIHVudXNlZCBjb2RlLgoJKiBsdG8tb3B0cy5jIChhcHBlbmRf dG9fY29sbGVjdF9nY2Nfb3B0aW9ucyk6IERpdHRvLgoJKiBsdG8tc3ltdGFi LmMgKGx0b19jZ3JhcGhfcmVwbGFjZV9ub2RlKTogRG9uJ3QgeHN0cmR1cCBz dHJpbmcKCXdoaWNoIGlzIHBhc3NlZCB0byBmcHJpbnRmLgoKZ2NjL2x0by8K MjAxMi0xMC0wOCAgVG9iaWFzIEJ1cm51cyAgPGJ1cm51c0BuZXQtYi5kZT4K CgkqIGx0by1sYW5nLmMgKGx0b19yZWdpc3Rlcl9idWlsdGluX3R5cGUpOiBB dm9pZCB1c2VsZXNzCglkZWNsIGNyZWF0aW9uLgoJKiBsdG8tb2JqZWN0LmMg KGx0b19vYmpfZmlsZV9vcGVuLCBsdG9fb2JqX2ZpbGVfb3Blbik6IEZyZWUg bWVtb3J5LgoKZGlmZiAtLWdpdCBhL2djYy9sdG8tY2dyYXBoLmMgYi9nY2Mv bHRvLWNncmFwaC5jCmluZGV4IDRmOTUyZjUuLmIyM2YxOTIgMTAwNjQ0Ci0t LSBhL2djYy9sdG8tY2dyYXBoLmMKKysrIGIvZ2NjL2x0by1jZ3JhcGguYwpA QCAtMTUxMCwyOCArMTUxMCwyMyBAQCBpbnB1dF9ub2RlX29wdF9zdW1tYXJ5 IChzdHJ1Y3QgY2dyYXBoX25vZGUgKm5vZGUsCiAgIGlmIChjb3VudCkKICAg ICBub2RlLT5jbG9uZS5jb21iaW5lZF9hcmdzX3RvX3NraXAgPSBCSVRNQVBf R0dDX0FMTE9DICgpOwogICBmb3IgKGkgPSAwOyBpIDwgY291bnQ7IGkrKykK ICAgICB7CiAgICAgICBiaXQgPSBzdHJlYW1lcl9yZWFkX3Vod2kgKGliX21h aW4pOwogICAgICAgYml0bWFwX3NldF9iaXQgKG5vZGUtPmNsb25lLmNvbWJp bmVkX2FyZ3NfdG9fc2tpcCwgYml0KTsKICAgICB9CiAgIGNvdW50ID0gc3Ry ZWFtZXJfcmVhZF91aHdpIChpYl9tYWluKTsKICAgZm9yIChpID0gMDsgaSA8 IGNvdW50OyBpKyspCiAgICAgewotICAgICAgaW50IHBhcm1fbnVtOwotICAg ICAgdHJlZSBwYXJtOwogICAgICAgc3RydWN0IGlwYV9yZXBsYWNlX21hcCAq bWFwID0gZ2djX2FsbG9jX2lwYV9yZXBsYWNlX21hcCAoKTsKIAogICAgICAg VkVDX3NhZmVfcHVzaCAoaXBhX3JlcGxhY2VfbWFwX3AsIGdjLCBub2RlLT5j bG9uZS50cmVlX21hcCwgbWFwKTsKLSAgICAgIGZvciAocGFybV9udW0gPSAw LCBwYXJtID0gREVDTF9BUkdVTUVOVFMgKG5vZGUtPnN5bWJvbC5kZWNsKTsg cGFybV9udW07Ci0JICAgcGFybSA9IERFQ0xfQ0hBSU4gKHBhcm0pKQotCXBh cm1fbnVtIC0tOwogICAgICAgbWFwLT5wYXJtX251bSA9IHN0cmVhbWVyX3Jl YWRfdWh3aSAoaWJfbWFpbik7CiAgICAgICBtYXAtPm9sZF90cmVlID0gTlVM TDsKICAgICAgIG1hcC0+bmV3X3RyZWUgPSBzdHJlYW1fcmVhZF90cmVlIChp Yl9tYWluLCBkYXRhX2luKTsKICAgICAgIGJwID0gc3RyZWFtZXJfcmVhZF9i aXRwYWNrIChpYl9tYWluKTsKICAgICAgIG1hcC0+cmVwbGFjZV9wID0gYnBf dW5wYWNrX3ZhbHVlICgmYnAsIDEpOwogICAgICAgbWFwLT5yZWZfcCA9IGJw X3VucGFja192YWx1ZSAoJmJwLCAxKTsKICAgICB9CiAgIGZvciAoZSA9IG5v ZGUtPmNhbGxlZXM7IGU7IGUgPSBlLT5uZXh0X2NhbGxlZSkKICAgICBpbnB1 dF9lZGdlX29wdF9zdW1tYXJ5IChlLCBpYl9tYWluKTsKICAgZm9yIChlID0g bm9kZS0+aW5kaXJlY3RfY2FsbHM7IGU7IGUgPSBlLT5uZXh0X2NhbGxlZSkK ZGlmZiAtLWdpdCBhL2djYy9sdG8tb3B0cy5jIGIvZ2NjL2x0by1vcHRzLmMK aW5kZXggNjY4YTVjZS4uODQ4NDQyMyAxMDA2NDQKLS0tIGEvZ2NjL2x0by1v cHRzLmMKKysrIGIvZ2NjL2x0by1vcHRzLmMKQEAgLTM3LDIyICszNywyMCBA QCBhbG9uZyB3aXRoIEdDQzsgc2VlIHRoZSBmaWxlIENPUFlJTkczLiAgSWYg bm90IHNlZQogCiAvKiBBcHBlbmQgdGhlIG9wdGlvbiBwaWVjZSBPUFQgdG8g dGhlIENPTExFQ1RfR0NDX09QVElPTlMgc3RyaW5nCiAgICBzZXQgdXAgYnkg T0IsIGFwcHJvcHJpYXRlbHkgcXVvdGVkIGFuZCBzZXBhcmF0ZWQgYnkgc3Bh Y2VzCiAgICAoaWYgISpGSVJTVF9QKS4gICovCiAKIHN0YXRpYyB2b2lkCiBh cHBlbmRfdG9fY29sbGVjdF9nY2Nfb3B0aW9ucyAoc3RydWN0IG9ic3RhY2sg Km9iLAogCQkJICAgICAgIGJvb2wgKmZpcnN0X3AsIGNvbnN0IGNoYXIgKm9w dCkKIHsKICAgY29uc3QgY2hhciAqcCwgKnEgPSBvcHQ7Ci0gIGlmICghZmly c3RfcCkKLSAgICBvYnN0YWNrX2dyb3cgKG9iLCAiICIsIDEpOwogICBvYnN0 YWNrX2dyb3cgKG9iLCAiJyIsIDEpOwogICB3aGlsZSAoKHAgPSBzdHJjaHIg KHEsICdcJycpKSkKICAgICB7CiAgICAgICBvYnN0YWNrX2dyb3cgKG9iLCBx LCBwIC0gcSk7CiAgICAgICBvYnN0YWNrX2dyb3cgKG9iLCAiJ1xcJyciLCA0 KTsKICAgICAgIHEgPSArK3A7CiAgICAgfQogICBvYnN0YWNrX2dyb3cgKG9i LCBxLCBzdHJsZW4gKHEpKTsKICAgb2JzdGFja19ncm93IChvYiwgIiciLCAx KTsKICAgKmZpcnN0X3AgPSBmYWxzZTsKZGlmZiAtLWdpdCBhL2djYy9sdG8t c3ltdGFiLmMgYi9nY2MvbHRvLXN5bXRhYi5jCmluZGV4IDI1YzBiMjIuLjY1 OWE2OGIgMTAwNjQ0Ci0tLSBhL2djYy9sdG8tc3ltdGFiLmMKKysrIGIvZ2Nj L2x0by1zeW10YWIuYwpAQCAtMzksMjIgKzM5LDIyIEBAIHN0YXRpYyB2b2lk CiBsdG9fY2dyYXBoX3JlcGxhY2Vfbm9kZSAoc3RydWN0IGNncmFwaF9ub2Rl ICpub2RlLAogCQkJIHN0cnVjdCBjZ3JhcGhfbm9kZSAqcHJldmFpbGluZ19u b2RlKQogewogICBzdHJ1Y3QgY2dyYXBoX2VkZ2UgKmUsICpuZXh0OwogICBi b29sIGNvbXBhdGlibGVfcDsKIAogICBpZiAoY2dyYXBoX2R1bXBfZmlsZSkK ICAgICB7CiAgICAgICBmcHJpbnRmIChjZ3JhcGhfZHVtcF9maWxlLCAiUmVw bGFjaW5nIGNncmFwaCBub2RlICVzLyVpIGJ5ICVzLyVpIgogIAkgICAgICAg IiBmb3Igc3ltYm9sICVzXG4iLAotCSAgICAgICB4c3RyZHVwIChjZ3JhcGhf bm9kZV9uYW1lIChub2RlKSksIG5vZGUtPnVpZCwKLQkgICAgICAgeHN0cmR1 cCAoY2dyYXBoX25vZGVfbmFtZSAocHJldmFpbGluZ19ub2RlKSksCisJICAg ICAgIGNncmFwaF9ub2RlX25hbWUgKG5vZGUpLCBub2RlLT51aWQsCisJICAg ICAgIGNncmFwaF9ub2RlX25hbWUgKHByZXZhaWxpbmdfbm9kZSksCiAJICAg ICAgIHByZXZhaWxpbmdfbm9kZS0+dWlkLAogCSAgICAgICBJREVOVElGSUVS X1BPSU5URVIgKCgqdGFyZ2V0bS5hc21fb3V0Lm1hbmdsZV9hc3NlbWJsZXJf bmFtZSkKIAkJIChJREVOVElGSUVSX1BPSU5URVIgKERFQ0xfQVNTRU1CTEVS X05BTUUgKG5vZGUtPnN5bWJvbC5kZWNsKSkpKSk7CiAgICAgfQogCiAgIC8q IE1lcmdlIG5vZGUgZmxhZ3MuICAqLwogICBpZiAobm9kZS0+c3ltYm9sLmZv cmNlX291dHB1dCkKICAgICBjZ3JhcGhfbWFya19mb3JjZV9vdXRwdXRfbm9k ZSAocHJldmFpbGluZ19ub2RlKTsKICAgaWYgKG5vZGUtPnN5bWJvbC5hZGRy ZXNzX3Rha2VuKQogICAgIHsKZGlmZiAtLWdpdCBhL2djYy9sdG8vbHRvLWxh bmcuYyBiL2djYy9sdG8vbHRvLWxhbmcuYwppbmRleCAyODBkODgzLi5lZGZh Yjc0IDEwMDY0NAotLS0gYS9nY2MvbHRvL2x0by1sYW5nLmMKKysrIGIvZ2Nj L2x0by9sdG8tbGFuZy5jCkBAIC0xMDcyLDI0ICsxMDcyLDI3IEBAIHN0YXRp YyB0cmVlCiBsdG9fYnVpbHRpbl9mdW5jdGlvbiAodHJlZSBkZWNsKQogewog ICByZXR1cm4gZGVjbDsKIH0KIAogc3RhdGljIHZvaWQKIGx0b19yZWdpc3Rl cl9idWlsdGluX3R5cGUgKHRyZWUgdHlwZSwgY29uc3QgY2hhciAqbmFtZSkK IHsKICAgdHJlZSBkZWNsOwogCi0gIGRlY2wgPSBidWlsZF9kZWNsIChVTktO T1dOX0xPQ0FUSU9OLCBUWVBFX0RFQ0wsIGdldF9pZGVudGlmaWVyIChuYW1l KSwgdHlwZSk7Ci0gIERFQ0xfQVJUSUZJQ0lBTCAoZGVjbCkgPSAxOwogICBp ZiAoIVRZUEVfTkFNRSAodHlwZSkpCi0gICAgVFlQRV9OQU1FICh0eXBlKSA9 IGRlY2w7CisgICAgeworICAgICAgZGVjbCA9IGJ1aWxkX2RlY2wgKFVOS05P V05fTE9DQVRJT04sIFRZUEVfREVDTCwKKwkJCSBnZXRfaWRlbnRpZmllciAo bmFtZSksIHR5cGUpOworICAgICAgREVDTF9BUlRJRklDSUFMIChkZWNsKSA9 IDE7CisgICAgICBUWVBFX05BTUUgKHR5cGUpID0gZGVjbDsKKyAgICB9CiAK ICAgcmVnaXN0ZXJlZF9idWlsdGluX3R5cGVzID0gdHJlZV9jb25zICgwLCB0 eXBlLCByZWdpc3RlcmVkX2J1aWx0aW5fdHlwZXMpOwogfQogCiAvKiBCdWls ZCBub2RlcyB0aGF0IHdvdWxkIGhhdmUgYmUgY3JlYXRlZCBieSB0aGUgQyBm cm9udC1lbmQ7IG5lY2Vzc2FyeQogICAgZm9yIGluY2x1ZGluZyBidWlsdGlu LXR5cGVzLmRlZiBhbmQgdWx0aW1hdGVseSBidWlsdGlucy5kZWYuICAqLwog CiBzdGF0aWMgdm9pZAogbHRvX2J1aWxkX2NfdHlwZV9ub2RlcyAodm9pZCkK IHsKZGlmZiAtLWdpdCBhL2djYy9sdG8vbHRvLW9iamVjdC5jIGIvZ2NjL2x0 by9sdG8tb2JqZWN0LmMKaW5kZXggZGFmM2JkMC4uY2UyNDQwMCAxMDA2NDQK LS0tIGEvZ2NjL2x0by9sdG8tb2JqZWN0LmMKKysrIGIvZ2NjL2x0by9sdG8t b2JqZWN0LmMKQEAgLTEyNiwyMSArMTI2LDI0IEBAIGx0b19vYmpfZmlsZV9v cGVuIChjb25zdCBjaGFyICpmaWxlbmFtZSwgYm9vbCB3cml0YWJsZSkKICAg ICAgIGlmIChhdHRycyA9PSBOVUxMKQogCWdvdG8gZmFpbF9lcnJtc2c7CiAK ICAgICAgIGlmIChzYXZlZF9hdHRyaWJ1dGVzID09IE5VTEwpCiAJc2F2ZWRf YXR0cmlidXRlcyA9IGF0dHJzOwogICAgICAgZWxzZQogCXsKIAkgIGVycm1z ZyA9IHNpbXBsZV9vYmplY3RfYXR0cmlidXRlc19tZXJnZSAoc2F2ZWRfYXR0 cmlidXRlcywgYXR0cnMsCiAJCQkJCQkgICAmZXJyKTsKIAkgIGlmIChlcnJt c2cgIT0gTlVMTCkKLQkgICAgZ290byBmYWlsX2Vycm1zZzsKKwkgICAgewor CSAgICAgIGZyZWUgKGF0dHJzKTsKKwkgICAgICBnb3RvIGZhaWxfZXJybXNn OworCSAgICB9CiAJfQogICAgIH0KICAgZWxzZQogICAgIHsKICAgICAgIGdj Y19hc3NlcnQgKHNhdmVkX2F0dHJpYnV0ZXMgIT0gTlVMTCk7CiAgICAgICBs by0+c29ial93ID0gc2ltcGxlX29iamVjdF9zdGFydF93cml0ZSAoc2F2ZWRf YXR0cmlidXRlcywKIAkJCQkJICAgICAgTFRPX1NFR01FTlRfTkFNRSwKIAkJ CQkJICAgICAgJmVycm1zZywgJmVycik7CiAgICAgICBpZiAobG8tPnNvYmpf dyA9PSBOVUxMKQogCWdvdG8gZmFpbF9lcnJtc2c7CkBAIC0xNDgsMjUgKzE1 MSwyNyBAQCBsdG9fb2JqX2ZpbGVfb3BlbiAoY29uc3QgY2hhciAqZmlsZW5h bWUsIGJvb2wgd3JpdGFibGUpCiAKICAgcmV0dXJuICZsby0+YmFzZTsKIAog IGZhaWxfZXJybXNnOgogICBpZiAoZXJyID09IDApCiAgICAgZXJyb3IgKCIl czogJXMiLCBmbmFtZSwgZXJybXNnKTsKICAgZWxzZQogICAgIGVycm9yICgi JXM6ICVzOiAlcyIsIGZuYW1lLCBlcnJtc2csIHhzdHJlcnJvciAoZXJyKSk7 CiAJCQkJCSAKICBmYWlsOgotICBpZiAobG8gIT0gTlVMTCkKKyAgaWYgKGxv LT5mZCAhPSAtMSkKICAgICBsdG9fb2JqX2ZpbGVfY2xvc2UgKChsdG9fZmls ZSAqKSBsbyk7CisgIGZyZWUgKGxvKTsKICAgcmV0dXJuIE5VTEw7CiB9CiAK KwogLyogQ2xvc2UgRklMRS4gIElmIEZJTEUgd2FzIG9wZW5lZCBmb3Igd3Jp dGluZywgaXQgaXMgd3JpdHRlbiBvdXQKICAgIG5vdy4gICovCiAKIHZvaWQK IGx0b19vYmpfZmlsZV9jbG9zZSAobHRvX2ZpbGUgKmZpbGUpCiB7CiAgIHN0 cnVjdCBsdG9fc2ltcGxlX29iamVjdCAqbG8gPSAoc3RydWN0IGx0b19zaW1w bGVfb2JqZWN0ICopIGZpbGU7CiAKICAgaWYgKGxvLT5zb2JqX3IgIT0gTlVM TCkKICAgICBzaW1wbGVfb2JqZWN0X3JlbGVhc2VfcmVhZCAobG8tPnNvYmpf cik7Cg== --------------030809080806040103080902--