From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19126 invoked by alias); 16 Oct 2012 11:28:22 -0000 Received: (qmail 19117 invoked by uid 22791); 16 Oct 2012 11:28:22 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-qa0-f54.google.com (HELO mail-qa0-f54.google.com) (209.85.216.54) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Oct 2012 11:28:18 +0000 Received: by mail-qa0-f54.google.com with SMTP id p27so386438qat.20 for ; Tue, 16 Oct 2012 04:28:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:organization:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding:x-gm-message-state; bh=JhnID43k53xchJyQZCp0Dy+alm/7uo8yLbKH+lXljj8=; b=THydGeJCx/TtYwtGcJG7OwF65eEtR4tjb+NeCXKHO60VS6as0OWLw6M1vBuo1E8kXd QoRz46q6EgiijRHIyIonbxKGWrV4AGloWF11QmpIy9zdWcuM/HUN4doLll1K9dHMHUYf OxSzAXb0JYVE83vksLkxAlPaZNm5EcXa9ssXIMED63sCuvZGTFGkgJjWTkeLBqsO4NtV 4kv0/qwJ+zUDlkOI2Wvl7QS++piQvos04Of38nT42a5w6UlJwK4I6GBiVXC6NuwV72O6 8LpO1oOvnPrwf3ASkiWIHDhH3HsnGTO14vkJGoR1tTcVEV5loAXWMMlTwKSjZEdRe/16 UJjg== Received: by 10.224.184.133 with SMTP id ck5mr25375238qab.42.1350386897417; Tue, 16 Oct 2012 04:28:17 -0700 (PDT) Received: from urs-home.corp.google.com ([172.26.41.77]) by mx.google.com with ESMTPS id jw1sm16594871qeb.13.2012.10.16.04.28.15 (version=SSLv3 cipher=OTHER); Tue, 16 Oct 2012 04:28:16 -0700 (PDT) Message-ID: <507D44CF.1090305@google.com> Date: Tue, 16 Oct 2012 11:39:00 -0000 From: Diego Novillo User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Rainer Orth CC: Ian Lance Taylor , gcc-patches@gcc.gnu.org Subject: Re: [asan] Emit GIMPLE directly, small cleanups References: <20121011163847.GE584@tucnak.redhat.com> <5076FE77.1060806@google.com> <20121011173129.GF584@tucnak.redhat.com> <50782040.7080708@google.com> <50783C7A.60903@google.com> <20121012164002.GQ584@tucnak.redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQmzap0pj/xhNvq0WJZNv52UumOfNzVghf/sVfM4R71Lg84yqUFYArGVCDm6OnXnfFfvBPab7YNElF+VFotRJc0sMondr+TOib3bEBpOr8AFES8UmHLpyaXbMjRJfK7NTujljzZUnThXXkf7UkHXRdBfjCJfNY0EZxsDGD/56sMV57vB/r8QhzNd8rGR8LXfqOa8JABW X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-10/txt/msg01517.txt.bz2 On 2012-10-16 07:05 , Rainer Orth wrote: > Diego Novillo writes: > >> On Mon, Oct 15, 2012 at 11:55 AM, Ian Lance Taylor wrote: >> >>> In my opinion, supporting the full range of GCC testsuite annotations >>> means imposing a lot of mechanism that the Go testsuite does not >>> require. It would complicate the Go testsuite for no benefit. >>> Anybody who can understand the GCC testsuite annotations can >>> understand the much simpler Go testsuite annotations. >> >> Agreed. The fact that we have to suffer DejaGNU does not gives the >> right to make other projects miserable. > > But importing different upstream testsuites with different annotation > systems allows them to make GCC maintainer's lives miserable? Yes, absolutely. We have to adapt to upstream's conventions. If that means putting translation layers, the onus is on us. Alternately, we could import libasan the same way we import things like zlib or boehm-gc and then re-write the testsuite. That makes it harder to import newer versions, however. Finally, we could simply duplicate libasan's testsuite inside gcc/testsuite/asan and add our own tests as well. This may be the more practical choice. Diego.