From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106562 invoked by alias); 18 Jul 2019 21:11:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106548 invoked by uid 89); 18 Jul 2019 21:11:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.1 spammy=H*f:sk:176edde, HContent-Transfer-Encoding:8bit X-HELO: mail-wm1-f53.google.com Received: from mail-wm1-f53.google.com (HELO mail-wm1-f53.google.com) (209.85.128.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Jul 2019 21:11:52 +0000 Received: by mail-wm1-f53.google.com with SMTP id h19so22348084wme.0; Thu, 18 Jul 2019 14:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=d5Z25Dnayb8oCYVTlrONpUMOldf42mmhbIbTJDKroEo=; b=ssOIm6SUKFSOhIivFUMLu9nnuuJtKylHeR2NOHD/9t4A40EzPyMEEEC8IS4wnW0Yg3 MDt0/NTdTMprIwy9GLWJqyXvR+fxxb1ZHSjFzqJr3blqZiLFzAV3AlDmGkXt302IVdev LsFsvgd1ugxk0mV0KR9joOVhq1/BkcbkZqtSras0IZqKxzWEBfc2wn74Yh6+DzK+/jhN H7UTIgAf1QemUfna7CvGHVUWqFm9gmto0LK8YXOtcqeHYJ1cwddUDvB2ywDhhgCDUFOm 566eiAswRhmUYnoNwRVmsvcG+cHPq8ILX+F/1me0IuJG5/rzFE3J+MKy4O/EtTnWvLyf oUVQ== Return-Path: Received: from ?IPv6:2a01:e0a:1dc:b1c0:545c:8fc4:97bc:792b? ([2a01:e0a:1dc:b1c0:545c:8fc4:97bc:792b]) by smtp.googlemail.com with ESMTPSA id r14sm26396931wrx.57.2019.07.18.14.11.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jul 2019 14:11:49 -0700 (PDT) Subject: Re: Fix failing tests after PR libstdc++/85965 To: Jonathan Wakely Cc: "libstdc++@gcc.gnu.org" , gcc-patches References: <176edde6-81d4-9685-05db-8568803f7e3d@gmail.com> <20190718101844.GK29215@redhat.com> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Message-ID: <509811c6-59ce-6a0b-252d-f1ee6fc83388@gmail.com> Date: Thu, 18 Jul 2019 21:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190718101844.GK29215@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2019-07/txt/msg01273.txt.bz2 Got it, it is my PR 68303 patch which was introducing this regression. I fix it to restore those assertions. You'll see once the awaiting hashtable patches are in... On 7/18/19 12:18 PM, Jonathan Wakely wrote: > On 18/07/19 07:41 +0200, François Dumont wrote: >> Since commit 5d3695d03b7bdade9f4d05d2b those tests are failing. >> >>     * testsuite/23_containers/unordered_map/48101_neg.cc: Adapt dg-error >>     after PR libstdc++/85965 fix. >>     * testsuite/23_containers/unordered_multimap/48101_neg.cc: Likewise. >>     * testsuite/23_containers/unordered_multiset/48101_neg.cc: Likewise. >>     * testsuite/23_containers/unordered_set/48101_neg.cc >> >> It is quite trivial but I wonder if there is another plan to restore >> those static assertions differently. >> >> Ok to commit ? > > No. I don't see these failures. With the first change applied, I see a > new failure. > > The patch seems wrong. > > >