* [PATCH] PR 54472
@ 2012-10-30 8:27 Andrey Belevantsev
2012-11-09 12:32 ` Andrey Belevantsev
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Belevantsev @ 2012-10-30 8:27 UTC (permalink / raw)
To: GCC Patches; +Cc: Vladimir N. Makarov
Hello,
This PR is due to the selective scheduling missing the dependencies with
implicit_sets. From the sched-deps.c code it looks like implicit sets
generate anti dependencies with either sets, uses or clobbers, so that's
that I've done with the below patch. Vlad, as it looks you've added
implicit sets, does the above conclusion look correct? I will commit the
patch then after bootstrapping and testing will complete.
Yours,
Andrey
2012-10-30 Andrey Belevantsev <abel@ispras.ru>
PR rtl-optimization/54472
* sel-sched-ir.c (has_dependence_note_reg_set): Handle
implicit sets.
(has_dependence_note_reg_clobber,
has_dependence_note_reg_use): Likewise.
2012-10-30 Andrey Belevantsev <abel@ispras.ru>
PR rtl-optimization/54472
* gcc.dg/pr54472.c: New test.
diff --git a/gcc/sel-sched-ir.c b/gcc/sel-sched-ir.c
index 2a7a170..220568a 100644
--- a/gcc/sel-sched-ir.c
+++ b/gcc/sel-sched-ir.c
@@ -3185,7 +3185,7 @@ has_dependence_note_reg_set (int regno)
|| reg_last->clobbers != NULL)
*dsp = (*dsp & ~SPECULATIVE) | DEP_OUTPUT;
- if (reg_last->uses)
+ if (reg_last->uses || reg_last->implicit_sets)
*dsp = (*dsp & ~SPECULATIVE) | DEP_ANTI;
}
}
@@ -3205,7 +3205,7 @@ has_dependence_note_reg_clobber (int regno)
if (reg_last->sets)
*dsp = (*dsp & ~SPECULATIVE) | DEP_OUTPUT;
- if (reg_last->uses)
+ if (reg_last->uses || reg_last->implicit_sets)
*dsp = (*dsp & ~SPECULATIVE) | DEP_ANTI;
}
}
@@ -3225,7 +3225,7 @@ has_dependence_note_reg_use (int regno)
if (reg_last->sets)
*dsp = (*dsp & ~SPECULATIVE) | DEP_TRUE;
- if (reg_last->clobbers)
+ if (reg_last->clobbers || reg_last->implicit_sets)
*dsp = (*dsp & ~SPECULATIVE) | DEP_ANTI;
/* Merge BE_IN_SPEC bits into *DSP when the dependency producer
diff --git a/gcc/testsuite/gcc.dg/pr54472.c b/gcc/testsuite/gcc.dg/pr54472.c
new file mode 100644
index 0000000..9395203
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr54472.c
@@ -0,0 +1,9 @@
+/* { dg-do compile { target powerpc*-*-* ia64-*-* x86_64-*-* } } */
+/* { dg-options "-O -fschedule-insns -fselective-scheduling" } */
+
+int main ()
+{
+ int a[3][3][3];
+ __builtin_memset (a, 0, sizeof a);
+ return 0;
+}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PR 54472
2012-10-30 8:27 [PATCH] PR 54472 Andrey Belevantsev
@ 2012-11-09 12:32 ` Andrey Belevantsev
0 siblings, 0 replies; 2+ messages in thread
From: Andrey Belevantsev @ 2012-11-09 12:32 UTC (permalink / raw)
To: GCC Patches
On 30.10.2012 12:09, Andrey Belevantsev wrote:
> Hello,
>
> This PR is due to the selective scheduling missing the dependencies with
> implicit_sets. From the sched-deps.c code it looks like implicit sets
> generate anti dependencies with either sets, uses or clobbers, so that's
> that I've done with the below patch. Vlad, as it looks you've added
> implicit sets, does the above conclusion look correct? I will commit the
> patch then after bootstrapping and testing will complete.
>
Now committed after offline discussion with Vlad and Alexander.
Andrey
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-09 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-30 8:27 [PATCH] PR 54472 Andrey Belevantsev
2012-11-09 12:32 ` Andrey Belevantsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).