From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-331638-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 22698 invoked by alias); 13 Nov 2012 02:39:26 -0000
Received: (qmail 22672 invoked by uid 22791); 13 Nov 2012 02:39:21 -0000
X-SWARE-Spam-Status: No, hits=-7.1 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Nov 2012 02:39:11 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAD2dASn030612	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 12 Nov 2012 21:39:10 -0500
Received: from [10.3.113.62] (ovpn-113-62.phx2.redhat.com [10.3.113.62])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qAD2d8ds016807;	Mon, 12 Nov 2012 21:39:09 -0500
Message-ID: <50A1B2CC.10902@redhat.com>
Date: Tue, 13 Nov 2012 02:39:00 -0000
From: Jason Merrill <jason@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121029 Thunderbird/16.0.2
MIME-Version: 1.0
To: Sriraman Tallam <tmsriram@google.com>
CC: David Li <davidxl@google.com>, "H.J. Lu" <hjl.tools@gmail.com>,        gcc-patches List <gcc-patches@gcc.gnu.org>, Jan Hubicka <jh@suse.cz>,        Diego Novillo <dnovillo@google.com>
Subject: Re: User directed Function Multiversioning via Function Overloading (issue5752064)
References: <CAAs8HmxHF38ktt6syjWp-MpjiX+6NcXh7_8Xn6iKnAiF2vRymQ@mail.gmail.com> <CAAs8HmxEod=EJNyUjrD0-WaP0-cB5o_AN9oc2O2ryu--MRQf4w@mail.gmail.com> <CAAs8Hmyy9S+Ucg6rTDU3xGMg8JEaa0r3rNjbxhbjuk9H8Sb6wg@mail.gmail.com> <50816D63.3020908@google.com> <CAAs8HmzZUnGq9G3KQ-wesKOHVWJBHn1n0zyFhEOPxo+i0PBrww@mail.gmail.com> <CAAs8HmxXfBdsLOrhEnd=syUXfbo5gKa-QkdWQG=4bUeWOPrSfQ@mail.gmail.com> <20121026155447.GA4348@atrey.karlin.mff.cuni.cz> <CAAs8Hmw0KBhKp_3qe0gzVi1jw=LVg6GD1cv-++=Kh3OjThwB+A@mail.gmail.com> <50902624.3020705@redhat.com> <CAAs8Hmw09giv-5_v0irhByTjTJV=kD58rCAD2SAz7M8zrwjBOA@mail.gmail.com> <50912F66.3030707@redhat.com> <CAAs8Hmz4CNzyJHAPoRkEe5gtL3YXSqoNHGMeZdm0uJujFHkMhQ@mail.gmail.com> <CAAs8Hmz7aDcN+2YGfH8ixrgUt+A=PuTt8ZzPhUVeQTgSWGP-Ww@mail.gmail.com> <50993222.3010609@redhat.com> <CAAs8Hmw-WXwbgUvwmegd680i0rT8CG2M=XYRa1V5ejMqbRd1Bw@mail.gmail.com> <50A08349.4070101@redhat.com> <CAAs8Hmwa80GxP=eHEq0KZSKqA4Y9QtfbU-ATx1g42PRTpcjkuA@mail.gmail.com>
In-Reply-To: <CAAs8Hmwa80GxP=eHEq0KZSKqA4Y9QtfbU-ATx1g42PRTpcjkuA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-11/txt/msg00960.txt.bz2

On 11/12/2012 08:11 PM, Sriraman Tallam wrote:
> +	    && !targetm.target_option.function_versions (fn,
> +	         TREE_PURPOSE (match)))

The second argument should be lined up with the left paren if it's on a 
different line.  Perhaps formatting this as

&& !(targetm.target_option.function_versions
      (fn, TREE_PURPOSE (match))))

would be better.

> +      error_at (input_location, "Use of multiversioned function "
> +	    "Multiversioning needs ifunc which is not supported "

We don't capitalize the first letter of a diagnostic.

OK with those changes.

Jason