From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26818 invoked by alias); 20 Nov 2012 10:32:26 -0000 Received: (qmail 26780 invoked by uid 22791); 20 Nov 2012 10:32:26 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 20 Nov 2012 10:32:20 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 20 Nov 2012 10:32:19 +0000 Received: from [10.1.69.67] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 20 Nov 2012 10:32:16 +0000 Message-ID: <50AB5C2F.8090109@arm.com> Date: Tue, 20 Nov 2012 10:32:00 -0000 From: Richard Earnshaw User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Kyrylo Tkachov CC: "gcc-patches@gcc.gnu.org" , Ramana Radhakrishnan Subject: Re: [PATCH][ARM] Define predicable attribute for arm_abssi2 and arm_neg_abssi2 References: <00ab01cdc67e$72294a60$567bdf20$@tkachov@arm.com> <50AA74CB.2020908@arm.com> <00af01cdc709$53e608f0$fbb21ad0$@tkachov@arm.com> In-Reply-To: <00af01cdc709$53e608f0$fbb21ad0$@tkachov@arm.com> X-MC-Unique: 112112010321900801 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg01656.txt.bz2 On 20/11/12 10:25, Kyrylo Tkachov wrote: > Hi all, > This is the updated version of the patch. It defines the predicable > attribute for the equivalent abssi2 and neg_abssi2 patterns in thumb2.md. > The previous version (with the changes only to arm.md) has been okayed but > not applied and this patch supersedes it. > The previous version is: > http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01578.html > > No regressions for arm-none-eabi for qemu. > > Ok for trunk? > > Thanks, > Kyrill > > gcc/ChangeLog > > 2012-11-20 Kyrylo Tkachov > > * config/arm/arm.md (*arm_abssi2): Define predicable attribute. > (*arm_neg_abssi2): Likewise. > * config/arm/thumb2.md (*thumb2_abssi2): Likewise. > (*thumb2_neg_abssi2): Likewise. > > > -----Original Message----- > From: Ramana Radhakrishnan > Sent: 19 November 2012 18:05 > To: Kyrylo Tkachov > Cc: gcc-patches@gcc.gnu.org; Richard Earnshaw > Subject: Re: [PATCH][ARM] Define predicable attribute for arm_abssi2 and > arm_neg_abssi2 > > On 11/19/12 17:51, Kyrylo Tkachov wrote: >> Hi all, >> This patch updates the arm_abssi2 and arm_neg_abssi2 patterns in the ARM >> machine description. >> We define the predicable attribute based on the alternative. When the >> patterns were introduced it was not possible to do that. >> Now the second alternative in each of the patterns that supports > predication >> is defined as predicable. >> >> No regressions on arm-none-eabi with qemu. >> >> Ok for trunk? > > Ok, please apply. > > Ramana > OK. Thanks. R.