From: Richard Henderson <rth@redhat.com>
To: Kirill Yukhin <kirill.yukhin@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, RFC] Dumping expanded MD files
Date: Tue, 27 Nov 2012 17:34:00 -0000 [thread overview]
Message-ID: <50B4F99B.60900@redhat.com> (raw)
In-Reply-To: <CAGs3RfvHEekrCcagF3uvFgsOfW+xLzFyi+RyoEY+qNkNa=-k3w@mail.gmail.com>
On 11/22/2012 09:48 AM, Kirill Yukhin wrote:
> +.PHONY: s-mddump
> +s-mddump: $(BUILD_RTL) $(MD_DEPS) build/genmddump$(build_exeext)
> + $(RUN_GEN) build/genmddump$(build_exeext) $(md_file) 2> tmp-mddump.md
I think just
mddump: ...
$(RUN_GEN) ... > mddump
will be sufficient. This is not actually used by the build at all, so we
don't need to play games with stamp files etc.
There's no need for top-level makefile changes at all. When you want to
use this, simply cd into the gcc subdirectory.
> +/* Dump all available rtl queues. */
> +void
> +dump_expanded_md (void)
Why? Seems to me that you can just have genmddump.c simply use the
generic read_md_rtx interface, dumping as it goes. You might also
consider dumping the pattern_lineno argument as a comment before the
pattern. Otherwise it might be tricky to match up the dump pattern
with the original input file patterns.
r~
next prev parent reply other threads:[~2012-11-27 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 17:49 Kirill Yukhin
2012-11-23 9:26 ` Mike Stump
2012-11-24 3:00 ` Hans-Peter Nilsson
2012-11-27 17:34 ` Richard Henderson [this message]
2012-11-29 7:22 ` Michael Zolotukhin
2012-11-29 18:41 ` Richard Henderson
2012-11-29 19:06 ` Richard Henderson
2012-11-30 9:10 ` Michael Zolotukhin
2012-11-30 19:13 ` Richard Henderson
2012-12-04 12:59 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B4F99B.60900@redhat.com \
--to=rth@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).