From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-332919-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 11533 invoked by alias); 27 Nov 2012 17:34:26 -0000
Received: (qmail 11385 invoked by uid 22791); 27 Nov 2012 17:34:24 -0000
X-SWARE-Spam-Status: No, hits=-4.6 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MEDICAL_SUBJECT,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Nov 2012 17:34:20 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qARHYKrk027192	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 27 Nov 2012 12:34:20 -0500
Received: from anchor.twiddle.home (vpn-231-172.phx2.redhat.com [10.3.231.172])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qARHYJ2V014113;	Tue, 27 Nov 2012 12:34:20 -0500
Message-ID: <50B4F99B.60900@redhat.com>
Date: Tue, 27 Nov 2012 17:34:00 -0000
From: Richard Henderson <rth@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Kirill Yukhin <kirill.yukhin@gmail.com>
CC: Jakub Jelinek <jakub@redhat.com>,        gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, RFC] Dumping expanded MD files
References: <CAGs3RfvHEekrCcagF3uvFgsOfW+xLzFyi+RyoEY+qNkNa=-k3w@mail.gmail.com>
In-Reply-To: <CAGs3RfvHEekrCcagF3uvFgsOfW+xLzFyi+RyoEY+qNkNa=-k3w@mail.gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2012-11/txt/msg02241.txt.bz2

On 11/22/2012 09:48 AM, Kirill Yukhin wrote:
> +.PHONY: s-mddump
> +s-mddump: $(BUILD_RTL) $(MD_DEPS) build/genmddump$(build_exeext)
> +	$(RUN_GEN) build/genmddump$(build_exeext) $(md_file) 2> tmp-mddump.md

I think just 

mddump: ...
	$(RUN_GEN) ... > mddump

will be sufficient.  This is not actually used by the build at all, so we
don't need to play games with stamp files etc.

There's no need for top-level makefile changes at all.  When you want to
use this, simply cd into the gcc subdirectory.

> +/* Dump all available rtl queues.  */
> +void
> +dump_expanded_md (void)

Why?  Seems to me that you can just have genmddump.c simply use the
generic read_md_rtx interface, dumping as it goes.  You might also
consider dumping the pattern_lineno argument as a comment before the
pattern.  Otherwise it might be tricky to match up the dump pattern
with the original input file patterns.


r~