From: Richard Henderson <rth@redhat.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch i386} Fix PR 55171 - [4.7/4.8 Regression] incorrect virtual thunk on mingw
Date: Wed, 28 Nov 2012 15:57:00 -0000 [thread overview]
Message-ID: <50B63460.7000902@redhat.com> (raw)
In-Reply-To: <CAEwic4Z9u_wGBqG-g7-E8LHxqkVK9i-DqUNm4+cy5hiaS2X84A@mail.gmail.com>
On 11/25/2012 07:26 AM, Kai Tietz wrote:
> - if ((ccvt & (IX86_CALLCVT_FASTCALL | IX86_CALLCVT_THISCALL)) != 0)
> + if ((ccvt & IX86_CALLCVT_FASTCALL) != 0)
> {
> /* Fastcall functions use ecx/edx for arguments, which leaves
> us with EAX for the static chain.
> @@ -25142,6 +25160,12 @@ ix86_static_chain (const_tree fndecl, bo
> leaves us with EAX for the static chain. */
> regno = AX_REG;
> }
> + else if ((ccvt & IX86_CALLCVT_THISCALL) != 0)
> + {
> + /* Thiscall functions use ecx for arguments, which leaves
> + us with EDX for the static chain. */
> + regno = DX_REG;
> + }
How is this not abi breakage? Why not leave eax as the static chain?
r~
next prev parent reply other threads:[~2012-11-28 15:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 15:26 Kai Tietz
2012-11-28 15:57 ` Richard Henderson [this message]
2012-11-28 17:53 ` Kai Tietz
2012-11-28 18:33 ` Richard Henderson
2012-11-28 18:53 ` Kai Tietz
2012-11-28 20:09 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B63460.7000902@redhat.com \
--to=rth@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ktietz70@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).