From: Jason Merrill <jason@redhat.com>
To: Ed Smith-Rowland <3dw4rd@verizon.net>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, PR52654, C++11] Warn on overflow in user-defined literals
Date: Thu, 29 Nov 2012 00:31:00 -0000 [thread overview]
Message-ID: <50B6ACDC.4020309@redhat.com> (raw)
In-Reply-To: <50B69AA0.2000102@verizon.net>
On 11/28/2012 06:13 PM, Ed Smith-Rowland wrote:
> Ultimately we should probably revisit this and 54413 by parsing the literal
> numbers in the C++ front end. That won't happen for 4.8.
That sounds like you're proposing to duplicate code?
> - /* Both C and C++ require a diagnostic for a floating constant
> - outside the range of representable values of its type. Since we
> - have __builtin_inf* to produce an infinity, this is now a
> - mandatory pedwarn if the target does not support infinities. */
> + /* Both C and C++ require a diagnostic for a floating constant
> + outside the range of representable values of its type. Since we
> + have __builtin_inf* to produce an infinity, this is now a
> + mandatory pedwarn if the target does not support infinities. */
This seems unintentional.
OK with that indentation change removed.
Jason
next parent reply other threads:[~2012-11-29 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50B69AA0.2000102@verizon.net>
2012-11-29 0:31 ` Jason Merrill [this message]
2012-11-28 3:13 Ed Smith-Rowland
2012-11-28 10:26 ` Paolo Carlini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B6ACDC.4020309@redhat.com \
--to=jason@redhat.com \
--cc=3dw4rd@verizon.net \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).