From: Pedro Alves <palves@redhat.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: Re: [patch c++]: 1 of 7 Fix for PR target/53912 bootstrap fails using default c++ mode in stage 2 and 3 for native x86_64-w64-mingw32
Date: Thu, 29 Nov 2012 12:49:00 -0000 [thread overview]
Message-ID: <50B759CE.1090107@redhat.com> (raw)
In-Reply-To: <CAEwic4bHWyJSDyaJPH_9AVAj8GSBQi-H8hFYK7AiFbTSPJEZrQ@mail.gmail.com>
On 11/29/2012 12:45 PM, Kai Tietz wrote:
> 2012/11/29 Pedro Alves <palves@redhat.com>:
>> On 11/29/2012 12:03 PM, Kai Tietz wrote:
>>> Hello,
>>>
>>> this trivial patch fixes a bootstrap issue on LLP64 hosts.
>>
>> But it's trivial at the expense of truncating the pointer.
>> Looking around, I'd think that something like casting to hwi (after uintptr_t),
>> and then use HOST_WIDE_INT_PRINT_HEX as format would be the gcc way.
>>
>>> Index: cp/class.c
>>> ===================================================================
>>> --- cp/class.c (Revision 193925)
>>> +++ cp/class.c (Arbeitskopie)
>>> @@ -7817,7 +7817,7 @@ dump_class_hierarchy_r (FILE *stream,
>>> indented = maybe_indent_hierarchy (stream, indent, 0);
>>> fprintf (stream, "%s (0x%lx) ",
>>> type_as_string (BINFO_TYPE (binfo), TFF_PLAIN_IDENTIFIER),
>>> - (unsigned long) binfo);
>>> + (unsigned long) (uintptr_t) binfo);
>>
> Well, hwi format is of course the way to display pointer complete. On
> the other hand are in most cases lower 32-bit sufficent on
> debug-output.
But what's the point of not making it complete? It's not like we're talking
about a large amount of work to get it right. It should be a two-line patch?
--
Pedro Alves
next prev parent reply other threads:[~2012-11-29 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 12:03 Kai Tietz
2012-11-29 12:24 ` Pedro Alves
2012-11-29 12:45 ` Kai Tietz
2012-11-29 12:49 ` Pedro Alves [this message]
2012-11-29 13:15 ` Kai Tietz
2012-11-29 15:21 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B759CE.1090107@redhat.com \
--to=palves@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=ktietz70@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).